Re: [PATCH edk2-platforms 1/1] Silicon/SynQuacer/DeviceTree: add OP-TEE driver node

[Ard Biesheuvel <ard.biesheuvel@linaro.org>]

On 20 July 2018 at 19:13, Sumit Garg <sumit.garg@linaro.org> wrote:
> On Fri, 20 Jul 2018 at 15:31, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote:
>>
>> On 20 July 2018 at 16:12, Sumit Garg <sumit.garg@linaro.org> wrote:
>> > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>> > Cc: Leif Lindholm <leif.lindholm@linaro.org>
>> > Contributed-under: TianoCore Contribution Agreement 1.1
>> > Signed-off-by: Sumit Garg <sumit.garg@linaro.org>
>> > ---
>> >  Silicon/Socionext/SynQuacer/DeviceTree/SynQuacer.dtsi | 7 +++++++
>> >  1 file changed, 7 insertions(+)
>> >
>> > diff --git a/Silicon/Socionext/SynQuacer/DeviceTree/SynQuacer.dtsi b/Silicon/Socionext/SynQuacer/DeviceTree/SynQuacer.dtsi
>> > index 37d642e4b237..d109a5742793 100644
>> > --- a/Silicon/Socionext/SynQuacer/DeviceTree/SynQuacer.dtsi
>> > +++ b/Silicon/Socionext/SynQuacer/DeviceTree/SynQuacer.dtsi
>> > @@ -574,6 +574,13 @@
>> >          #address-cells = <1>;
>> >          #size-cells = <0>;
>> >      };
>> > +
>> > +    firmware {
>> > +        optee {
>> > +            compatible = "linaro,optee-tz";
>> > +            method = "smc";
>> > +        };
>> > +    };
>> >  };
>> >
>> >  #include "SynQuacerCaches.dtsi"
>>
>> Hello Sumit,
>>
>> Is it safe to provide this node when optee is not running?
>
> Yes it is safe. If optee is not running then Linux TEE driver exits
> gracefully with below info:
>
> [    1.976021] optee: probing for conduit method from DT.
> [    1.976033] optee: api uid mismatch
>

Ok, so it is safe but it still prints a nasty error.

So let's fix this properly: you can check the existing code to find
out how the mmc DT node gets enabled in PlatformDxe.