From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ard.biesheuvel@linaro.org>
Received-SPF: Pass (sender SPF authorized) identity=mailfrom;
 client-ip=2607:f8b0:4001:c0b::243; helo=mail-it0-x243.google.com;
 envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org 
Received: from mail-it0-x243.google.com (mail-it0-x243.google.com
 [IPv6:2607:f8b0:4001:c0b::243])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by ml01.01.org (Postfix) with ESMTPS id A6DB72098EAB2
 for <edk2-devel@lists.01.org>; Fri, 20 Jul 2018 03:19:17 -0700 (PDT)
Received: by mail-it0-x243.google.com with SMTP id j185-v6so13924035ite.1
 for <edk2-devel@lists.01.org>; Fri, 20 Jul 2018 03:19:17 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;
 h=mime-version:in-reply-to:references:from:date:message-id:subject:to
 :cc; bh=lEJhTvqbz+3M0xdHzIaFg3TvYO7SjhhRJtKbDRHa0rA=;
 b=AiB2oT6ar0L3atueb30dBMUwIBRRxSSUg/jWY0/RiLYub+3buxJ3/a1O3peaflLa2v
 CZ+JZy9JG8HWa6L6sI0X4i//Eaq2U0clKWayMdJUO7siV/kxsMK9blxgRgLbkh4GAJ68
 EHCGMP4YYfDZpcid8js7q4LYr3dZKOdXPVnO0=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:in-reply-to:references:from:date
 :message-id:subject:to:cc;
 bh=lEJhTvqbz+3M0xdHzIaFg3TvYO7SjhhRJtKbDRHa0rA=;
 b=MwlgTOqtzIWPCPBzYVsdu5HUK5vrGpGWmeVNeWvSd9Zsd1ozWUxU4H0GU0uwYKltNf
 svrb+GgqNcuISBdHLEZv53oos/qIa169HynHxF/IGHUunxnUvM7v0jPxSjy01uLVHn3i
 sdYZ/4eOVITmLeE+O76SxarEz/yy1I4XwvXA3wyVvTW2lDlqp3nS/tYY75sJKwhPuH9C
 EZdisqv3b7QTlx6kssaRuYiv213RN/Djy81twyXuGNYwLGoIOx7NRr0G8C9tTRoBn8qR
 keS2a1hUuXWI/agUPPci2aLCIsMaRpFKU3/RMkAa8KAreHAUssLXgdAaBGZtgcMFXJjp
 QNcw==
X-Gm-Message-State: AOUpUlGpAGVtDiRO7Vaox/5/fq9Dn55DI16HBQbwg2mzCTqoT6tdGzUU
 mSYque6uNCPUv8w7nK+DGZPoRsBy85f92EBKoxjvx0wF
X-Google-Smtp-Source: AAOMgpeYw5y/cozeOK1kpTMFBX5H5TAcwR2bKvMtySkzFWj+qfJJikNGtFaqJjCKUgEmAx549le8X2kW38c++jiL2Jc=
X-Received: by 2002:a24:610d:: with SMTP id
 s13-v6mr1334402itc.68.1532081956356; 
 Fri, 20 Jul 2018 03:19:16 -0700 (PDT)
MIME-Version: 1.0
Received: by 2002:a6b:ac05:0:0:0:0:0 with HTTP; Fri, 20 Jul 2018 03:19:15
 -0700 (PDT)
In-Reply-To: <CAFA6WYO9zZoaw3jNT7P1qp+YYeM7xc28=r-mgK8RMMR7TQD0_A@mail.gmail.com>
References: <1532070779-7544-1-git-send-email-sumit.garg@linaro.org>
 <CAKv+Gu_U1dR=9FtGdpYPypkRazY1ne5icJp6xkNU+gTF7hKasg@mail.gmail.com>
 <CAFA6WYO9zZoaw3jNT7P1qp+YYeM7xc28=r-mgK8RMMR7TQD0_A@mail.gmail.com>
From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Date: Fri, 20 Jul 2018 19:19:15 +0900
Message-ID: <CAKv+Gu_02AAbfP+vNbHskANLicGgATdpartKD36XacNLM6HDbw@mail.gmail.com>
To: Sumit Garg <sumit.garg@linaro.org>
Cc: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
 Patch Tracking <patches@linaro.org>, 
 Leif Lindholm <leif.lindholm@linaro.org>
Subject: Re: [PATCH edk2-platforms 1/1] Silicon/SynQuacer/DeviceTree: add OP-TEE driver node
X-BeenThere: edk2-devel@lists.01.org
X-Mailman-Version: 2.1.27
Precedence: list
List-Id: EDK II Development  <edk2-devel.lists.01.org>
List-Unsubscribe: <https://lists.01.org/mailman/options/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=unsubscribe>
List-Archive: <http://lists.01.org/pipermail/edk2-devel/>
List-Post: <mailto:edk2-devel@lists.01.org>
List-Help: <mailto:edk2-devel-request@lists.01.org?subject=help>
List-Subscribe: <https://lists.01.org/mailman/listinfo/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=subscribe>
X-List-Received-Date: Fri, 20 Jul 2018 10:19:17 -0000
Content-Type: text/plain; charset="UTF-8"

On 20 July 2018 at 19:13, Sumit Garg <sumit.garg@linaro.org> wrote:
> On Fri, 20 Jul 2018 at 15:31, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote:
>>
>> On 20 July 2018 at 16:12, Sumit Garg <sumit.garg@linaro.org> wrote:
>> > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>> > Cc: Leif Lindholm <leif.lindholm@linaro.org>
>> > Contributed-under: TianoCore Contribution Agreement 1.1
>> > Signed-off-by: Sumit Garg <sumit.garg@linaro.org>
>> > ---
>> >  Silicon/Socionext/SynQuacer/DeviceTree/SynQuacer.dtsi | 7 +++++++
>> >  1 file changed, 7 insertions(+)
>> >
>> > diff --git a/Silicon/Socionext/SynQuacer/DeviceTree/SynQuacer.dtsi b/Silicon/Socionext/SynQuacer/DeviceTree/SynQuacer.dtsi
>> > index 37d642e4b237..d109a5742793 100644
>> > --- a/Silicon/Socionext/SynQuacer/DeviceTree/SynQuacer.dtsi
>> > +++ b/Silicon/Socionext/SynQuacer/DeviceTree/SynQuacer.dtsi
>> > @@ -574,6 +574,13 @@
>> >          #address-cells = <1>;
>> >          #size-cells = <0>;
>> >      };
>> > +
>> > +    firmware {
>> > +        optee {
>> > +            compatible = "linaro,optee-tz";
>> > +            method = "smc";
>> > +        };
>> > +    };
>> >  };
>> >
>> >  #include "SynQuacerCaches.dtsi"
>>
>> Hello Sumit,
>>
>> Is it safe to provide this node when optee is not running?
>
> Yes it is safe. If optee is not running then Linux TEE driver exits
> gracefully with below info:
>
> [    1.976021] optee: probing for conduit method from DT.
> [    1.976033] optee: api uid mismatch
>

Ok, so it is safe but it still prints a nasty error.

So let's fix this properly: you can check the existing code to find
out how the mmc DT node gets enabled in PlatformDxe.