Re: [PATCH] Platforms/ARM/Juno: limit ACPI support to v5.0 and higher

[Ard Biesheuvel <ard.biesheuvel@linaro.org>]

On 31 August 2016 at 11:29, Evan Lloyd <Evan.Lloyd@arm.com> wrote:
>
>>-----Original Message-----
>>From: Sudeep Holla [mailto:sudeep.holla@arm.com]
>>Sent: 25 August 2016 18:09
>>To: edk2-devel@lists.01.org; Linaro UEFI; Evan Lloyd; Leif Lindholm
>>Cc: Sudeep Holla; ard.biesheuvel@linaro.org
>>Subject: [PATCH] Platforms/ARM/Juno: limit ACPI support to v5.0 and higher
>>
>>The ACPI spec predates the AARCH64 architecture by 5 versions, so there
>>is no point in supporting anything below v5.0. So set the PCD that
>>controls the ACPI table generation to the appropriate value.
>>
>>Based on the commit e0692789058e ("ArmVirtPkg/ArmVirtQemu: limit ACPI
>>support to v5.0 and higher") in the upstream TianoCore by Ard Biesheuvel
>>
>>Contributed-under: TianoCore Contribution Agreement 1.0
>>Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>>Cc: Leif Lindholm <leif.lindholm@linaro.org>
>>Cc: Evan Lloyd <Evan.Lloyd@arm.com>
>>Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
>>---
>> Platforms/ARM/Juno/ArmJuno.dsc | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>>diff --git a/Platforms/ARM/Juno/ArmJuno.dsc
>>b/Platforms/ARM/Juno/ArmJuno.dsc
>>index c51d8f2e21ab..3029999bc66f 100644
>>--- a/Platforms/ARM/Juno/ArmJuno.dsc
>>+++ b/Platforms/ARM/Juno/ArmJuno.dsc
>>@@ -183,6 +183,10 @@
>>   #
>>   gEfiMdeModulePkgTokenSpaceGuid.PcdSmbiosVersion|0x0300
>>   gEfiMdeModulePkgTokenSpaceGuid.PcdSmbiosDocRev|0x0
>>+  #
>>+  # ACPI Table Version
>>+  #
>>+  gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiExposedTableVersions|0x20
>>
>> [PcdsPatchableInModule]
>>   # Console Resolution (Full HD)
>>--
>>2.7.4
> Reviewed-by: Evan Lloyd <Evan.Lloyd@arm.com>
>

Pushed, thanks.