From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c06::242; helo=mail-io0-x242.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-io0-x242.google.com (mail-io0-x242.google.com [IPv6:2607:f8b0:4001:c06::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 808B621D2BF00 for ; Mon, 22 Jan 2018 01:33:44 -0800 (PST) Received: by mail-io0-x242.google.com with SMTP id n7so8803285iob.0 for ; Mon, 22 Jan 2018 01:39:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=aSnfgFXYq42q8tcq9TtQ4UVO5sucbxRdjKlt4bth8eg=; b=RYQeM3LYK4l71eY++I40pankmzYBa2mMSEm+xSS/SmQNLIDESh0h8YFWAV59GE3vkw GSODDXL8KO+ll6WDclay03bUVz/ioa7xeoA0K3DyvJX0H8091rHwOF9RscY6I8euveMU 3ePzd1IuvegZuMHzaWCIXAkUmqIRJ4+Z46h4o= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=aSnfgFXYq42q8tcq9TtQ4UVO5sucbxRdjKlt4bth8eg=; b=jY5HbijQ9YDGwaNMLf6go6WKP47UbCzT6mShSBbLt0Ji1GoMczCBTjVRn4x0/0aIGp +WQty4owEWrLkQpRCtd5eU7CfNOyKS4NubI/6eTf2LWmVV5oyN35ltOZtBWJqN3sDsyk 5fS0ZBxrblR4pIQhwl3DtR6/SQaPn8HfYm7HFv1b9IbKMfDmGvcttzyRwL7gF9Z8C2rY U0H6GgpiJjoeXzk1bw0Jf834uF/H/la9kYiFYwU+kqwYtrGGp1NY5x63KlnIPZADzzH+ VyWkrm+zMQQF1qyweIQYZlgfgpnma2uv8gvj41hD0mLdV7FsjDLxS5Oj516s75OTNjnv 9fZA== X-Gm-Message-State: AKwxytdhtZRO0g7Zl1vLC8O3ZTI7wXuzG766CZT4IfKzqdyr0At12W12 JxV7wYEyLuzblR/DP7GYoyjEEvUVXTDoFhQwRjP3i1BegMo= X-Google-Smtp-Source: AH8x2249TSCRvFVEP4OfzQZlops1+EbLBkNtxyneny66YwkB920VjqD/fx01q0yr+Yk27c/WFLpldtes7U+MbFP9azc= X-Received: by 10.107.6.161 with SMTP id f33mr8011272ioi.196.1516613949451; Mon, 22 Jan 2018 01:39:09 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.112.13 with HTTP; Mon, 22 Jan 2018 01:39:09 -0800 (PST) In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E1A7592@SHSMSX104.ccr.corp.intel.com> References: <20180119162207.13207-1-ard.biesheuvel@linaro.org> <4A89E2EF3DFEDB4C8BFDE51014F606A14E1A70E6@SHSMSX104.ccr.corp.intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E1A7592@SHSMSX104.ccr.corp.intel.com> From: Ard Biesheuvel Date: Mon, 22 Jan 2018 09:39:09 +0000 Message-ID: To: "Gao, Liming" Cc: "edk2-devel@lists.01.org" , "leif.lindholm@linaro.org" , "Zhu, Yonghong" Subject: Re: [PATCH] BaseTools/tools_def CLANG35: ignore unknown warning options X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Jan 2018 09:33:45 -0000 Content-Type: text/plain; charset="UTF-8" On 22 January 2018 at 09:05, Gao, Liming wrote: > Ard: > I don't meet with the error on CLANG38 for x86. I use clang3.8 compiler. > I solved the mystery: CLANG38 for x86 already has -Wno-unknown-warning-option So if you agree, I will add it to CLANG35_WARNING_OVERRIDES (as in this patch) and move it from CLANG38_ALL_CC_FLAGS to CLANG38_WARNING_OVERRIDES as well. >>-----Original Message----- >>From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org] >>Sent: Monday, January 22, 2018 4:52 PM >>To: Gao, Liming >>Cc: edk2-devel@lists.01.org; leif.lindholm@linaro.org; Zhu, Yonghong >> >>Subject: Re: [PATCH] BaseTools/tools_def CLANG35: ignore unknown warning >>options >> >>On 22 January 2018 at 02:21, Gao, Liming wrote: >>> Reviewed-by: Liming Gao >>> >> >>Thanks Liming. >> >>Do you agree to add this to CLANG38_WARNING_OVERRIDES as well? We >>need >>this on ARM, and I assume on x86 as well. >> >> >>>>-----Original Message----- >>>>From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org] >>>>Sent: Saturday, January 20, 2018 12:22 AM >>>>To: edk2-devel@lists.01.org >>>>Cc: leif.lindholm@linaro.org; Gao, Liming ; Zhu, >>>>Yonghong ; Ard Biesheuvel >>>> >>>>Subject: [PATCH] BaseTools/tools_def CLANG35: ignore unknown warning >>>>options >>>> >>>>Ironically, disabling warnings in the OpensslLib library build is >>>>causing breakage when using the CLANG35 toolchain to build for ARM: >>>> >>>>error: unknown warning option '-Werror=maybe-uninitialized'; did you >>mean >>>>'-Werror=uninitialized'? [-Werror,-Wunknown-warning-option] >>>> >>>>So let's add -Wno-unknown-warning-option to the list of warning to >>>>ignore when using Clang 3.5 >>>> >>>>Contributed-under: TianoCore Contribution Agreement 1.1 >>>>Signed-off-by: Ard Biesheuvel >>>>--- >>>> BaseTools/Conf/tools_def.template | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>>diff --git a/BaseTools/Conf/tools_def.template >>>>b/BaseTools/Conf/tools_def.template >>>>index d8fde02ea351..6afe5ebe9fe3 100755 >>>>--- a/BaseTools/Conf/tools_def.template >>>>+++ b/BaseTools/Conf/tools_def.template >>>>@@ -5595,7 +5595,7 @@ RELEASE_GCC5_AARCH64_DLINK_FLAGS = >>>>DEF(GCC5_AARCH64_DLINK_FLAGS) -flto -Os -L$(W >>>> DEFINE CLANG35_ARM_TARGET = -target arm-linux-gnueabihf >>>> DEFINE CLANG35_AARCH64_TARGET = -target aarch64-linux-gnu >>>> >>>>-DEFINE CLANG35_WARNING_OVERRIDES = -Wno-parentheses-equality - >>>>Wno-tautological-compare -Wno-tautological-constant-out-of-range- >>compare >>>>-Wno-empty-body >>>>+DEFINE CLANG35_WARNING_OVERRIDES = -Wno-parentheses-equality - >>>>Wno-tautological-compare -Wno-tautological-constant-out-of-range- >>compare >>>>-Wno-empty-body -Wno-unknown-warning-option >>>> DEFINE CLANG35_ARM_CC_FLAGS = DEF(GCC_ARM_CC_FLAGS) >>>>DEF(CLANG35_ARM_TARGET) DEF(CLANG35_WARNING_OVERRIDES) >>>> DEFINE CLANG35_AARCH64_CC_FLAGS = DEF(GCC_AARCH64_CC_FLAGS) >>>>DEF(CLANG35_AARCH64_TARGET) -mcmodel=small >>>>DEF(CLANG35_WARNING_OVERRIDES) >>>> >>>>-- >>>>2.11.0 >>>