From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-it0-x230.google.com (mail-it0-x230.google.com [IPv6:2607:f8b0:4001:c0b::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id CF88781E80 for ; Mon, 14 Nov 2016 23:43:38 -0800 (PST) Received: by mail-it0-x230.google.com with SMTP id q124so155378210itd.1 for ; Mon, 14 Nov 2016 23:43:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=WUA1nIQ6FGeU3fNPxOi5GkzTCNa6ZaDss7c1+hHoQtI=; b=CAHPe3MiOBVARbLze3KFOtrs/NX3McSyPCuoC7izspee0oLi+G32jLk7bcYd3y3k4D zSRt+vbBLmlO3LzepKlkpWLm31yAs+dTDGh3kSPd9P/47NLi2YuP3I8rDN8wkXh9EM9e UxE5G+nascdajPNgRzdwc3X8ke4gaoUul5OM4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=WUA1nIQ6FGeU3fNPxOi5GkzTCNa6ZaDss7c1+hHoQtI=; b=WeXMZKjpiTV+N9L/dWJlLQr5Yj/JWbZ7aegamDjnktEqQWzEJZtJxo7UqXRIQtWYRE iiSo5d4hiwcIiCuc8tlcik3ngsBBwsctHWkBskobfVxTpMmP5L0v9vo4Rg2rvqj1lWwh 2rRmbxN/FCt9OQcj1VEodCA4xm6zBbrMPybVlOYfO39aHEIvyY706X3WnKv8i8ly5eJt 2TIkTyS0FIcweiKqzPDOdJAf9Co5lGhWUJ98simi49d7O2A8SP/yMNrdrglsUdJkYyLM h/0PYUGBxz8ZBADCpw/ZDSWdOLtIXHA5DQ4Cn4e3QvGWXl9weZRmcQDcJ2l2eKshStKF 0aGA== X-Gm-Message-State: ABUngvdon17mZFqrEfI5xFr7W6JhIUwa8kAGOC2tpCIEnOiRBt8IdO+ROVAeXM8M7/nti6t2S4LRSpHdnUJVJxS7 X-Received: by 10.107.18.39 with SMTP id a39mr27776114ioj.45.1479195822899; Mon, 14 Nov 2016 23:43:42 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.59.147 with HTTP; Mon, 14 Nov 2016 23:43:42 -0800 (PST) In-Reply-To: <1479157789-14674-1-git-send-email-jeremy.linton@arm.com> References: <1479157789-14674-1-git-send-email-jeremy.linton@arm.com> From: Ard Biesheuvel Date: Tue, 15 Nov 2016 07:43:42 +0000 Message-ID: To: Jeremy Linton Cc: edk2-devel-01 , Steve Capper , Leif Lindholm , Ryan Harkin , linaro-uefi Subject: Re: [PATCH 0/8] ATAPI support on SiI SATA adapter X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Nov 2016 07:43:39 -0000 Content-Type: text/plain; charset=UTF-8 Hi Jeremy, On 14 November 2016 at 21:09, Jeremy Linton wrote: > The SiI isn't an AHCI compatible adapter so it implements the EFI ATA > pass-through protocol directly. This works for fixed hard drives, but > not ATAPI attached devices (CDROM, DVDROM, TAPE, etc). > > This patch adds read only ATAPI support via the EFI SCSI pass-through > protocol, allowing boot from attached CD/DVD. This patch also cleans > up, and tweaks recovery paths/etc in the original driver. Very nice! Thanks for getting to the bottom of this. However, looking at the patches, they are riddled with coding style violations. I am usually less strict than Leif when it comes to upholding those, but these patches really need to be cleaned up to be considered for merging. > When > combined with the ARM/PCI dma lib changes this allows us to relax the > IO alignment requirement that caused grub failures. > What changes are you referring to here? > Finally, the OpenPlatformPkg/Juno must be updated, with another patch > to avoid build breaks now that the SiI has a dependency on the SCSI > libraries. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Jeremy Linton > > Jeremy Linton (7): > MdePkg IndustryStandard/Scsi.h: Add sense code macro > EmbeddedPkg: SiI3132: Add ScsiProtocol callbacks > EmbeddedPkg: SiI3132: Add SCSI protocol support to header > EmbeddedPkg: SiI3132: Break out FIS command submission > EmbeddedPkg: SiI3132: Cleanup device node creation > EmbeddedPkg: SiI3132: Enable SCSI pass-through protocol > EmbeddedPkg: SiI3132: Correct the IoAlign > > EmbeddedPkg/Drivers/SataSiI3132Dxe/SataSiI3132.c | 48 ++- > EmbeddedPkg/Drivers/SataSiI3132Dxe/SataSiI3132.h | 89 ++++- > .../Drivers/SataSiI3132Dxe/SataSiI3132Dxe.inf | 2 + > .../Drivers/SataSiI3132Dxe/SiI3132AtaPassThru.c | 270 ++++++++------ > .../Drivers/SataSiI3132Dxe/SiI3132ScsiPassThru.c | 401 +++++++++++++++++++++ > MdePkg/Include/IndustryStandard/Scsi.h | 2 + > OpenPlatformPkg | 2 +- > 7 files changed, 688 insertions(+), 126 deletions(-) > create mode 100644 EmbeddedPkg/Drivers/SataSiI3132Dxe/SiI3132ScsiPassThru.c > > -- > 2.5.5 > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel