From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) by mx.groups.io with SMTP id smtpd.web10.971.1573717283985030213 for ; Wed, 13 Nov 2019 23:41:24 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=hLoOoLmj; spf=pass (domain: linaro.org, ip: 209.85.128.66, mailfrom: ard.biesheuvel@linaro.org) Received: by mail-wm1-f66.google.com with SMTP id l17so4548902wmh.0 for ; Wed, 13 Nov 2019 23:41:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=buLZQYRj5SMDh9lZbMEMQIBMB28oess/t0K4ELjjMQQ=; b=hLoOoLmjM5o8rT9HUMedHnjKmjrTJnHpb7NBlsFZpFc6LRAkGphhBtX4uzEH9Npgy1 0Nxmotj1uOejmpJzmMnY74elXAKVGiXeQKpMSSTPGIB/jUrE0hSxDYVYLSfOP5q6D0NH 5glYWPJoMb2yD2riUH6ojzioAFufp7jJhqwYw9dsVaCazh4TXh6buAvpi7GwDNlrPxf8 PM9e+RZvOVXj1GU3xxHLsRroYv8l+zEZJskSdUKRmsDd56cUk+AQmKUcg5/RrLRX1W4b XWjnCReZmD+DzcOr2b1sR8lIAER8f4VCW89tjLgu7vmSCl24WDCFGrHGoXLDVcMsu0Ct WZEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=buLZQYRj5SMDh9lZbMEMQIBMB28oess/t0K4ELjjMQQ=; b=NE2R6vZA8OgCWAQpWqIO39U4urhmHjGt+Jx5LYOaRHnuA3VhruFyg5zEFct4WFtYrI tXMPTVC0qsA+tuNxk7mFSMgcRAufnyF6enWjzYCUeduB4J0inWkhbY6VeeZB/+TL9Dgw edoTKqSv/VAW6+gWQtAX4b233DDyyUPGLm3gHc5dOxLvIMFwduzARl/ZeHs16eNyoz0o nRQaZw0GtXkdPlr78U0ZbEW4JCCTKx1UGLEiovBOxbEnhrzZbhs+o319Ofx/XUUuo4tQ NsBMAifktLZJbrMFnXm0mu5cf4uj4tf5XKxZItALTF6TcYjLR/6PVLVyiwRIm0Ru7vfa LSFw== X-Gm-Message-State: APjAAAU8b1tRTnRSs7Lcl10OD1NQ/IdW777IyZ8P1vILL5Lpg0Gtan+4 Fy5HhLy1Evrl1ucnz9WMKQTMIZLEMmjYWQ9tZi5FtgyPcoJUnA== X-Google-Smtp-Source: APXvYqxTGol/0WLtZ1Sp11gPZpz85hq+jTrl5kBxe+1jLBko31QsI5D7g8DossYWfZyju9o0CQ5Y2Ch1/9R21exI1vU= X-Received: by 2002:a7b:c392:: with SMTP id s18mr5832325wmj.61.1573717282054; Wed, 13 Nov 2019 23:41:22 -0800 (PST) MIME-Version: 1.0 References: <20191114021743.3876-1-jian.j.wang@intel.com> <20191114021743.3876-10-jian.j.wang@intel.com> In-Reply-To: <20191114021743.3876-10-jian.j.wang@intel.com> From: "Ard Biesheuvel" Date: Thu, 14 Nov 2019 07:41:13 +0000 Message-ID: Subject: Re: [edk2-devel] [PATCH 09/11] ArmVirtPkg/ArmVirt.dsc.inc: specify RngLib instances in dsc files To: edk2-devel-groups-io , Jian J Wang Cc: Leif Lindholm , Laszlo Ersek Content-Type: text/plain; charset="UTF-8" On Thu, 14 Nov 2019 at 02:18, Wang, Jian J wrote: > > Per BZ1871, OpensslLib will depend on RngLib instead of TimerLib. Update > ArmVirt.dsc.inc file to accommodate the coming changes. It's supposed > that only TlsDxe needs random number. The RngDxeLib is added for it. For > all other drivers, RngLibNull is used by default. > > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1871 > Cc: Leif Lindholm > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Signed-off-by: Jian J Wang Does this mean we lose the ability to do HTTPS boot if we lack an implementation of EFI_RNG_PROTOCOL? > --- > ArmVirtPkg/ArmVirt.dsc.inc | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/ArmVirtPkg/ArmVirt.dsc.inc b/ArmVirtPkg/ArmVirt.dsc.inc > index 10037c938e..10e0890699 100644 > --- a/ArmVirtPkg/ArmVirt.dsc.inc > +++ b/ArmVirtPkg/ArmVirt.dsc.inc > @@ -156,8 +156,10 @@ > IntrinsicLib|CryptoPkg/Library/IntrinsicLib/IntrinsicLib.inf > !if $(NETWORK_TLS_ENABLE) == TRUE > OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLib.inf > + RngLib|SecurityPkg/RandomNumberGenerator/DxeRngLibRngProtocol/DxeRngLibRngProtocol.inf > !else > OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf > + RngLib|MdePkg/Library/BaseRngLibNull/BaseRngLibNull.inf > !endif > BaseCryptLib|CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf > > -- > 2.17.1.windows.2 > > > >