From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::d44; helo=mail-io1-xd44.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-io1-xd44.google.com (mail-io1-xd44.google.com [IPv6:2607:f8b0:4864:20::d44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 43021211C3F4C for ; Fri, 1 Feb 2019 01:33:25 -0800 (PST) Received: by mail-io1-xd44.google.com with SMTP id s8so5092920iob.13 for ; Fri, 01 Feb 2019 01:33:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=0D8ckUqd+8yhVVfoV/q0DsE0xNSNSLvWw68YaH4xqsE=; b=MsIL77rV1xj2/FF0fIws9mLB7Mj2UFdrHy0zzZsiW4nKiLkMRmGD8CrOW4S5aOGugj qNXPfAas9OjpdaZL14WQzCVvw6i234z692dxreiDIFUagpCSy+zyBzptnr6uoPmRKI+I dRL7t4vcL7DJazBmY1oGatZ4HjsTXouLlHtOs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0D8ckUqd+8yhVVfoV/q0DsE0xNSNSLvWw68YaH4xqsE=; b=gizuTJH3kN/6JJ/kBWFbuzL96uhbO359eru41MsSFgbuLlCj5P8MlYTkWbapOgh+/Y P0vdK8/1jvlqxpNI8AuVp5uh7RUy9QTT2hlHG3ZqAZXWJuaEcvM5VTOl7YhT4LEAEhZu d5KvwFXPg7R1DwhEb6GnmemS2PuG/X9m5t0tS5YUHFguD4w3LuVQGeBxUvbV7oiYb8SI DzSZ6TOdgq0thXQM9MOywx1bz88icbZSLouGz+h82i153nJIQIZflnSMZoOJ+TS+BayA vpOXzYxmGyHKnLQTAiowYP9RqLSTNuCvpNhMlarQUjDLWRriR1WWvXz9vNcYHrnm13C9 3wRw== X-Gm-Message-State: AHQUAuacIGx2pW+I38f1F2VzK9Btjw9aGmitjhsq1Shwr3cUToXqCL6d wi3ceIfVE9XD00xsTzBhbA9ypgaZ6i3iEiXThv6BzA== X-Google-Smtp-Source: AHgI3IYxNWJ3aVSPFh6hU37m4mNhdT7pXtY/zQg4gvFnVM2ePNsmnlEDUdhBVqkrAe9/3+koiGX0GRbuIDf5fwXmMAY= X-Received: by 2002:a5d:8410:: with SMTP id i16mr5916958ion.173.1549013604029; Fri, 01 Feb 2019 01:33:24 -0800 (PST) MIME-Version: 1.0 References: <20190130193943.12023-1-ard.biesheuvel@linaro.org> <20190131150553.tte2ed3ik6fiazpd@bivouac.eciton.net> <20190131183503.tjujxj2anjewsyh6@bivouac.eciton.net> In-Reply-To: <20190131183503.tjujxj2anjewsyh6@bivouac.eciton.net> From: Ard Biesheuvel Date: Fri, 1 Feb 2019 10:33:15 +0100 Message-ID: To: Leif Lindholm Cc: "edk2-devel@lists.01.org" , Pete Batard Subject: Re: [PATCH edk2-platforms] Silicon/Bcm2836: add random number generator driver X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Feb 2019 09:33:25 -0000 Content-Type: text/plain; charset="UTF-8" On Thu, 31 Jan 2019 at 19:35, Leif Lindholm wrote: > > On Thu, Jan 31, 2019 at 06:14:45PM +0100, Ard Biesheuvel wrote: > > On Thu, 31 Jan 2019 at 16:05, Leif Lindholm wrote: > > > > > > On Wed, Jan 30, 2019 at 08:39:43PM +0100, Ard Biesheuvel wrote: > > > > Expose the SoC's RNG peripheral via the EFI_RNG_PROTOCOL. > > > > This is used by Linux to seed the KASLR routines. > > > > > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > > > Signed-off-by: Ard Biesheuvel > > > > > > Not tested, but looks fine. Only question: could we add those few > > > #defines to IndustryStandard/Bcm2836.h (should that really be > > > #IndustryStandard, btw?) rather than creating a tiny standalone one? > > > (more below) > > > > > > > Sure. > > > > Re IndustryStandard/, I deliberately chose something idiomatic for > > EDK2, and this is the least inappropriate one. I could live with > > Chipset/ as well, but dumping headers under Include/ directly is not > > the solution IMO. > > I disagree. Dumping the main SoC header under the top-level SoC > directory (and same pattern for platform) is idiomatic. > Dumping all kinds of random files there isn't, I agree (although that > happens too). > > BeagleBoardPkg/Include/BeagleBoard.h > OvmfPkg/Include/OvmfPlatforms.h > Vlv2TbltDevicePkg/Include/Platform.h > > Silicon/Hisilicon/Hi6220/Include/Hi6220.h > > An alternative pattern is an include directory named after the > SoC/Platform. > > Omap35xxPkg/Include/Omap3530/ > > You used > > Silicon/Socionext/SynQuacer/Include/Platform/ > > which I also don't mind. > > If you'd prefer it, I'd be happy with Platform/ and Silicon/. > > But we'd better settle on something before Pete changes too much based > on my feedback. > Yeah. I'll park this until Pete's stuff is merged.