From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ard.biesheuvel@linaro.org>
Received: from mail-it0-x235.google.com (mail-it0-x235.google.com
 [IPv6:2607:f8b0:4001:c0b::235])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by ml01.01.org (Postfix) with ESMTPS id 297271A1EFA
 for <edk2-devel@ml01.01.org>; Thu, 15 Sep 2016 06:40:11 -0700 (PDT)
Received: by mail-it0-x235.google.com with SMTP id r192so95317026ita.0
 for <edk2-devel@ml01.01.org>; Thu, 15 Sep 2016 06:40:11 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;
 h=mime-version:in-reply-to:references:from:date:message-id:subject:to
 :cc; bh=rdDHd8KTAnb90c3mwzIFe0SOy7IPBmy8Q2/D/M3hcsw=;
 b=iQPUfZIilXF4tz8H3hJWuG0EMnwCDrKS536v/qapQA2Kpm5I3yJrwDEqIBvw4klSTX
 R52Ahyj/+of6Hn1FiMYH8rVdjvj1DItkga/X1L1z0AM8AwbtURB5Rsi24LC5ZakrOfCb
 1ePma6795KUGvoPdABuggEIxS9cl9zzqDLyaA=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:mime-version:in-reply-to:references:from:date
 :message-id:subject:to:cc;
 bh=rdDHd8KTAnb90c3mwzIFe0SOy7IPBmy8Q2/D/M3hcsw=;
 b=Yfmo5ESwxw5LoWsIbSfg8Ob+YOnCzlVUWaAKVPbfgFiZbnGzIsSZ6wLhU3aahxKhBp
 izi7bKyfsdqmhBjbsmUUEb8e1FLZ91w/JUmjNE95caFPUkmBDppughmIlFuUGDciN0m0
 pkv2rbXlL4/ULXa6qFXlrEKFOXJdjIb6MVKgaAdqmPe9h9q3KNT/1h/B2D875yYREInF
 m20MKBSs+NoSNwFmnIMhxQqp2/8xfYauupWJkilsX6g41Yuo82Os3+COzVo/eX4O72+M
 uR53n3Lixn75vs+D/xSXTSMcawbKfA14sZyMF0wswkXe9hT5LpPasvia3rOdMfO4Q2/q
 BnfA==
X-Gm-Message-State: AE9vXwOqW1CFyN9FVwDKS6+zwf6LhUpn9QaLc2ZdEUBScNMBmN4NzLloG3vN8snUAV18w9N80QZwH2PEBOMmeFFU
X-Received: by 10.107.16.29 with SMTP id y29mr15487068ioi.143.1473946810413;
 Thu, 15 Sep 2016 06:40:10 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.36.204.195 with HTTP; Thu, 15 Sep 2016 06:40:10 -0700 (PDT)
In-Reply-To: <9b4a70f2-f2a4-1b3b-5239-2133d5a693f4@redhat.com>
References: <1473946233-10547-1-git-send-email-ard.biesheuvel@linaro.org>
 <1473946233-10547-2-git-send-email-ard.biesheuvel@linaro.org>
 <9b4a70f2-f2a4-1b3b-5239-2133d5a693f4@redhat.com>
From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Date: Thu, 15 Sep 2016 14:40:10 +0100
Message-ID: <CAKv+Gu_1Y5eF6UQ3+dOwVRoX5m6FfMA8wAK=oPFJhgs6uw5L8A@mail.gmail.com>
To: Laszlo Ersek <lersek@redhat.com>
Cc: "edk2-devel@lists.01.org" <edk2-devel@ml01.01.org>,
 Shannon Zhao <zhaoshenglong@huawei.com>, Sakar Arora <sakar.arora@nxp.com>
Subject: Re: [PATCH 1/4] ArmVirtPkg/FdtClientDxe: fix check for size of "reg" properties
X-BeenThere: edk2-devel@lists.01.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: EDK II Development  <edk2-devel.lists.01.org>
List-Unsubscribe: <https://lists.01.org/mailman/options/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=unsubscribe>
List-Archive: <http://lists.01.org/pipermail/edk2-devel/>
List-Post: <mailto:edk2-devel@lists.01.org>
List-Help: <mailto:edk2-devel-request@lists.01.org?subject=help>
List-Subscribe: <https://lists.01.org/mailman/listinfo/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=subscribe>
X-List-Received-Date: Thu, 15 Sep 2016 13:40:11 -0000
Content-Type: text/plain; charset=UTF-8

On 15 September 2016 at 14:38, Laszlo Ersek <lersek@redhat.com> wrote:
> On 09/15/16 15:30, Ard Biesheuvel wrote:
>> Currently, the code in FdtClientDxe assumes #address-cells and
>
> s/and/are/?
>

No, amusingly, the second sentence started with #size-cells, and was
dropped completely by git commit due to the leading #. I will try to
remember what I put there, and fix it up when committing.

> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
>

Thanks,
Ard.