From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: Laszlo Ersek <lersek@redhat.com>
Cc: Jim.Dailey@dell.com, "Carsey, Jaben" <jaben.carsey@intel.com>,
Ruiyu Ni <ruiyu.ni@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [PATCH] ShellPkg Shell: Remove redundant functions
Date: Thu, 6 Sep 2018 14:30:41 +0200 [thread overview]
Message-ID: <CAKv+Gu_24Z0qwxVsyiSTkOTKfW__32x_ENSp4xSUP-vg063WwQ@mail.gmail.com> (raw)
In-Reply-To: <17d57db5-c15a-b71b-3d82-39aaad39ece2@redhat.com>
On 6 September 2018 at 14:24, Laszlo Ersek <lersek@redhat.com> wrote:
> On 09/06/18 12:28, Ard Biesheuvel wrote:
>> On 9 August 2018 at 17:41, <Jim.Dailey@dell.com> wrote:
>>> The InvalidChars[] array is only used in function IsValidCommandName().
>>> The array should be deleted also, I think.
>>>
>>
>> Indeed, and for this reason this patch has now broken the build for
>> clang. Please fix.
>
> I agree about InvalidChars being unused, post-22cf747fcf75. I just can't
> reproduce the build error, with CLANG38 (3.8.1). The command
>
> build -a X64 -p ShellPkg/ShellPkg.dsc -b RELEASE -t CLANG38 \
> -m ShellPkg/Application/Shell/Shell.inf
>
> seems to work for me, also with "-b DEBUG".
>
> What differs on your end?
>
Not sure what the exact difference is, but I am using CLANG35 profile:
https://ci.linaro.org/job/leg-virt-tianocore-edk2-upstream/3176/consoleFull
next prev parent reply other threads:[~2018-09-06 12:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-09 5:41 [PATCH] ShellPkg Shell: Remove redundant functions shenglei
2018-08-09 15:34 ` Carsey, Jaben
2018-08-09 15:41 ` Jim.Dailey
2018-08-09 16:17 ` Laszlo Ersek
2018-09-06 10:28 ` Ard Biesheuvel
2018-09-06 12:24 ` Laszlo Ersek
2018-09-06 12:30 ` Ard Biesheuvel [this message]
2018-09-06 15:22 ` Gao, Liming
2018-09-06 16:18 ` Laszlo Ersek
2018-09-07 0:57 ` Gao, Liming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKv+Gu_24Z0qwxVsyiSTkOTKfW__32x_ENSp4xSUP-vg063WwQ@mail.gmail.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox