From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c06::241; helo=mail-io0-x241.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-io0-x241.google.com (mail-io0-x241.google.com [IPv6:2607:f8b0:4001:c06::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 26FA5203369D0 for ; Thu, 6 Sep 2018 05:30:42 -0700 (PDT) Received: by mail-io0-x241.google.com with SMTP id e12-v6so8628595iok.12 for ; Thu, 06 Sep 2018 05:30:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=xDZMBTrmZSGjaqEOoO8JII4keZrDDGPu5MnonIWUNHY=; b=Mb7oZsRbO9d/Rk9UvU6BTqpDCYSFEUWIj1khoyZCyqcXKYP3MM8sFZFiNOHMBg856S paKpXgdrtxE2qEr2mHOnqsSliXuwwOwfGvDZoS5QWEvcA8+YH1R9M3yUB8tTOyrzrWta l0pU0oYf8Dq5jLXxvqHnEoKt3hXcGWPEjM1hg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=xDZMBTrmZSGjaqEOoO8JII4keZrDDGPu5MnonIWUNHY=; b=Wyy4aGB0be1W13kY9UVX/NGgfeVzsets5Nqxx0r47FzA5yExOviUdfQPsM8vMYB/vN 4U6EPdBGHqnkKT3L5Gl8UfiF8wgK5miWYQSbQs0JGSiUgDOsHCwL7EoLaJx088BJWZzy zvLeAM4hA0KRfQH6kJRn5J9O8TAMMYDOzyMVVdfTQmv/ebnZMj4lddyN/2ww4H93lzUR HIRlThKN9MjBR4p2xV6z7m/VD2DvBc9F4tG0ovAnfl5HnXrjiLjf2nZ8qswkJ8+UStXC yUPgcS8z1H2T0VKj52SJcvB5w43BOW0HFjc9BQKfTrjju6ulx0tH/aBjqLcNqyqd0chy 57sg== X-Gm-Message-State: APzg51CbuapYiFTRt203VBBCJmMMVwDZ5UlQmHMPRJh4IxiHSWr6XMyt MIztzjfwb2Sx6NBDadeFFJXgvERxVMFiMyrwEW5WlwvV7N3KtA== X-Google-Smtp-Source: ANB0VdbZC7ZgX+X7+0aRtoOM30OVueYWbLuaC+CqzrHVJvT7rjzeqbk99lQQlJimJC/1dwblk1VnDT9rUeJN1uUJC74= X-Received: by 2002:a6b:4516:: with SMTP id s22-v6mr1719799ioa.60.1536237041570; Thu, 06 Sep 2018 05:30:41 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a6b:1c06:0:0:0:0:0 with HTTP; Thu, 6 Sep 2018 05:30:41 -0700 (PDT) In-Reply-To: <17d57db5-c15a-b71b-3d82-39aaad39ece2@redhat.com> References: <20180809054155.30244-1-shenglei.zhang@intel.com> <809ce67145704edeb41da02b7e5bdce5@ausx13mps335.AMER.DELL.COM> <17d57db5-c15a-b71b-3d82-39aaad39ece2@redhat.com> From: Ard Biesheuvel Date: Thu, 6 Sep 2018 14:30:41 +0200 Message-ID: To: Laszlo Ersek Cc: Jim.Dailey@dell.com, "Carsey, Jaben" , Ruiyu Ni , "edk2-devel@lists.01.org" Subject: Re: [PATCH] ShellPkg Shell: Remove redundant functions X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Sep 2018 12:30:43 -0000 Content-Type: text/plain; charset="UTF-8" On 6 September 2018 at 14:24, Laszlo Ersek wrote: > On 09/06/18 12:28, Ard Biesheuvel wrote: >> On 9 August 2018 at 17:41, wrote: >>> The InvalidChars[] array is only used in function IsValidCommandName(). >>> The array should be deleted also, I think. >>> >> >> Indeed, and for this reason this patch has now broken the build for >> clang. Please fix. > > I agree about InvalidChars being unused, post-22cf747fcf75. I just can't > reproduce the build error, with CLANG38 (3.8.1). The command > > build -a X64 -p ShellPkg/ShellPkg.dsc -b RELEASE -t CLANG38 \ > -m ShellPkg/Application/Shell/Shell.inf > > seems to work for me, also with "-b DEBUG". > > What differs on your end? > Not sure what the exact difference is, but I am using CLANG35 profile: https://ci.linaro.org/job/leg-virt-tianocore-edk2-upstream/3176/consoleFull