From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by mx.groups.io with SMTP id smtpd.web12.2316.1582627796105870861 for ; Tue, 25 Feb 2020 02:49:56 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=C/2plsVL; spf=pass (domain: linaro.org, ip: 209.85.221.65, mailfrom: ard.biesheuvel@linaro.org) Received: by mail-wr1-f65.google.com with SMTP id m16so14101870wrx.11 for ; Tue, 25 Feb 2020 02:49:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=+co7hA42/u+/TOJAz2a/R2Zo06mhh/zhQ4rLD+0+QKc=; b=C/2plsVL9PC6ADoV6DgN9uLRa6aJ9mJddrMCp+qPh5LiiGo2+zz4FZdioiQ/XuzNZd neEPry+FWnREQ8mwborccJoZToRYYs/4NKgMGq0JliJB/o9TQCtUYrQNqgt0PLq9WPpF 5lTy2onsBgsXXWzztcrlZJnLvmuIsLBLjmnXqYLKp9lZor2GmXIPEFDhBodyJej8707X qsAKiBm6d5G/Bkc0ZaMROP/IXv5xaU0oVY5mXLY3PuPwjnATvyUilAgXEuUv444v0ReZ phDTEW3NzL2rXC2cW2mXG/TqZbww1+sPbSRCu4EjNbwaIP82zyiU6yQuFiGx/6taeXrY FGSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+co7hA42/u+/TOJAz2a/R2Zo06mhh/zhQ4rLD+0+QKc=; b=q26I0nxbJuAe08LPw9VV+wS2qroT1ULu0OpBxddwvN5a64NLiwioGtTpjED8i8OSRu 5B6wy1HlW8wQd72TlPXdHv7cJuGiJGe3wIyiHYZlkAB7wZYgPdm7UD8dnS3siROuzfqU iSMPPTZ7zbmEEWr5VAJGFqsTCGNlvfn9Pmo5tfStA59BMaX3LMkX7AGc+cHcVk5aPooJ 7yzq0ZIN5I549gIAnP3Tv5YybA/YCyxPtunXhbJxGJ6DDbNdJpP1pLbMtTa4XkapV/Gi hjxPpzkD/y7OCnsdm8meR0swV1URTnxyiQ2ae6gXgttWwtujDZeh+Iixnl9/e2EYp8R7 5o/g== X-Gm-Message-State: APjAAAVKrwxn9FvZsD7iAtVf9+2P61zOmIfNv1Od7Kvf59rFUzC0zQDj 6EIcK+zXX/3j1Wwopx6CzI2li7bxQ1+RHmb/d7GDecDSED0yug== X-Google-Smtp-Source: APXvYqzlVtodOhiACWHUgN0wiQgcU59+PV7XTnu32esKRGCuQ5edM4cVmekK9rNKAjAa2MiCEr5ui/0pylubxTYCqxM= X-Received: by 2002:adf:f84a:: with SMTP id d10mr2341170wrq.208.1582627794268; Tue, 25 Feb 2020 02:49:54 -0800 (PST) MIME-Version: 1.0 References: <20200225104449.22453-1-ard.biesheuvel@linaro.org> In-Reply-To: <20200225104449.22453-1-ard.biesheuvel@linaro.org> From: "Ard Biesheuvel" Date: Tue, 25 Feb 2020 11:49:43 +0100 Message-ID: Subject: Re: [PATCH v2 0/5] ArmVirtPkg: implement measured boot for ArmVirtQemu To: edk2-devel-groups-io Cc: Laszlo Ersek , Auger Eric , =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= , =?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= , Stefan Berger , Leif Lindholm Content-Type: text/plain; charset="UTF-8" On Tue, 25 Feb 2020 at 11:45, Ard Biesheuvel wrote: > > Wire up the various existing pieces so that we can implement measured > boot on ArmVirtQemu based on the TPM support in QEMU, just like it has > been implemented for x86 in OvmfPkg. > > The main difference is that on ARM, we first need to discover the TPM base > address from the device tree provided by QEMU, as well as the PSCI method > used to perform a cold reset. > > Changes since v1: > - use a separate ResetSystemLib instance based on on-demand parsing of the > DT, and expose it via the ResetSystem PPI to other client PEIMs > - add Laszlo's ack to #1 > - incorporate Laszlo's review feedback across the board > Forgot to include the link to the QEMU work being done by Eric in parallel: https://lists.nongnu.org/archive/html/qemu-devel/2020-02/msg03830.html > Cc: lersek@redhat.com > Cc: eric.auger@redhat.com > Cc: philmd@redhat.com > Cc: marcandre.lureau@redhat.com > Cc: stefanb@linux.ibm.com > Cc: leif@nuviainc.com > > Ard Biesheuvel (5): > OvmfPkg/Tcg2ConfigPei: introduce a signalling PPI to depex on > ArmVirtPkg/PlatformPeiLib: make PcdLib dependency explicit in .INF > ArmVirtPkg/PlatformPeiLib: discover the TPM base address from the DT > ArmVirtPkg: implement ArmVirtPsciResetSystemPeiLib > ArmVirtPkg/ArmVirtQemu: add optional support for TPM2 measured boot > > ArmVirtPkg/ArmVirt.dsc.inc | 6 + > ArmVirtPkg/ArmVirtPkg.dec | 6 + > ArmVirtPkg/ArmVirtQemu.dsc | 75 ++++++ > ArmVirtPkg/ArmVirtQemu.fdf | 6 + > ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc | 10 + > .../ArmVirtPsciResetSystemPeiLib.c | 232 ++++++++++++++++++ > .../ArmVirtPsciResetSystemPeiLib.inf | 39 +++ > .../Library/PlatformPeiLib/PlatformPeiLib.c | 101 +++++++- > .../Library/PlatformPeiLib/PlatformPeiLib.inf | 20 +- > OvmfPkg/OvmfPkg.dec | 5 + > OvmfPkg/Tcg/Tcg2Config/Tcg2ConfigPei.inf | 6 +- > 11 files changed, 491 insertions(+), 15 deletions(-) > create mode 100644 ArmVirtPkg/Library/ArmVirtPsciResetSystemPeiLib/ArmVirtPsciResetSystemPeiLib.c > create mode 100644 ArmVirtPkg/Library/ArmVirtPsciResetSystemPeiLib/ArmVirtPsciResetSystemPeiLib.inf > > -- > 2.17.1 >