From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c0b::244; helo=mail-it0-x244.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it0-x244.google.com (mail-it0-x244.google.com [IPv6:2607:f8b0:4001:c0b::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id EA9E82035B2C5 for ; Sat, 23 Dec 2017 06:05:00 -0800 (PST) Received: by mail-it0-x244.google.com with SMTP id d16so17408321itj.1 for ; Sat, 23 Dec 2017 06:09:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=pe5vlQJnn1ZyAGfKzB1K7SFTj1EcDX1EKUCR0ZlAzqs=; b=OQBIdRs1FH0qJGGardYsXEMR4lhkT/06JP9QjGVR2MV/t4EgTcgzD5T85K2I8n0cBW 7leUoHWYatigsytQ8/D/bOF8dxO87wOWZP9MrSHMNZWHHgQhobQSYVvmAxJuXJM4/3ic c4+shKM8zasj3p0tTubCj2rri7TJWiT2zPaPw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=pe5vlQJnn1ZyAGfKzB1K7SFTj1EcDX1EKUCR0ZlAzqs=; b=gYe2saDA7P0dYuNAFUXXTbSzaYkp9XxFH/B03BtlD+qT3TSzOR4kljdxIrg7SEjhmb fNKa2vTD2Grv8I5QiIFpI3JbLCsBP8WlyA8GnUyb0UBUaVDO62ho1Xecpgj5KAG4Dtpd uia5cTg+Z2xeFBPPDpVZz96OeTO3t3y7KUk2tJt7Dy1R6vpBWuYZFNiy00Y42LPrgwU3 1oTnq1Dv8hM0FgZAXUULNqVhAHHObUD2uIKvahnW/TNKR2996W/o1x0CWuIxoobLtFiv RWadOXOsuPYOS+L5l7bXgCiEgj/g+zYWY+OxIGchJHKndfjWwWljMzRLyyk+eiJHnOuQ DFHw== X-Gm-Message-State: AKGB3mK6VyvYkvq+Y4zrQoHH/ttRdnnRM4YzUHIwLmWVQXoLdRtQbkEG yL/hH5UA1gN8Uh845x3X/msBUIDembESHUse8qfpNA== X-Google-Smtp-Source: ACJfBotqHAZVm8IVNfDFoh0jpU7WppVWNoB8mkOlv7q5p2l8kSg0JwQa1f4LpaDp9FR2ohk52bq6TT6W4+ZAIrZfjuw= X-Received: by 10.36.219.214 with SMTP id c205mr21623391itg.65.1514038191427; Sat, 23 Dec 2017 06:09:51 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.52.14 with HTTP; Sat, 23 Dec 2017 06:09:50 -0800 (PST) In-Reply-To: <20171222190821.12440-6-evan.lloyd@arm.com> References: <20171222190821.12440-1-evan.lloyd@arm.com> <20171222190821.12440-6-evan.lloyd@arm.com> From: Ard Biesheuvel Date: Sat, 23 Dec 2017 14:09:50 +0000 Message-ID: To: Evan Lloyd Cc: "edk2-devel@lists.01.org" , Arvind Chauhan , Daniil Egranov , Thomas Panakamattam Abraham , <"ard.biesheuvel@linaro.org"@arm.com>, <"leif.lindholm@linaro.org"@arm.com>, <"Matteo.Carlini@arm.com"@arm.com>, <"nd@arm.com"@arm.com> Subject: Re: [PATCH edk2-platforms v2 05/18] ARM/VExpressPkg: PL111 and HDLCD: add const qualifier X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Dec 2017 14:05:01 -0000 Content-Type: text/plain; charset="UTF-8" On 22 December 2017 at 19:08, wrote: > From: Girish Pathak > > This change adds some STATIC and CONST qualifiers (mainly to arguments > of functions) in PL111 and HdLcd platform libraries. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Girish Pathak > Signed-off-by: Evan Lloyd Please drop this patch, I don't see the point. > --- > Platform/ARM/VExpressPkg/Library/HdLcdArmVExpressLib/HdLcdArmVExpress.c | 34 ++++++++++---------- > Platform/ARM/VExpressPkg/Library/PL111LcdArmVExpressLib/PL111LcdArmVExpress.c | 32 +++++++++--------- > 2 files changed, 33 insertions(+), 33 deletions(-) > > diff --git a/Platform/ARM/VExpressPkg/Library/HdLcdArmVExpressLib/HdLcdArmVExpress.c b/Platform/ARM/VExpressPkg/Library/HdLcdArmVExpressLib/HdLcdArmVExpress.c > index e4d0a4c8407835df6ab62c02d18531c4d3f08c97..6afd764897f49c64490ce891682f99bb0f5d993b 100644 > --- a/Platform/ARM/VExpressPkg/Library/HdLcdArmVExpressLib/HdLcdArmVExpress.c > +++ b/Platform/ARM/VExpressPkg/Library/HdLcdArmVExpressLib/HdLcdArmVExpress.c > @@ -46,7 +46,7 @@ typedef struct { > > /** The display modes supported by the platform. > **/ > -LCD_RESOLUTION mResolutions[] = { > +STATIC CONST LCD_RESOLUTION mResolutions[] = { > { // Mode 0 : VGA : 640 x 480 x 24 bpp > VGA, VGA_H_RES_PIXELS, VGA_V_RES_PIXELS, LCD_BITS_PER_PIXEL_24, > VGA_OSC_FREQUENCY, > @@ -146,8 +146,8 @@ LcdPlatformInitializeDisplay ( > **/ > EFI_STATUS > LcdPlatformGetVram ( > - OUT EFI_PHYSICAL_ADDRESS* VramBaseAddress, > - OUT UINTN* VramSize > + OUT EFI_PHYSICAL_ADDRESS * CONST VramBaseAddress, > + OUT UINTN * CONST VramSize > ) > { > EFI_STATUS Status; > @@ -215,7 +215,7 @@ LcdPlatformGetMaxMode (VOID) > **/ > EFI_STATUS > LcdPlatformSetMode ( > - IN UINT32 ModeNumber > + IN CONST UINT32 ModeNumber > ) > { > EFI_STATUS Status; > @@ -275,8 +275,8 @@ LcdPlatformSetMode ( > **/ > EFI_STATUS > LcdPlatformQueryMode ( > - IN UINT32 ModeNumber, > - OUT EFI_GRAPHICS_OUTPUT_MODE_INFORMATION *Info > + IN CONST UINT32 ModeNumber, > + OUT EFI_GRAPHICS_OUTPUT_MODE_INFORMATION * CONST Info > ) > { > if (ModeNumber >= LcdPlatformGetMaxMode ()) { > @@ -332,15 +332,15 @@ LcdPlatformQueryMode ( > **/ > EFI_STATUS > LcdPlatformGetTimings ( > - IN UINT32 ModeNumber, > - OUT UINT32* HRes, > - OUT UINT32* HSync, > - OUT UINT32* HBackPorch, > - OUT UINT32* HFrontPorch, > - OUT UINT32* VRes, > - OUT UINT32* VSync, > - OUT UINT32* VBackPorch, > - OUT UINT32* VFrontPorch > + IN CONST UINT32 ModeNumber, > + OUT UINT32 * CONST HRes, > + OUT UINT32 * CONST HSync, > + OUT UINT32 * CONST HBackPorch, > + OUT UINT32 * CONST HFrontPorch, > + OUT UINT32 * CONST VRes, > + OUT UINT32 * CONST VSync, > + OUT UINT32 * CONST VBackPorch, > + OUT UINT32 * CONST VFrontPorch > ) > { > if (ModeNumber >= LcdPlatformGetMaxMode ()) { > @@ -371,8 +371,8 @@ LcdPlatformGetTimings ( > **/ > EFI_STATUS > LcdPlatformGetBpp ( > - IN UINT32 ModeNumber, > - OUT LCD_BPP * Bpp > + IN CONST UINT32 ModeNumber, > + OUT LCD_BPP * CONST Bpp > ) > { > if (ModeNumber >= LcdPlatformGetMaxMode ()) { > diff --git a/Platform/ARM/VExpressPkg/Library/PL111LcdArmVExpressLib/PL111LcdArmVExpress.c b/Platform/ARM/VExpressPkg/Library/PL111LcdArmVExpressLib/PL111LcdArmVExpress.c > index 0bbd40ceeb850209cd4842f34e72a0b635309a15..799fb3fc781ce04bb64cb1fa0b87f262a670ed78 100644 > --- a/Platform/ARM/VExpressPkg/Library/PL111LcdArmVExpressLib/PL111LcdArmVExpress.c > +++ b/Platform/ARM/VExpressPkg/Library/PL111LcdArmVExpressLib/PL111LcdArmVExpress.c > @@ -197,8 +197,8 @@ LcdPlatformInitializeDisplay ( > **/ > EFI_STATUS > LcdPlatformGetVram ( > - OUT EFI_PHYSICAL_ADDRESS* VramBaseAddress, > - OUT UINTN* VramSize > + OUT EFI_PHYSICAL_ADDRESS * CONST VramBaseAddress, > + OUT UINTN * CONST VramSize > ) > { > EFI_STATUS Status; > @@ -284,7 +284,7 @@ LcdPlatformGetMaxMode (VOID) > **/ > EFI_STATUS > LcdPlatformSetMode ( > - IN UINT32 ModeNumber > + IN CONST UINT32 ModeNumber > ) > { > EFI_STATUS Status; > @@ -365,8 +365,8 @@ LcdPlatformSetMode ( > **/ > EFI_STATUS > LcdPlatformQueryMode ( > - IN UINT32 ModeNumber, > - OUT EFI_GRAPHICS_OUTPUT_MODE_INFORMATION *Info > + IN CONST UINT32 ModeNumber, > + OUT EFI_GRAPHICS_OUTPUT_MODE_INFORMATION * CONST Info > ) > { > if (ModeNumber >= LcdPlatformGetMaxMode ()) { > @@ -422,15 +422,15 @@ LcdPlatformQueryMode ( > **/ > EFI_STATUS > LcdPlatformGetTimings ( > - IN UINT32 ModeNumber, > - OUT UINT32* HRes, > - OUT UINT32* HSync, > - OUT UINT32* HBackPorch, > - OUT UINT32* HFrontPorch, > - OUT UINT32* VRes, > - OUT UINT32* VSync, > - OUT UINT32* VBackPorch, > - OUT UINT32* VFrontPorch > + IN CONST UINT32 ModeNumber, > + OUT UINT32 * CONST HRes, > + OUT UINT32 * CONST HSync, > + OUT UINT32 * CONST HBackPorch, > + OUT UINT32 * CONST HFrontPorch, > + OUT UINT32 * CONST VRes, > + OUT UINT32 * CONST VSync, > + OUT UINT32 * CONST VBackPorch, > + OUT UINT32 * CONST VFrontPorch > ) > { > if (ModeNumber >= LcdPlatformGetMaxMode ()) { > @@ -461,8 +461,8 @@ LcdPlatformGetTimings ( > **/ > EFI_STATUS > LcdPlatformGetBpp ( > - IN UINT32 ModeNumber, > - OUT LCD_BPP * Bpp > + IN CONST UINT32 ModeNumber, > + OUT LCD_BPP * CONST Bpp > ) > { > if (ModeNumber >= LcdPlatformGetMaxMode ()) { > -- > Guid("CE165669-3EF3-493F-B85D-6190EE5B9759") >