From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-x22a.google.com (mail-io0-x22a.google.com [IPv6:2607:f8b0:4001:c06::22a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id A35F221A18AAA for ; Tue, 18 Apr 2017 04:11:07 -0700 (PDT) Received: by mail-io0-x22a.google.com with SMTP id a103so186861236ioj.1 for ; Tue, 18 Apr 2017 04:11:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=kikAeIGIsYtKqf15n2dQqbWVc0JvZdKzVa3+ijjwodc=; b=V3tYqiFSSQ0bLTUYhwmxZyC2QrYIMUg0CO/ziRl1yRIYnZsghZ8R7v1yXHoZeONka3 KYkfa6M/63jiatYymhgYh3DHDoK5xD/QD1sWJ8Q3eTAu9AfcReiQ6lxCO3/e0ka8Zqkz 5vP2h7y12CmPGuLmEXb0T8Mr8A5mX+z7L9VLw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=kikAeIGIsYtKqf15n2dQqbWVc0JvZdKzVa3+ijjwodc=; b=RCITeTYbWP0v6z3Au+T6ovknBa+/SbXszFghYvyF0HV3Z1FPpAK6jvsbhfmWT/7Ez9 dxxF3/WD13p4tmYu6kwEpUHIzus3UceamGNaadH0GVoupT93tevSZWr42eBgRPky1mzP pyQMqkWcLv0wXwubDqj3RZhtYY0V/0wET6yWN745aYeNu9tRvs7KzM4JXI6CAlE1vEPf NUDENovn8F2QJm0HnO01NEADQ46lzRXw0w4uhu65MxtPdPpxegtWHlpCWYIKdk6pH7ix Gy+PHlXVoVy4K3m+9vsXmAF14/MX46v3H2aEAI4u4PeIKQ9Ccbp9ApH5CzHcfUBBcYGn o7eA== X-Gm-Message-State: AN3rC/4pxyY0gypxWVhhaUlsXfqeTHd6B3G5q/k06AOY3JxRwQwd+Mjg YCVuem/bzemEr10tVIE9ZAxI9MBmxxm+ X-Received: by 10.36.98.6 with SMTP id d6mr12775795itc.37.1492513866938; Tue, 18 Apr 2017 04:11:06 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.201.76 with HTTP; Tue, 18 Apr 2017 04:11:06 -0700 (PDT) In-Reply-To: References: <20170413163705.26316-1-ard.biesheuvel@linaro.org> From: Ard Biesheuvel Date: Tue, 18 Apr 2017 12:11:06 +0100 Message-ID: To: Alexei Fedorov Cc: "Kinney, Michael D" , "liming.gao@intel.com" , "leif.lindholm@linaro.org" , "edk2-devel@lists.01.org" , Lorenzo Pieralisi , Evan Lloyd , Mitch Ishihara , Sami Mujawar , Girish Pathak Subject: Re: [PATCH] MdePkg/IndustryStandard: add definitions for ACPI 6.0 IORT X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Apr 2017 11:11:07 -0000 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 18 April 2017 at 12:01, Alexei Fedorov wrote: > So, should we follow the Coding Standards Specification or can just ditch= it? > We all know that Tianocore/EDK2 has a steep learning curve, especially when it comes to developers coming from the Linux/open source side. This page https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Specifications lists 11 (!) different specs one must adhere to when contributing code to EDK2. Some of them are mandatory or your code will not build, or will build but will not run. In my opinion, adhering to the specs is already difficult enough without having to follow arbitrary rules which are so blatantly violated in core areas of the tree (MdePkg and MdeModulePkg). So my advice is simply to ignore the coding standard altogether, and in my reviews, I am usually very lax about violations. --=20 Ard. > > -----Original Message----- > From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org] > Sent: 18 April 2017 11:13 > To: Alexei Fedorov ; Kinney, Michael D ; liming.gao@intel.com; leif.lindholm@linaro.org > Cc: edk2-devel@lists.01.org; Lorenzo Pieralisi ; Evan Lloyd > Subject: Re: [edk2] [PATCH] MdePkg/IndustryStandard: add definitions for = ACPI 6.0 IORT > > On 18 April 2017 at 11:07, Alexei Fedorov wrote: >> >> Aren't comments like >> >> // >> // Table header >> // >> >> , >> >> // >> // Definition for ID mapping table shared by all node types // >> >> etc. not allowed according to EDK II C Coding Standards Specification? >> >> 6.2.3 Avoid comments where the opening comment characters are alone on >> a line. >> >> // >> >> // VIOLATION: Horror Vacui >> >> // >> > > You must be joking > > $ git grep -E '/\*\*\s$' MdePkg/ MdeModulePkg/ |wc -l > 16193 > > IOW, there are more than 16000 occurrences of opening comment characters = alone on a line in MdePkg+MdeModulePkg only > IMPORTANT NOTICE: The contents of this email and any attachments are conf= idential and may also be privileged. If you are not the intended recipient,= please notify the sender immediately and do not disclose the contents to a= ny other person, use it for any purpose, or store or copy the information i= n any medium. Thank you.