Re: [PATCH] Silicon/Hisilicon: switch to NonDiscoverable driver for EHCI

[Ard Biesheuvel <ard.biesheuvel@linaro.org>]

On 29 August 2017 at 16:00, Leif Lindholm <leif.lindholm@linaro.org> wrote:
> On Thu, Aug 24, 2017 at 09:21:32PM +0100, Ard Biesheuvel wrote:
>> Replace the open coded PCI 'emulation' with a simple call into
>> the NonDiscoverable device registration library, and fix up all
>> platform .DSCs/FDFs accordingly.
>>
>> Contributed-under: TianoCore Contribution Agreement 1.1
>> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>
> D02 no longer builds after (the fixed version, based on your
> follow-up) is applied:
>
> edk2-platforms/Platform/Hisilicon/D02/Pv660D02.dsc(...): error 4000:
> Instance of library class [UncachedMemoryAllocationLib] is not found in
>         [/work/maint/edk2-platforms/Silicon/Hisilicon/Drivers/SasV1Dxe/SasV1Dxe.inf]
>         [AARCH64]
>         consumed by module [/work/maint/edk2-platforms/Silicon/Hisilicon/Drivers/SasV1Dxe/SasV1Dxe.inf]
>
> That does appear to be a false dependency though, so if you can fold
> in its deletion:
> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>

Ah yes, I already had a separate patch for that, which is why I didn't notice.

Thanks.