From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-x229.google.com (mail-io0-x229.google.com [IPv6:2607:f8b0:4001:c06::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B314F2095B9F5 for ; Tue, 29 Aug 2017 07:59:55 -0700 (PDT) Received: by mail-io0-x229.google.com with SMTP id d81so21031821ioj.4 for ; Tue, 29 Aug 2017 08:02:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=ptX+NS3/nmSiBjnWFVkVpWpfNCiRSQ+CuQZDv7SiK9g=; b=jLKrGh1+ur/j1wNV5abB2Fuat+Rrq8jw3e1xT+tJ+ZNmsmCO44XUVa3HdFaGKnx/3t 4VW9t4jRbfdnbz0cPtmKBlGgydhIfxo9Q2hCURA1ATHIH6BwWgLL/S3+AgctTAfI8Cmf pz/5XgF2oFktKxkAw4cDZfEh+mW7Rl6yH25Wc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=ptX+NS3/nmSiBjnWFVkVpWpfNCiRSQ+CuQZDv7SiK9g=; b=snwksWSc6kGMuCXkYOXIKxuEubso0TrHgE8TFXSiiExbxXdXY31hpEGGTBnl/dcB7Q ieLtpPzTN+KjAjNj86KbjZitVIt3MhfnRivvgpMHOHOKqOrXAik5e4Kui5x1Bc5/84fZ CX7tDYZeozQaXwTjBkuLIsczZX/2O+OFunK4i0x/hZZG3PKaFdJsa9+20MhXWCiZLkbQ m3l+A+4dh82+YqbKzEz35lf/nqme/Qc/KJtl60Awha9M+UoE1Dzd8anlX444ng5BQyJO jIPP8KIzHT7pq3L/XTiqumaIQ+9iO09CfBaprn5vGF8/+d91k2UteolW/dNnUFeG/ezV ahFQ== X-Gm-Message-State: AHYfb5jAdRXjRE0wfeJ0fXEwZkdQhyRJ2bJ4+xoqirj0T4F09Dnb4EVp L10nZUhCS/jTDBtqueyOa+TBgPRn+Q8V X-Received: by 10.36.148.9 with SMTP id j9mr2308003ite.146.1504018951112; Tue, 29 Aug 2017 08:02:31 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.162.1 with HTTP; Tue, 29 Aug 2017 08:02:30 -0700 (PDT) In-Reply-To: <20170829150014.qic7gcivheyc2myw@bivouac.eciton.net> References: <20170824202132.24624-1-ard.biesheuvel@linaro.org> <20170829150014.qic7gcivheyc2myw@bivouac.eciton.net> From: Ard Biesheuvel Date: Tue, 29 Aug 2017 16:02:30 +0100 Message-ID: To: Leif Lindholm Cc: "edk2-devel@lists.01.org" , Chenhui Sun , Graeme Gregory , Heyi Guo Subject: Re: [PATCH] Silicon/Hisilicon: switch to NonDiscoverable driver for EHCI X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Aug 2017 14:59:56 -0000 Content-Type: text/plain; charset="UTF-8" On 29 August 2017 at 16:00, Leif Lindholm wrote: > On Thu, Aug 24, 2017 at 09:21:32PM +0100, Ard Biesheuvel wrote: >> Replace the open coded PCI 'emulation' with a simple call into >> the NonDiscoverable device registration library, and fix up all >> platform .DSCs/FDFs accordingly. >> >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Ard Biesheuvel > > D02 no longer builds after (the fixed version, based on your > follow-up) is applied: > > edk2-platforms/Platform/Hisilicon/D02/Pv660D02.dsc(...): error 4000: > Instance of library class [UncachedMemoryAllocationLib] is not found in > [/work/maint/edk2-platforms/Silicon/Hisilicon/Drivers/SasV1Dxe/SasV1Dxe.inf] > [AARCH64] > consumed by module [/work/maint/edk2-platforms/Silicon/Hisilicon/Drivers/SasV1Dxe/SasV1Dxe.inf] > > That does appear to be a false dependency though, so if you can fold > in its deletion: > Reviewed-by: Leif Lindholm Ah yes, I already had a separate patch for that, which is why I didn't notice. Thanks.