public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: Ruiyu Ni <ruiyu.ni@intel.com>
Cc: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
	Laszlo Ersek <lersek@redhat.com>
Subject: Re: [PATCH] MdeModulePkg/Bds: Remove assertion in BmCharToUint
Date: Tue, 10 Oct 2017 09:45:05 +0100	[thread overview]
Message-ID: <CAKv+Gu_40_+Hs=m4Ud+qH8+HqYnHQBqMj_AnzCRQG6-AZsLsRQ@mail.gmail.com> (raw)
In-Reply-To: <20171010083943.278276-1-ruiyu.ni@intel.com>

On 10 October 2017 at 09:39, Ruiyu Ni <ruiyu.ni@intel.com> wrote:
> BmCharToUint() could be called using external data and it
> already contains logic to return -1 when data is invalid,
> so removing unnecessary assertion to avoid system hang.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Laszlo Ersek <lersek@redhat.com>

Acked-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

> ---
>  MdeModulePkg/Library/UefiBootManagerLib/BmMisc.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/MdeModulePkg/Library/UefiBootManagerLib/BmMisc.c b/MdeModulePkg/Library/UefiBootManagerLib/BmMisc.c
> index 11ab86792a..a3fa254245 100644
> --- a/MdeModulePkg/Library/UefiBootManagerLib/BmMisc.c
> +++ b/MdeModulePkg/Library/UefiBootManagerLib/BmMisc.c
> @@ -420,7 +420,6 @@ BmCharToUint (
>      return (Char - L'A' + 0xA);
>    }
>
> -  ASSERT (FALSE);
>    return (UINTN) -1;
>  }
>
> --
> 2.12.2.windows.2
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel


  reply	other threads:[~2017-10-10  8:41 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-10  8:39 [PATCH] MdeModulePkg/Bds: Remove assertion in BmCharToUint Ruiyu Ni
2017-10-10  8:45 ` Ard Biesheuvel [this message]
2017-10-10 12:38 ` Zeng, Star
2017-10-10 17:05 ` Laszlo Ersek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAKv+Gu_40_+Hs=m4Ud+qH8+HqYnHQBqMj_AnzCRQG6-AZsLsRQ@mail.gmail.com' \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox