From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c06::234; helo=mail-io0-x234.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-io0-x234.google.com (mail-io0-x234.google.com [IPv6:2607:f8b0:4001:c06::234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id A54222095B069 for ; Tue, 10 Oct 2017 01:41:38 -0700 (PDT) Received: by mail-io0-x234.google.com with SMTP id 189so533626iow.10 for ; Tue, 10 Oct 2017 01:45:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=CR9bJnw1aDhnlsv5QzH4uM7BF5h/6X/iuoqCeGX1kkk=; b=DgdCnC2aeRCd8UjMtd6UdRgN+JLqoUleo9X2fhtKxM0Bzt5Hh44HWP8Z8888DCXRH7 ObSUqzdEmqOmg6L6pA513mjsPZul/pbmgpv6B9j3lHASnFb/upeQJQpmSHed/qZqbem6 /X8/3eC/9jnblG6jfzHlGfPUjGILyH6n2NlkU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=CR9bJnw1aDhnlsv5QzH4uM7BF5h/6X/iuoqCeGX1kkk=; b=TLEI/KU4427vqGP552wvghR6bqFSFcf1YkoiXeIEoHidGcIviYcORs+GUp3tqB7GRb O5n59gVbrWeR8qAiGNXpdeS6wxzwQhrjC9Xa+lteMpFnJ2fAnSbL2b0JQ5kumjmhjJ3a TAP4dJVvfowslzzjXcnADVQd49094ZV0CSE2j9Csg0UIuIwOe++HmZ9nxFVI5R3LHdaL /ikwOYevoz8miUsYJ6NusKnWGow4UmwTEL6HyIYnkU+MK37P2OPUfYa8GkmQ8gnSAoC6 y7RxfdpxaDblwVlCPWUuHVUiPZF7atqedBxRZ8OCW0vaKPv+zxRA6dG6bAo+xN/6+xPt VPbg== X-Gm-Message-State: AMCzsaUXvf0zOTQDh6Ab2w1tmAimFnBdIwnVPGa3SRmPE+8rTfrlpq4Q GRBwB2q2je7PDpoyv5PB0PmIvusJvSe79y88vsTavw== X-Google-Smtp-Source: AOwi7QBfsW2I3zwJiDYB9Y2Ysvw2D+taoJqYf23alMU8C6SMzItE/d/eS3G/CUYhVyxTzs/qAXEHpdqDwFc+Nx4tWfg= X-Received: by 10.107.15.170 with SMTP id 42mr15971025iop.141.1507625105658; Tue, 10 Oct 2017 01:45:05 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.131.167 with HTTP; Tue, 10 Oct 2017 01:45:05 -0700 (PDT) In-Reply-To: <20171010083943.278276-1-ruiyu.ni@intel.com> References: <20171010083943.278276-1-ruiyu.ni@intel.com> From: Ard Biesheuvel Date: Tue, 10 Oct 2017 09:45:05 +0100 Message-ID: To: Ruiyu Ni Cc: "edk2-devel@lists.01.org" , Laszlo Ersek Subject: Re: [PATCH] MdeModulePkg/Bds: Remove assertion in BmCharToUint X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Oct 2017 08:41:38 -0000 Content-Type: text/plain; charset="UTF-8" On 10 October 2017 at 09:39, Ruiyu Ni wrote: > BmCharToUint() could be called using external data and it > already contains logic to return -1 when data is invalid, > so removing unnecessary assertion to avoid system hang. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ruiyu Ni > Cc: Ard Biesheuvel > Cc: Laszlo Ersek Acked-by: Ard Biesheuvel > --- > MdeModulePkg/Library/UefiBootManagerLib/BmMisc.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/MdeModulePkg/Library/UefiBootManagerLib/BmMisc.c b/MdeModulePkg/Library/UefiBootManagerLib/BmMisc.c > index 11ab86792a..a3fa254245 100644 > --- a/MdeModulePkg/Library/UefiBootManagerLib/BmMisc.c > +++ b/MdeModulePkg/Library/UefiBootManagerLib/BmMisc.c > @@ -420,7 +420,6 @@ BmCharToUint ( > return (Char - L'A' + 0xA); > } > > - ASSERT (FALSE); > return (UINTN) -1; > } > > -- > 2.12.2.windows.2 > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel