Re: [PATCH 4/5] ArmPlatformPkg: add Null implementation of NorFlashPlatformLib

[Ard Biesheuvel <ard.biesheuvel@linaro.org>]

On 8 December 2017 at 16:07, Leif Lindholm <leif.lindholm@linaro.org> wrote:
> On Tue, Dec 05, 2017 at 10:13:25AM +0000, Ard Biesheuvel wrote:
>> In order to be able to build ArmPlatformPkg components outside of
>> the context of a particular platform, add Null implementation of
>> NorFlashPlatformLib.
>>
>> Contributed-under: TianoCore Contribution Agreement 1.1
>> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>
> Question/comment:
> Not only ARM Ltd. platforms implement this API.
> Would it be worth moving this (as well as
> ArmPlatformPkg/Include/Library/NorFlashPlatformLib.h) into EmbeddedPkg
> and actually documenting the inputs/outputs?
>

I'd rather move away from the monolithical NOR flash drivers derived
from ArmPlatformPkg/Drivers/NorFlashDxe, and move to split SPI host
controller drivers and a generic SPI NOR flash driver based on
NorFlashInfoLib. That's a rather sizable chunk of work, though, and
I'm not sure when this will ever get done or by whom.