From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c0b::229; helo=mail-it0-x229.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it0-x229.google.com (mail-it0-x229.google.com [IPv6:2607:f8b0:4001:c0b::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 2A0F82217CE55 for ; Fri, 8 Dec 2017 08:08:37 -0800 (PST) Received: by mail-it0-x229.google.com with SMTP id d137so5782747itc.2 for ; Fri, 08 Dec 2017 08:13:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=p2umRVfV08Qhk5B/GetRd1zm277yC3j8BDX4cf0oPNQ=; b=HDrlE65Z1HbHioIDceSl6kdjDmKfE+Sfifd2SbHGgzVuMzoKSa1iHj2KJ3NLLl5aTi kUSbXXUlZ/otTUNg9aWQCIJ73EEo7rj8YIC5iXdUt8U8D6c+LrtwnndM8WtdqzZUiJrT s+11cqQXKKeDOMkrK1TxxyHTkbZAchryd4bYg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=p2umRVfV08Qhk5B/GetRd1zm277yC3j8BDX4cf0oPNQ=; b=knHe8wzadqPWiJTbu/3+EMJRD5rCIoO3S8W0A+4w2ze4wsITNPUF1GnAxtmSRb2myZ iTiU7s17ID1qrCDmnkTbCQ2H6pRE1GK11Vg4rg17uL7Q0qcEEGikSeWXRUoYF/NLC+Po 41TQqRAhHW4Oim79jO5f9xg4TWcZhCKvUm7Qntl3wzolQjxgu2KnKbKV9TYWgM/4fbC9 FW9MNSGicj2IACn0t8gRGy+0Fa7KyBypFlg2TtpYe+lpvdX5JYtXIxUHPaHVIvQqkYfT VnrZ47kks17Ta81O/q75uL0PCbSWRz1bQRnyGqwXytA5HU0nnW/qCOXo+5esnumkxCQk es5A== X-Gm-Message-State: AJaThX5K8K02Nemo2ByVM+XooHY4iLcGEYcrCNr1wNLfNdfaRbH3fds8 QogFhIHgr/7KUG7eWzCtio/qv95erjdhLpiMOnHoCw== X-Google-Smtp-Source: AGs4zMZqcUDG7DVX7HlXs1sp5wjbA3GDlFCOc9z2qniQCLEk1tHNkp2aqlXD4mINKhgW+FyuCZX6w2SWgFrtPL5yCPc= X-Received: by 10.107.174.222 with SMTP id n91mr41322326ioo.43.1512749590818; Fri, 08 Dec 2017 08:13:10 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.104.16 with HTTP; Fri, 8 Dec 2017 08:13:10 -0800 (PST) In-Reply-To: <20171208160703.znbgwsk7m22ds53y@bivouac.eciton.net> References: <20171205101326.23732-1-ard.biesheuvel@linaro.org> <20171205101326.23732-5-ard.biesheuvel@linaro.org> <20171208160703.znbgwsk7m22ds53y@bivouac.eciton.net> From: Ard Biesheuvel Date: Fri, 8 Dec 2017 16:13:10 +0000 Message-ID: To: Leif Lindholm Cc: "edk2-devel@lists.01.org" Subject: Re: [PATCH 4/5] ArmPlatformPkg: add Null implementation of NorFlashPlatformLib X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Dec 2017 16:08:37 -0000 Content-Type: text/plain; charset="UTF-8" On 8 December 2017 at 16:07, Leif Lindholm wrote: > On Tue, Dec 05, 2017 at 10:13:25AM +0000, Ard Biesheuvel wrote: >> In order to be able to build ArmPlatformPkg components outside of >> the context of a particular platform, add Null implementation of >> NorFlashPlatformLib. >> >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Ard Biesheuvel > > Question/comment: > Not only ARM Ltd. platforms implement this API. > Would it be worth moving this (as well as > ArmPlatformPkg/Include/Library/NorFlashPlatformLib.h) into EmbeddedPkg > and actually documenting the inputs/outputs? > I'd rather move away from the monolithical NOR flash drivers derived from ArmPlatformPkg/Drivers/NorFlashDxe, and move to split SPI host controller drivers and a generic SPI NOR flash driver based on NorFlashInfoLib. That's a rather sizable chunk of work, though, and I'm not sure when this will ever get done or by whom.