* [PATCH 1/5] ArmPlatformPkg: remove unused ArmPlatformLibNullSec
2017-12-05 10:13 [PATCH 0/5] ArmPlatformPkg: create standalone .dsc file Ard Biesheuvel
@ 2017-12-05 10:13 ` Ard Biesheuvel
2017-12-05 10:13 ` [PATCH 2/5] ArmPlatformPkg/PrePeiCoreMPCore: use a unique GUID Ard Biesheuvel
` (3 subsequent siblings)
4 siblings, 0 replies; 11+ messages in thread
From: Ard Biesheuvel @ 2017-12-05 10:13 UTC (permalink / raw)
To: edk2-devel, leif.lindholm; +Cc: Ard Biesheuvel
ArmPlatformLibNullSec is built from a secondary .inf that omits
ArmPlatformLibNullMem.c from the [Sources] section so the library
can be used in a SEC context. This is slightly dodgy, given that
the resulting library is incomplete. Let's just remove this version,
since it isn't used anywhere anyway.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
ArmPlatformPkg/Library/ArmPlatformLibNull/ArmPlatformLibNullSec.inf | 47 --------------------
1 file changed, 47 deletions(-)
diff --git a/ArmPlatformPkg/Library/ArmPlatformLibNull/ArmPlatformLibNullSec.inf b/ArmPlatformPkg/Library/ArmPlatformLibNull/ArmPlatformLibNullSec.inf
deleted file mode 100644
index 3cd5fd889ea2..000000000000
--- a/ArmPlatformPkg/Library/ArmPlatformLibNull/ArmPlatformLibNullSec.inf
+++ /dev/null
@@ -1,47 +0,0 @@
-#/* @file
-# Copyright (c) 2011-2012, ARM Limited. All rights reserved.
-#
-# This program and the accompanying materials
-# are licensed and made available under the terms and conditions of the BSD License
-# which accompanies this distribution. The full text of the license may be found at
-# http://opensource.org/licenses/bsd-license.php
-#
-# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
-# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
-#
-#*/
-
-[Defines]
- INF_VERSION = 0x00010005
- BASE_NAME = ArmPlatformLibNull
- FILE_GUID = cb494bad-23ff-427e-8608-d7e138d3363b
- MODULE_TYPE = BASE
- VERSION_STRING = 1.0
- LIBRARY_CLASS = ArmPlatformLib
-
-[Packages]
- MdePkg/MdePkg.dec
- MdeModulePkg/MdeModulePkg.dec
- ArmPkg/ArmPkg.dec
- ArmPlatformPkg/ArmPlatformPkg.dec
-
-[LibraryClasses]
- ArmLib
- DebugLib
-
-[Sources.common]
- ArmPlatformLibNull.c
-
-[Sources.Arm]
- Arm/ArmPlatformHelper.S | GCC
- Arm/ArmPlatformHelper.asm | RVCT
-
-[Sources.AArch64]
- AArch64/ArmPlatformHelper.S
-
-[FixedPcd]
- gArmTokenSpaceGuid.PcdSystemMemoryBase
- gArmTokenSpaceGuid.PcdSystemMemorySize
-
- gArmTokenSpaceGuid.PcdArmPrimaryCoreMask
- gArmTokenSpaceGuid.PcdArmPrimaryCore
--
2.11.0
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH 2/5] ArmPlatformPkg/PrePeiCoreMPCore: use a unique GUID
2017-12-05 10:13 [PATCH 0/5] ArmPlatformPkg: create standalone .dsc file Ard Biesheuvel
2017-12-05 10:13 ` [PATCH 1/5] ArmPlatformPkg: remove unused ArmPlatformLibNullSec Ard Biesheuvel
@ 2017-12-05 10:13 ` Ard Biesheuvel
2017-12-05 10:13 ` [PATCH 3/5] ArmPlatformPkg: add Null implementation of LcdPlatformlLib Ard Biesheuvel
` (2 subsequent siblings)
4 siblings, 0 replies; 11+ messages in thread
From: Ard Biesheuvel @ 2017-12-05 10:13 UTC (permalink / raw)
To: edk2-devel, leif.lindholm; +Cc: Ard Biesheuvel
PrePeiCoreMPCore reuses the GUID of its unicore sibling, which is
usually fine, given that platforms never include both. However, it
prevents us from creating a package .DSC that does include both, so
update the GUID to a fresh one.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
ArmPlatformPkg/PrePeiCore/PrePeiCoreMPCore.inf | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ArmPlatformPkg/PrePeiCore/PrePeiCoreMPCore.inf b/ArmPlatformPkg/PrePeiCore/PrePeiCoreMPCore.inf
index 8e0456f8dc2a..e3a31fa7c6f6 100644
--- a/ArmPlatformPkg/PrePeiCore/PrePeiCoreMPCore.inf
+++ b/ArmPlatformPkg/PrePeiCore/PrePeiCoreMPCore.inf
@@ -16,7 +16,7 @@
[Defines]
INF_VERSION = 0x00010005
BASE_NAME = ArmPlatformPrePeiCore
- FILE_GUID = 469fc080-aec1-11df-927c-0002a5d5c51b
+ FILE_GUID = b78d02bb-d0b5-4389-bc7f-b39ee846c784
MODULE_TYPE = SEC
VERSION_STRING = 1.0
--
2.11.0
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH 3/5] ArmPlatformPkg: add Null implementation of LcdPlatformlLib
2017-12-05 10:13 [PATCH 0/5] ArmPlatformPkg: create standalone .dsc file Ard Biesheuvel
2017-12-05 10:13 ` [PATCH 1/5] ArmPlatformPkg: remove unused ArmPlatformLibNullSec Ard Biesheuvel
2017-12-05 10:13 ` [PATCH 2/5] ArmPlatformPkg/PrePeiCoreMPCore: use a unique GUID Ard Biesheuvel
@ 2017-12-05 10:13 ` Ard Biesheuvel
2017-12-05 10:13 ` [PATCH 4/5] ArmPlatformPkg: add Null implementation of NorFlashPlatformLib Ard Biesheuvel
2017-12-05 10:13 ` [PATCH 5/5] ArmPlatformPkg: add package .DSC file Ard Biesheuvel
4 siblings, 0 replies; 11+ messages in thread
From: Ard Biesheuvel @ 2017-12-05 10:13 UTC (permalink / raw)
To: edk2-devel, leif.lindholm; +Cc: Ard Biesheuvel
In order to be able to build ArmPlatformPkg components outside of
the context of a particular platform, add Null implementation of
LcdPlatformlLib.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
ArmPlatformPkg/Library/LcdPlatformNullLib/LcdPlatformNullLib.c | 92 ++++++++++++++++++++
ArmPlatformPkg/Library/LcdPlatformNullLib/LcdPlatformNullLib.inf | 28 ++++++
2 files changed, 120 insertions(+)
diff --git a/ArmPlatformPkg/Library/LcdPlatformNullLib/LcdPlatformNullLib.c b/ArmPlatformPkg/Library/LcdPlatformNullLib/LcdPlatformNullLib.c
new file mode 100644
index 000000000000..071eb5ffd4be
--- /dev/null
+++ b/ArmPlatformPkg/Library/LcdPlatformNullLib/LcdPlatformNullLib.c
@@ -0,0 +1,92 @@
+/** @file
+
+ Copyright (c) 2017, Linaro, Ltd. All rights reserved.
+
+ This program and the accompanying materials
+ are licensed and made available under the terms and conditions of the BSD License
+ which accompanies this distribution. The full text of the license may be found at
+ http://opensource.org/licenses/bsd-license.php
+
+ THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
+ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
+
+**/
+
+#include <Base.h>
+#include <Uefi/UefiBaseType.h>
+#include <Library/DebugLib.h>
+#include <Library/LcdPlatformLib.h>
+
+EFI_STATUS
+LcdPlatformInitializeDisplay (
+ IN EFI_HANDLE Handle
+ )
+{
+ ASSERT (FALSE);
+ return EFI_UNSUPPORTED;
+}
+
+EFI_STATUS
+LcdPlatformGetVram (
+ OUT EFI_PHYSICAL_ADDRESS* VramBaseAddress,
+ OUT UINTN* VramSize
+ )
+{
+ ASSERT (FALSE);
+ return EFI_UNSUPPORTED;
+}
+
+UINT32
+LcdPlatformGetMaxMode (
+ VOID
+ )
+{
+ ASSERT (FALSE);
+ return 0;
+}
+
+EFI_STATUS
+LcdPlatformSetMode (
+ IN UINT32 ModeNumber
+ )
+{
+ ASSERT (FALSE);
+ return EFI_UNSUPPORTED;
+}
+
+EFI_STATUS
+LcdPlatformQueryMode (
+ IN UINT32 ModeNumber,
+ OUT EFI_GRAPHICS_OUTPUT_MODE_INFORMATION *Info
+ )
+{
+ ASSERT (FALSE);
+ return EFI_UNSUPPORTED;
+}
+
+EFI_STATUS
+LcdPlatformGetTimings (
+ IN UINT32 ModeNumber,
+ OUT UINT32* HRes,
+ OUT UINT32* HSync,
+ OUT UINT32* HBackPorch,
+ OUT UINT32* HFrontPorch,
+ OUT UINT32* VRes,
+ OUT UINT32* VSync,
+ OUT UINT32* VBackPorch,
+ OUT UINT32* VFrontPorch
+ )
+{
+ ASSERT (FALSE);
+ return EFI_UNSUPPORTED;
+}
+
+EFI_STATUS
+LcdPlatformGetBpp (
+ IN UINT32 ModeNumber,
+ OUT LCD_BPP* Bpp
+ )
+{
+ ASSERT (FALSE);
+ return EFI_UNSUPPORTED;
+}
diff --git a/ArmPlatformPkg/Library/LcdPlatformNullLib/LcdPlatformNullLib.inf b/ArmPlatformPkg/Library/LcdPlatformNullLib/LcdPlatformNullLib.inf
new file mode 100644
index 000000000000..41c1d9638812
--- /dev/null
+++ b/ArmPlatformPkg/Library/LcdPlatformNullLib/LcdPlatformNullLib.inf
@@ -0,0 +1,28 @@
+#/** @file
+#
+# Copyright (c) 2017, Linaro, Ltd. All rights reserved.
+#
+# This program and the accompanying materials
+# are licensed and made available under the terms and conditions of the BSD License
+# which accompanies this distribution. The full text of the license may be found at
+# http://opensource.org/licenses/bsd-license.php
+#
+# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
+# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
+#
+#**/
+
+[Defines]
+ INF_VERSION = 0x0001001A
+ BASE_NAME = LcdPlatformNullLib
+ FILE_GUID = b78d02bb-d0b5-4389-bc7f-b39ee846c784
+ MODULE_TYPE = BASE
+ VERSION_STRING = 1.0
+ LIBRARY_CLASS = LcdPlatformNullLib
+
+[Sources]
+ LcdPlatformNullLib.c
+
+[Packages]
+ ArmPlatformPkg/ArmPlatformPkg.dec
+ MdePkg/MdePkg.dec
--
2.11.0
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH 4/5] ArmPlatformPkg: add Null implementation of NorFlashPlatformLib
2017-12-05 10:13 [PATCH 0/5] ArmPlatformPkg: create standalone .dsc file Ard Biesheuvel
` (2 preceding siblings ...)
2017-12-05 10:13 ` [PATCH 3/5] ArmPlatformPkg: add Null implementation of LcdPlatformlLib Ard Biesheuvel
@ 2017-12-05 10:13 ` Ard Biesheuvel
2017-12-08 16:07 ` Leif Lindholm
2017-12-05 10:13 ` [PATCH 5/5] ArmPlatformPkg: add package .DSC file Ard Biesheuvel
4 siblings, 1 reply; 11+ messages in thread
From: Ard Biesheuvel @ 2017-12-05 10:13 UTC (permalink / raw)
To: edk2-devel, leif.lindholm; +Cc: Ard Biesheuvel
In order to be able to build ArmPlatformPkg components outside of
the context of a particular platform, add Null implementation of
NorFlashPlatformLib.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
ArmPlatformPkg/Library/NorFlashPlatformNullLib/NorFlashPlatformNullLib.c | 34 ++++++++++++++++++++
ArmPlatformPkg/Library/NorFlashPlatformNullLib/NorFlashPlatformNullLib.inf | 30 +++++++++++++++++
2 files changed, 64 insertions(+)
diff --git a/ArmPlatformPkg/Library/NorFlashPlatformNullLib/NorFlashPlatformNullLib.c b/ArmPlatformPkg/Library/NorFlashPlatformNullLib/NorFlashPlatformNullLib.c
new file mode 100644
index 000000000000..264d18719763
--- /dev/null
+++ b/ArmPlatformPkg/Library/NorFlashPlatformNullLib/NorFlashPlatformNullLib.c
@@ -0,0 +1,34 @@
+/** @file
+
+ Copyright (c) 2014, Linaro Ltd. All rights reserved.<BR>
+
+ This program and the accompanying materials
+ are licensed and made available under the terms and conditions of the BSD License
+ which accompanies this distribution. The full text of the license may be found at
+ http://opensource.org/licenses/bsd-license.php
+
+ THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
+ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
+
+ **/
+
+#include <Library/NorFlashPlatformLib.h>
+
+EFI_STATUS
+NorFlashPlatformInitialization (
+ VOID
+ )
+{
+ return EFI_SUCCESS;
+}
+
+EFI_STATUS
+NorFlashPlatformGetDevices (
+ OUT NOR_FLASH_DESCRIPTION **NorFlashDescriptions,
+ OUT UINT32 *Count
+ )
+{
+ *NorFlashDescriptions = NULL;
+ *Count = 0;
+ return EFI_SUCCESS;
+}
diff --git a/ArmPlatformPkg/Library/NorFlashPlatformNullLib/NorFlashPlatformNullLib.inf b/ArmPlatformPkg/Library/NorFlashPlatformNullLib/NorFlashPlatformNullLib.inf
new file mode 100644
index 000000000000..777a629678e1
--- /dev/null
+++ b/ArmPlatformPkg/Library/NorFlashPlatformNullLib/NorFlashPlatformNullLib.inf
@@ -0,0 +1,30 @@
+#/** @file
+#
+# Component description file for NorFlashPlatformNullLib module
+#
+# Copyright (c) 2017, Linaro Ltd. All rights reserved.<BR>
+#
+# This program and the accompanying materials
+# are licensed and made available under the terms and conditions of the BSD License
+# which accompanies this distribution. The full text of the license may be found at
+# http://opensource.org/licenses/bsd-license.php
+#
+# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
+# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
+#
+#**/
+
+[Defines]
+ INF_VERSION = 0x00010005
+ BASE_NAME = NorFlashPlatformNullLib
+ FILE_GUID = 29b733ad-d066-4df6-8a89-b9df1beb818a
+ MODULE_TYPE = DXE_DRIVER
+ VERSION_STRING = 1.0
+ LIBRARY_CLASS = NorFlashPlatformLib
+
+[Sources.common]
+ NorFlashPlatformNullLib.c
+
+[Packages]
+ MdePkg/MdePkg.dec
+ ArmPlatformPkg/ArmPlatformPkg.dec
--
2.11.0
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [PATCH 4/5] ArmPlatformPkg: add Null implementation of NorFlashPlatformLib
2017-12-05 10:13 ` [PATCH 4/5] ArmPlatformPkg: add Null implementation of NorFlashPlatformLib Ard Biesheuvel
@ 2017-12-08 16:07 ` Leif Lindholm
2017-12-08 16:13 ` Ard Biesheuvel
0 siblings, 1 reply; 11+ messages in thread
From: Leif Lindholm @ 2017-12-08 16:07 UTC (permalink / raw)
To: Ard Biesheuvel; +Cc: edk2-devel
On Tue, Dec 05, 2017 at 10:13:25AM +0000, Ard Biesheuvel wrote:
> In order to be able to build ArmPlatformPkg components outside of
> the context of a particular platform, add Null implementation of
> NorFlashPlatformLib.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Question/comment:
Not only ARM Ltd. platforms implement this API.
Would it be worth moving this (as well as
ArmPlatformPkg/Include/Library/NorFlashPlatformLib.h) into EmbeddedPkg
and actually documenting the inputs/outputs?
/
Leif
> ---
> ArmPlatformPkg/Library/NorFlashPlatformNullLib/NorFlashPlatformNullLib.c | 34 ++++++++++++++++++++
> ArmPlatformPkg/Library/NorFlashPlatformNullLib/NorFlashPlatformNullLib.inf | 30 +++++++++++++++++
> 2 files changed, 64 insertions(+)
>
> diff --git a/ArmPlatformPkg/Library/NorFlashPlatformNullLib/NorFlashPlatformNullLib.c b/ArmPlatformPkg/Library/NorFlashPlatformNullLib/NorFlashPlatformNullLib.c
> new file mode 100644
> index 000000000000..264d18719763
> --- /dev/null
> +++ b/ArmPlatformPkg/Library/NorFlashPlatformNullLib/NorFlashPlatformNullLib.c
> @@ -0,0 +1,34 @@
> +/** @file
> +
> + Copyright (c) 2014, Linaro Ltd. All rights reserved.<BR>
> +
> + This program and the accompanying materials
> + are licensed and made available under the terms and conditions of the BSD License
> + which accompanies this distribution. The full text of the license may be found at
> + http://opensource.org/licenses/bsd-license.php
> +
> + THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
> + WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
> +
> + **/
> +
> +#include <Library/NorFlashPlatformLib.h>
> +
> +EFI_STATUS
> +NorFlashPlatformInitialization (
> + VOID
> + )
> +{
> + return EFI_SUCCESS;
> +}
> +
> +EFI_STATUS
> +NorFlashPlatformGetDevices (
> + OUT NOR_FLASH_DESCRIPTION **NorFlashDescriptions,
> + OUT UINT32 *Count
> + )
> +{
> + *NorFlashDescriptions = NULL;
> + *Count = 0;
> + return EFI_SUCCESS;
> +}
> diff --git a/ArmPlatformPkg/Library/NorFlashPlatformNullLib/NorFlashPlatformNullLib.inf b/ArmPlatformPkg/Library/NorFlashPlatformNullLib/NorFlashPlatformNullLib.inf
> new file mode 100644
> index 000000000000..777a629678e1
> --- /dev/null
> +++ b/ArmPlatformPkg/Library/NorFlashPlatformNullLib/NorFlashPlatformNullLib.inf
> @@ -0,0 +1,30 @@
> +#/** @file
> +#
> +# Component description file for NorFlashPlatformNullLib module
> +#
> +# Copyright (c) 2017, Linaro Ltd. All rights reserved.<BR>
> +#
> +# This program and the accompanying materials
> +# are licensed and made available under the terms and conditions of the BSD License
> +# which accompanies this distribution. The full text of the license may be found at
> +# http://opensource.org/licenses/bsd-license.php
> +#
> +# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
> +# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
> +#
> +#**/
> +
> +[Defines]
> + INF_VERSION = 0x00010005
> + BASE_NAME = NorFlashPlatformNullLib
> + FILE_GUID = 29b733ad-d066-4df6-8a89-b9df1beb818a
> + MODULE_TYPE = DXE_DRIVER
> + VERSION_STRING = 1.0
> + LIBRARY_CLASS = NorFlashPlatformLib
> +
> +[Sources.common]
> + NorFlashPlatformNullLib.c
> +
> +[Packages]
> + MdePkg/MdePkg.dec
> + ArmPlatformPkg/ArmPlatformPkg.dec
> --
> 2.11.0
>
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH 4/5] ArmPlatformPkg: add Null implementation of NorFlashPlatformLib
2017-12-08 16:07 ` Leif Lindholm
@ 2017-12-08 16:13 ` Ard Biesheuvel
2017-12-08 16:17 ` Leif Lindholm
0 siblings, 1 reply; 11+ messages in thread
From: Ard Biesheuvel @ 2017-12-08 16:13 UTC (permalink / raw)
To: Leif Lindholm; +Cc: edk2-devel@lists.01.org
On 8 December 2017 at 16:07, Leif Lindholm <leif.lindholm@linaro.org> wrote:
> On Tue, Dec 05, 2017 at 10:13:25AM +0000, Ard Biesheuvel wrote:
>> In order to be able to build ArmPlatformPkg components outside of
>> the context of a particular platform, add Null implementation of
>> NorFlashPlatformLib.
>>
>> Contributed-under: TianoCore Contribution Agreement 1.1
>> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>
> Question/comment:
> Not only ARM Ltd. platforms implement this API.
> Would it be worth moving this (as well as
> ArmPlatformPkg/Include/Library/NorFlashPlatformLib.h) into EmbeddedPkg
> and actually documenting the inputs/outputs?
>
I'd rather move away from the monolithical NOR flash drivers derived
from ArmPlatformPkg/Drivers/NorFlashDxe, and move to split SPI host
controller drivers and a generic SPI NOR flash driver based on
NorFlashInfoLib. That's a rather sizable chunk of work, though, and
I'm not sure when this will ever get done or by whom.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 4/5] ArmPlatformPkg: add Null implementation of NorFlashPlatformLib
2017-12-08 16:13 ` Ard Biesheuvel
@ 2017-12-08 16:17 ` Leif Lindholm
0 siblings, 0 replies; 11+ messages in thread
From: Leif Lindholm @ 2017-12-08 16:17 UTC (permalink / raw)
To: Ard Biesheuvel; +Cc: edk2-devel@lists.01.org
On Fri, Dec 08, 2017 at 04:13:10PM +0000, Ard Biesheuvel wrote:
> On 8 December 2017 at 16:07, Leif Lindholm <leif.lindholm@linaro.org> wrote:
> > On Tue, Dec 05, 2017 at 10:13:25AM +0000, Ard Biesheuvel wrote:
> >> In order to be able to build ArmPlatformPkg components outside of
> >> the context of a particular platform, add Null implementation of
> >> NorFlashPlatformLib.
> >>
> >> Contributed-under: TianoCore Contribution Agreement 1.1
> >> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> >
> > Question/comment:
> > Not only ARM Ltd. platforms implement this API.
> > Would it be worth moving this (as well as
> > ArmPlatformPkg/Include/Library/NorFlashPlatformLib.h) into EmbeddedPkg
> > and actually documenting the inputs/outputs?
>
> I'd rather move away from the monolithical NOR flash drivers derived
> from ArmPlatformPkg/Drivers/NorFlashDxe, and move to split SPI host
> controller drivers and a generic SPI NOR flash driver based on
> NorFlashInfoLib. That's a rather sizable chunk of work, though, and
> I'm not sure when this will ever get done or by whom.
Sure.
I'd complain if you were trying to move it into
edk2-platforms/Platform/ARM, but leaving this in ArmPlatformPkg seems
ok for a non-specified transitional period.
/
Leif
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH 5/5] ArmPlatformPkg: add package .DSC file
2017-12-05 10:13 [PATCH 0/5] ArmPlatformPkg: create standalone .dsc file Ard Biesheuvel
` (3 preceding siblings ...)
2017-12-05 10:13 ` [PATCH 4/5] ArmPlatformPkg: add Null implementation of NorFlashPlatformLib Ard Biesheuvel
@ 2017-12-05 10:13 ` Ard Biesheuvel
2017-12-08 16:19 ` Leif Lindholm
4 siblings, 1 reply; 11+ messages in thread
From: Ard Biesheuvel @ 2017-12-05 10:13 UTC (permalink / raw)
To: edk2-devel, leif.lindholm; +Cc: Ard Biesheuvel
Now that we have removed all the cruft from ArmPlatformPkg, add a .DSC
file that builds all the remaining components standalone, i.e., outside
of the context of any particular platform. This is primarily intended
for build time testing.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
ArmPlatformPkg/ArmPlatformPkg.dsc | 121 ++++++++++++++++++++
1 file changed, 121 insertions(+)
diff --git a/ArmPlatformPkg/ArmPlatformPkg.dsc b/ArmPlatformPkg/ArmPlatformPkg.dsc
new file mode 100644
index 000000000000..032942e87891
--- /dev/null
+++ b/ArmPlatformPkg/ArmPlatformPkg.dsc
@@ -0,0 +1,121 @@
+#/** @file
+# ARM platform package.
+#
+# Copyright (c) 2009 - 2010, Apple Inc. All rights reserved.<BR>
+# Copyright (c) 2011 - 2015, ARM Ltd. All rights reserved.<BR>
+# Copyright (c) 2016 - 2017, Linaro Ltd. All rights reserved.<BR>
+#
+# This program and the accompanying materials
+# are licensed and made available under the terms and conditions of the BSD License
+# which accompanies this distribution. The full text of the license may be found at
+# http://opensource.org/licenses/bsd-license.php
+#
+# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
+# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
+#
+#**/
+
+################################################################################
+#
+# Defines Section - statements that will be processed to create a Makefile.
+#
+################################################################################
+[Defines]
+ PLATFORM_NAME = ArmPlatformPkg
+ PLATFORM_GUID = 9ce08891-ac9c-476d-ab04-0c04d3a97544
+ PLATFORM_VERSION = 0.1
+ DSC_SPECIFICATION = 0x0001001A
+ OUTPUT_DIRECTORY = Build/ArmPlatform
+ SUPPORTED_ARCHITECTURES = ARM|AARCH64
+ BUILD_TARGETS = DEBUG|RELEASE
+ SKUID_IDENTIFIER = DEFAULT
+
+[BuildOptions]
+ RELEASE_*_*_CC_FLAGS = -DMDEPKG_NDEBUG
+ *_*_*_CC_FLAGS = -DDISABLE_NEW_DEPRECATED_INTERFACES
+
+[PcdsFixedAtBuild]
+ gArmTokenSpaceGuid.PcdFdBaseAddress|0x0
+ gArmTokenSpaceGuid.PcdFdSize|0x1000
+
+[LibraryClasses.common]
+ ArmGicArchLib|ArmPkg/Library/ArmGicArchSecLib/ArmGicArchSecLib.inf
+ ArmGicLib|ArmPkg/Drivers/ArmGic/ArmGicLib.inf
+ ArmLib|ArmPkg/Library/ArmLib/ArmBaseLib.inf
+ ArmPlatformLib|ArmPlatformPkg/Library/ArmPlatformLibNull/ArmPlatformLibNull.inf
+ ArmPlatformStackLib|ArmPlatformPkg/Library/ArmPlatformStackLib/ArmPlatformStackLib.inf
+ ArmMmuLib|ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf
+ BaseLib|MdePkg/Library/BaseLib/BaseLib.inf
+ BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf
+ CacheMaintenanceLib|ArmPkg/Library/ArmCacheMaintenanceLib/ArmCacheMaintenanceLib.inf
+ DebugAgentLib|MdeModulePkg/Library/DebugAgentLibNull/DebugAgentLibNull.inf
+ DebugLib|MdePkg/Library/BaseDebugLibNull/BaseDebugLibNull.inf
+ DxeServicesTableLib|MdePkg/Library/DxeServicesTableLib/DxeServicesTableLib.inf
+ HobLib|MdePkg/Library/DxeHobLib/DxeHobLib.inf
+ IoLib|MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsic.inf
+ LcdPlatformLib|ArmPlatformPkg/Library/LcdPlatformNullLib/LcdPlatformNullLib.inf
+ LzmaDecompressLib|MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
+ MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf
+ MemoryInitPeiLib|ArmPlatformPkg/MemoryInitPei/MemoryInitPeiLib.inf
+ NorFlashPlatformLib|ArmPlatformPkg/Library/NorFlashPlatformNullLib/NorFlashPlatformNullLib.inf
+ PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf
+ PeCoffExtraActionLib|MdePkg/Library/BasePeCoffExtraActionLibNull/BasePeCoffExtraActionLibNull.inf
+ PeCoffLib|MdePkg/Library/BasePeCoffLib/BasePeCoffLib.inf
+ PerformanceLib|MdePkg/Library/BasePerformanceLibNull/BasePerformanceLibNull.inf
+ PlatformPeiLib|ArmPlatformPkg/PlatformPei/PlatformPeiLib.inf
+ PrePiLib|EmbeddedPkg/Library/PrePiLib/PrePiLib.inf
+ PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf
+ SerialPortLib|MdePkg/Library/BaseSerialPortLibNull/BaseSerialPortLibNull.inf
+ TimerLib|MdePkg/Library/BaseTimerLibNullTemplate/BaseTimerLibNullTemplate.inf
+ UefiBootServicesTableLib|MdePkg/Library/UefiBootServicesTableLib/UefiBootServicesTableLib.inf
+ UefiDecompressLib|MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecompressLib.inf
+ UefiDriverEntryPoint|MdePkg/Library/UefiDriverEntryPoint/UefiDriverEntryPoint.inf
+ UefiLib|MdePkg/Library/UefiLib/UefiLib.inf
+ UefiRuntimeLib|MdePkg/Library/UefiRuntimeLib/UefiRuntimeLib.inf
+ DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
+ UefiRuntimeServicesTableLib|MdePkg/Library/UefiRuntimeServicesTableLib/UefiRuntimeServicesTableLib.inf
+
+ NULL|ArmPkg/Library/CompilerIntrinsicsLib/CompilerIntrinsicsLib.inf
+ NULL|MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf
+
+[LibraryClasses.common.PEIM]
+ HobLib|MdePkg/Library/PeiHobLib/PeiHobLib.inf
+ MemoryAllocationLib|MdePkg/Library/PeiMemoryAllocationLib/PeiMemoryAllocationLib.inf
+ PeimEntryPoint|MdePkg/Library/PeimEntryPoint/PeimEntryPoint.inf
+ PeiServicesLib|MdePkg/Library/PeiServicesLib/PeiServicesLib.inf
+ PeiServicesTablePointerLib|MdePkg/Library/PeiServicesTablePointerLib/PeiServicesTablePointerLib.inf
+
+[LibraryClasses.common.SEC]
+ ExtractGuidedSectionLib|EmbeddedPkg/Library/PrePiExtractGuidedSectionLib/PrePiExtractGuidedSectionLib.inf
+ HobLib|EmbeddedPkg/Library/PrePiHobLib/PrePiHobLib.inf
+ MemoryAllocationLib|EmbeddedPkg/Library/PrePiMemoryAllocationLib/PrePiMemoryAllocationLib.inf
+ PrePiHobListPointerLib|ArmPlatformPkg/Library/PrePiHobListPointerLib/PrePiHobListPointerLib.inf
+
+[Components.common]
+ ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/HdLcdGraphicsOutputDxe.inf
+ ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/PL111LcdGraphicsOutputDxe.inf
+ ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashDxe.inf
+ ArmPlatformPkg/Drivers/PL061GpioDxe/PL061GpioDxe.inf
+ ArmPlatformPkg/Drivers/PL180MciDxe/PL180MciDxe.inf
+ ArmPlatformPkg/Drivers/SP805WatchdogDxe/SP805WatchdogDxe.inf
+
+ ArmPlatformPkg/Library/ArmPlatformLibNull/ArmPlatformLibNull.inf
+ ArmPlatformPkg/Library/ArmPlatformStackLib/ArmPlatformStackLib.inf
+ ArmPlatformPkg/Library/LcdPlatformNullLib/LcdPlatformNullLib.inf
+ ArmPlatformPkg/Library/NorFlashPlatformNullLib/NorFlashPlatformNullLib.inf
+ ArmPlatformPkg/Library/PL011SerialPortLib/PL011SerialPortLib.inf
+ ArmPlatformPkg/Library/PL011UartLib/PL011UartLib.inf
+ ArmPlatformPkg/Library/PL031RealTimeClockLib/PL031RealTimeClockLib.inf
+ ArmPlatformPkg/Library/PrePiHobListPointerLib/PrePiHobListPointerLib.inf
+
+ ArmPlatformPkg/MemoryInitPei/MemoryInitPeiLib.inf
+ ArmPlatformPkg/MemoryInitPei/MemoryInitPeim.inf
+
+ ArmPlatformPkg/PlatformPei/PlatformPeim.inf
+ ArmPlatformPkg/PlatformPei/PlatformPeiLib.inf
+
+ ArmPlatformPkg/PrePeiCore/PrePeiCoreMPCore.inf
+ ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf
+
+ ArmPlatformPkg/PrePi/PeiMPCore.inf
+ ArmPlatformPkg/PrePi/PeiUniCore.inf
--
2.11.0
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [PATCH 5/5] ArmPlatformPkg: add package .DSC file
2017-12-05 10:13 ` [PATCH 5/5] ArmPlatformPkg: add package .DSC file Ard Biesheuvel
@ 2017-12-08 16:19 ` Leif Lindholm
2017-12-08 16:35 ` Ard Biesheuvel
0 siblings, 1 reply; 11+ messages in thread
From: Leif Lindholm @ 2017-12-08 16:19 UTC (permalink / raw)
To: Ard Biesheuvel; +Cc: edk2-devel
On Tue, Dec 05, 2017 at 10:13:26AM +0000, Ard Biesheuvel wrote:
> Now that we have removed all the cruft from ArmPlatformPkg, add a .DSC
> file that builds all the remaining components standalone, i.e., outside
> of the context of any particular platform. This is primarily intended
> for build time testing.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
> ArmPlatformPkg/ArmPlatformPkg.dsc | 121 ++++++++++++++++++++
> 1 file changed, 121 insertions(+)
>
> diff --git a/ArmPlatformPkg/ArmPlatformPkg.dsc b/ArmPlatformPkg/ArmPlatformPkg.dsc
> new file mode 100644
> index 000000000000..032942e87891
> --- /dev/null
> +++ b/ArmPlatformPkg/ArmPlatformPkg.dsc
> @@ -0,0 +1,121 @@
> +#/** @file
> +# ARM platform package.
> +#
> +# Copyright (c) 2009 - 2010, Apple Inc. All rights reserved.<BR>
> +# Copyright (c) 2011 - 2015, ARM Ltd. All rights reserved.<BR>
> +# Copyright (c) 2016 - 2017, Linaro Ltd. All rights reserved.<BR>
> +#
> +# This program and the accompanying materials
> +# are licensed and made available under the terms and conditions of the BSD License
> +# which accompanies this distribution. The full text of the license may be found at
> +# http://opensource.org/licenses/bsd-license.php
> +#
> +# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
> +# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
> +#
> +#**/
> +
> +################################################################################
> +#
> +# Defines Section - statements that will be processed to create a Makefile.
> +#
> +################################################################################
> +[Defines]
> + PLATFORM_NAME = ArmPlatformPkg
> + PLATFORM_GUID = 9ce08891-ac9c-476d-ab04-0c04d3a97544
> + PLATFORM_VERSION = 0.1
> + DSC_SPECIFICATION = 0x0001001A
> + OUTPUT_DIRECTORY = Build/ArmPlatform
> + SUPPORTED_ARCHITECTURES = ARM|AARCH64
> + BUILD_TARGETS = DEBUG|RELEASE
DEBUG|NOOPT|RELEASE ?
Tested with clang/gcc ARM/AARCH64.
Feel free to fold that in, or not.
For the series:
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
> + SKUID_IDENTIFIER = DEFAULT
> +
> +[BuildOptions]
> + RELEASE_*_*_CC_FLAGS = -DMDEPKG_NDEBUG
> + *_*_*_CC_FLAGS = -DDISABLE_NEW_DEPRECATED_INTERFACES
> +
> +[PcdsFixedAtBuild]
> + gArmTokenSpaceGuid.PcdFdBaseAddress|0x0
> + gArmTokenSpaceGuid.PcdFdSize|0x1000
> +
> +[LibraryClasses.common]
> + ArmGicArchLib|ArmPkg/Library/ArmGicArchSecLib/ArmGicArchSecLib.inf
> + ArmGicLib|ArmPkg/Drivers/ArmGic/ArmGicLib.inf
> + ArmLib|ArmPkg/Library/ArmLib/ArmBaseLib.inf
> + ArmPlatformLib|ArmPlatformPkg/Library/ArmPlatformLibNull/ArmPlatformLibNull.inf
> + ArmPlatformStackLib|ArmPlatformPkg/Library/ArmPlatformStackLib/ArmPlatformStackLib.inf
> + ArmMmuLib|ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf
> + BaseLib|MdePkg/Library/BaseLib/BaseLib.inf
> + BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf
> + CacheMaintenanceLib|ArmPkg/Library/ArmCacheMaintenanceLib/ArmCacheMaintenanceLib.inf
> + DebugAgentLib|MdeModulePkg/Library/DebugAgentLibNull/DebugAgentLibNull.inf
> + DebugLib|MdePkg/Library/BaseDebugLibNull/BaseDebugLibNull.inf
> + DxeServicesTableLib|MdePkg/Library/DxeServicesTableLib/DxeServicesTableLib.inf
> + HobLib|MdePkg/Library/DxeHobLib/DxeHobLib.inf
> + IoLib|MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsic.inf
> + LcdPlatformLib|ArmPlatformPkg/Library/LcdPlatformNullLib/LcdPlatformNullLib.inf
> + LzmaDecompressLib|MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
> + MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf
> + MemoryInitPeiLib|ArmPlatformPkg/MemoryInitPei/MemoryInitPeiLib.inf
> + NorFlashPlatformLib|ArmPlatformPkg/Library/NorFlashPlatformNullLib/NorFlashPlatformNullLib.inf
> + PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf
> + PeCoffExtraActionLib|MdePkg/Library/BasePeCoffExtraActionLibNull/BasePeCoffExtraActionLibNull.inf
> + PeCoffLib|MdePkg/Library/BasePeCoffLib/BasePeCoffLib.inf
> + PerformanceLib|MdePkg/Library/BasePerformanceLibNull/BasePerformanceLibNull.inf
> + PlatformPeiLib|ArmPlatformPkg/PlatformPei/PlatformPeiLib.inf
> + PrePiLib|EmbeddedPkg/Library/PrePiLib/PrePiLib.inf
> + PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf
> + SerialPortLib|MdePkg/Library/BaseSerialPortLibNull/BaseSerialPortLibNull.inf
> + TimerLib|MdePkg/Library/BaseTimerLibNullTemplate/BaseTimerLibNullTemplate.inf
> + UefiBootServicesTableLib|MdePkg/Library/UefiBootServicesTableLib/UefiBootServicesTableLib.inf
> + UefiDecompressLib|MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecompressLib.inf
> + UefiDriverEntryPoint|MdePkg/Library/UefiDriverEntryPoint/UefiDriverEntryPoint.inf
> + UefiLib|MdePkg/Library/UefiLib/UefiLib.inf
> + UefiRuntimeLib|MdePkg/Library/UefiRuntimeLib/UefiRuntimeLib.inf
> + DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
> + UefiRuntimeServicesTableLib|MdePkg/Library/UefiRuntimeServicesTableLib/UefiRuntimeServicesTableLib.inf
> +
> + NULL|ArmPkg/Library/CompilerIntrinsicsLib/CompilerIntrinsicsLib.inf
> + NULL|MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf
> +
> +[LibraryClasses.common.PEIM]
> + HobLib|MdePkg/Library/PeiHobLib/PeiHobLib.inf
> + MemoryAllocationLib|MdePkg/Library/PeiMemoryAllocationLib/PeiMemoryAllocationLib.inf
> + PeimEntryPoint|MdePkg/Library/PeimEntryPoint/PeimEntryPoint.inf
> + PeiServicesLib|MdePkg/Library/PeiServicesLib/PeiServicesLib.inf
> + PeiServicesTablePointerLib|MdePkg/Library/PeiServicesTablePointerLib/PeiServicesTablePointerLib.inf
> +
> +[LibraryClasses.common.SEC]
> + ExtractGuidedSectionLib|EmbeddedPkg/Library/PrePiExtractGuidedSectionLib/PrePiExtractGuidedSectionLib.inf
> + HobLib|EmbeddedPkg/Library/PrePiHobLib/PrePiHobLib.inf
> + MemoryAllocationLib|EmbeddedPkg/Library/PrePiMemoryAllocationLib/PrePiMemoryAllocationLib.inf
> + PrePiHobListPointerLib|ArmPlatformPkg/Library/PrePiHobListPointerLib/PrePiHobListPointerLib.inf
> +
> +[Components.common]
> + ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/HdLcdGraphicsOutputDxe.inf
> + ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/PL111LcdGraphicsOutputDxe.inf
> + ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashDxe.inf
> + ArmPlatformPkg/Drivers/PL061GpioDxe/PL061GpioDxe.inf
> + ArmPlatformPkg/Drivers/PL180MciDxe/PL180MciDxe.inf
> + ArmPlatformPkg/Drivers/SP805WatchdogDxe/SP805WatchdogDxe.inf
> +
> + ArmPlatformPkg/Library/ArmPlatformLibNull/ArmPlatformLibNull.inf
> + ArmPlatformPkg/Library/ArmPlatformStackLib/ArmPlatformStackLib.inf
> + ArmPlatformPkg/Library/LcdPlatformNullLib/LcdPlatformNullLib.inf
> + ArmPlatformPkg/Library/NorFlashPlatformNullLib/NorFlashPlatformNullLib.inf
> + ArmPlatformPkg/Library/PL011SerialPortLib/PL011SerialPortLib.inf
> + ArmPlatformPkg/Library/PL011UartLib/PL011UartLib.inf
> + ArmPlatformPkg/Library/PL031RealTimeClockLib/PL031RealTimeClockLib.inf
> + ArmPlatformPkg/Library/PrePiHobListPointerLib/PrePiHobListPointerLib.inf
> +
> + ArmPlatformPkg/MemoryInitPei/MemoryInitPeiLib.inf
> + ArmPlatformPkg/MemoryInitPei/MemoryInitPeim.inf
> +
> + ArmPlatformPkg/PlatformPei/PlatformPeim.inf
> + ArmPlatformPkg/PlatformPei/PlatformPeiLib.inf
> +
> + ArmPlatformPkg/PrePeiCore/PrePeiCoreMPCore.inf
> + ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf
> +
> + ArmPlatformPkg/PrePi/PeiMPCore.inf
> + ArmPlatformPkg/PrePi/PeiUniCore.inf
> --
> 2.11.0
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 5/5] ArmPlatformPkg: add package .DSC file
2017-12-08 16:19 ` Leif Lindholm
@ 2017-12-08 16:35 ` Ard Biesheuvel
0 siblings, 0 replies; 11+ messages in thread
From: Ard Biesheuvel @ 2017-12-08 16:35 UTC (permalink / raw)
To: Leif Lindholm; +Cc: edk2-devel@lists.01.org
On 8 December 2017 at 16:19, Leif Lindholm <leif.lindholm@linaro.org> wrote:
> On Tue, Dec 05, 2017 at 10:13:26AM +0000, Ard Biesheuvel wrote:
>> Now that we have removed all the cruft from ArmPlatformPkg, add a .DSC
>> file that builds all the remaining components standalone, i.e., outside
>> of the context of any particular platform. This is primarily intended
>> for build time testing.
>>
>> Contributed-under: TianoCore Contribution Agreement 1.1
>> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>> ---
>> ArmPlatformPkg/ArmPlatformPkg.dsc | 121 ++++++++++++++++++++
>> 1 file changed, 121 insertions(+)
>>
>> diff --git a/ArmPlatformPkg/ArmPlatformPkg.dsc b/ArmPlatformPkg/ArmPlatformPkg.dsc
>> new file mode 100644
>> index 000000000000..032942e87891
>> --- /dev/null
>> +++ b/ArmPlatformPkg/ArmPlatformPkg.dsc
>> @@ -0,0 +1,121 @@
>> +#/** @file
>> +# ARM platform package.
>> +#
>> +# Copyright (c) 2009 - 2010, Apple Inc. All rights reserved.<BR>
>> +# Copyright (c) 2011 - 2015, ARM Ltd. All rights reserved.<BR>
>> +# Copyright (c) 2016 - 2017, Linaro Ltd. All rights reserved.<BR>
>> +#
>> +# This program and the accompanying materials
>> +# are licensed and made available under the terms and conditions of the BSD License
>> +# which accompanies this distribution. The full text of the license may be found at
>> +# http://opensource.org/licenses/bsd-license.php
>> +#
>> +# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
>> +# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
>> +#
>> +#**/
>> +
>> +################################################################################
>> +#
>> +# Defines Section - statements that will be processed to create a Makefile.
>> +#
>> +################################################################################
>> +[Defines]
>> + PLATFORM_NAME = ArmPlatformPkg
>> + PLATFORM_GUID = 9ce08891-ac9c-476d-ab04-0c04d3a97544
>> + PLATFORM_VERSION = 0.1
>> + DSC_SPECIFICATION = 0x0001001A
>> + OUTPUT_DIRECTORY = Build/ArmPlatform
>> + SUPPORTED_ARCHITECTURES = ARM|AARCH64
>> + BUILD_TARGETS = DEBUG|RELEASE
>
> DEBUG|NOOPT|RELEASE ?
> Tested with clang/gcc ARM/AARCH64.
> Feel free to fold that in, or not.
>
Yeah good point.
> For the series:
> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
>
Thanks! Pushed as a8406340bdf2..2b129e87c0f4 (with NOOPT added)
^ permalink raw reply [flat|nested] 11+ messages in thread