From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::d41; helo=mail-io1-xd41.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-io1-xd41.google.com (mail-io1-xd41.google.com [IPv6:2607:f8b0:4864:20::d41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 14EE5211ADA28 for ; Thu, 3 Jan 2019 01:34:23 -0800 (PST) Received: by mail-io1-xd41.google.com with SMTP id m19so26586951ioh.3 for ; Thu, 03 Jan 2019 01:34:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=71pOUZq9opl75RlNkJPDvzofjaha7KOXPC8e0eEthOA=; b=Zb8R3n0V2Yjvq8v5YAJ4RxoIssNgE89PgA+M81t9saUre1PcBCXfhqNu/2B+j2EfFO uPHvF+IrMRlv9BoTdLk4Xylx3+JCWAw7qAOQ4xP4KCbVfmkwYrVJ2oF+L/jBJOOLHPI9 uFbn9QIzHKWGHPRkOqRU9OKkxOTT5IZCUmEnY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=71pOUZq9opl75RlNkJPDvzofjaha7KOXPC8e0eEthOA=; b=F9eCRKG1mGFsuovxoNWl3LnF33Cqh/Z+8AigG4Oenr5PXaN/Jo5NhM90mFlwHUmF32 eypBnUjF+nFPPDiqcaBxxneqDP/zvJdpcuevXec5hD8b2mCHkT3ZuQBwfq8QE3ICUYGO sgddr93OcJqv9IxmYQNPWn2BA642+/YXsNuDmLMERZQ6ojIqoJ45yxUnN1GxCPSXOsPC GkZPMaqLsKVKkEaUqvi3pZx1H44zLp1JY+nIJDxNP4eQ3yWMasFm27PyDdgCQ3faji4f /DcG33YyCRaQZrk4qMFK+eT2Not2xcSVEKIGQ3Er9/FGU2TpHxhY0F7ttGSV9BGT2oIw KsJA== X-Gm-Message-State: AJcUukfiRSHcT6ywxD/8sbXJxMYQ9CgCYYiVoDxoiJuPixdQDM1OPqRo 5S3icaI/O2q4ca4j4mA0k4UMOTlV5EMlFHruoa/FrQ== X-Google-Smtp-Source: ALg8bN41F6qq47SNRN8UixZTiGTAYZIvJ1Av9Y+4E0aL7NJwbpOE0dXJxN6AI05ZhnY9x+RaCki1QDgMKfmgnmuYW4s= X-Received: by 2002:a5e:c206:: with SMTP id v6mr16368775iop.60.1546508062300; Thu, 03 Jan 2019 01:34:22 -0800 (PST) MIME-Version: 1.0 References: <20190103024816.9236-1-lersek@redhat.com> <20190103024816.9236-27-lersek@redhat.com> In-Reply-To: <20190103024816.9236-27-lersek@redhat.com> From: Ard Biesheuvel Date: Thu, 3 Jan 2019 10:34:11 +0100 Message-ID: To: Laszlo Ersek Cc: edk2-devel-01 , Liming Gao , Marvin Haeuser , Michael D Kinney Subject: Re: [PATCH 26/26] Revert "MdePkg: avoid __builtin_unreachable() on GCC v4.4" X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Jan 2019 09:34:23 -0000 Content-Type: text/plain; charset="UTF-8" On Thu, 3 Jan 2019 at 03:49, Laszlo Ersek wrote: > > This reverts commit 357cec385d4f ("MdePkg: avoid __builtin_unreachable() > on GCC v4.4", 2016-07-21). > > We've removed BaseTools support for GCC44..GCC47, therefore we need not > catch the GCC44 corner case for __builtin_unreachable(). > > No GCC44..GCC47 references remain under MdePkg after this patch. > > Cc: Ard Biesheuvel > Cc: Liming Gao > Cc: Marvin Haeuser > Cc: Michael D Kinney > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1377 > Signed-off-by: Laszlo Ersek Reviewed-by: Ard Biesheuvel > --- > > Notes: > I build-tested this change by building ArmVirtQemu with the GCC5 > toolchain (gcc-6.1.1), and OVMF with the GCC48 toolchain (gcc-4.8.5). > > Namely, the PeiCore() function [MdeModulePkg/Core/Pei/PeiMain/PeiMain.c] > and the DxeMain() function [MdeModulePkg/Core/Dxe/DxeMain/DxeMain.c] > use UNREACHABLE(). > > MdePkg/Include/Base.h | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/MdePkg/Include/Base.h b/MdePkg/Include/Base.h > index bc877d8125a5..d6b04baeaf8b 100644 > --- a/MdePkg/Include/Base.h > +++ b/MdePkg/Include/Base.h > @@ -112,11 +112,10 @@ VERIFY_SIZE_OF (__VERIFY_UINT32_ENUM_SIZE, 4); > // warnings. > // > #ifndef UNREACHABLE > - #if __GNUC__ > 4 || (__GNUC__ == 4 && __GNUC_MINOR__ > 4) > + #ifdef __GNUC__ > /// > /// Signal compilers and analyzers that this call is not reachable. It is > /// up to the compiler to remove any code past that point. > - /// Not implemented by GCC 4.4 or earlier. > /// > #define UNREACHABLE() __builtin_unreachable () > #elif defined (__has_feature) > -- > 2.19.1.3.g30247aa5d201 >