From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::143; helo=mail-it1-x143.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it1-x143.google.com (mail-it1-x143.google.com [IPv6:2607:f8b0:4864:20::143]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id C26A22117D26C for ; Tue, 6 Nov 2018 08:39:03 -0800 (PST) Received: by mail-it1-x143.google.com with SMTP id t189-v6so10843870itf.1 for ; Tue, 06 Nov 2018 08:39:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=RgLWonRlRLNJ4U8wQDDYX4t7R2kYxf4lOIJDQ4fBYYg=; b=UacRJS+lfAWMyqzqHp2VGAb8CB0SCGKl+ztx0TFO2MzJ527iY3RT5yGHc/xzJ7cb+J I3CCY2fR0X//6sbcczj0C6W6K/MHdMBCHA7oXU6J5dnVTqDpDRnT7pBTCFLnDK7o9i5B r1MnOJU5RX6HfHgc8NMLXG+Ph4RyQACfYGejA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=RgLWonRlRLNJ4U8wQDDYX4t7R2kYxf4lOIJDQ4fBYYg=; b=DBmHXT28eae52040Duw+OL7awbYd05n2HVgdj3rvkOxTnDT9K4kLUYhieu24o+Ox1Q jIHpJgf5MRw71ERRy09u95toplNgviBM+CBfnXAAbfhoCAArOHAzdqpPbVGXYgF8ypHw EJzJUteMdE/FVZ0SgjX7nvQhdp+i1wucNkLduh7AyD8U46BopVJghvIZlrKPMvyDDdWB 2r1DmulFgLcS6kgFax53SygPNDgF2OyAnquAMTjqwSwtBWnMnR/MTIAlcCfaAS49etHw WYNP+ok7z+ek4ACe8VWKGrN/tirxz78FBN0VblnQiuLfbJ762e7v8GfCMK272FAkb1FQ ZIZA== X-Gm-Message-State: AGRZ1gKstEZl2/Kjw5SbXVGb7JrG+FDpxxEHAuQryNTVav9Yh2J4Fvub Q2imlGrJffJStbLezAxixRoS/JVQOUB+rpPRzJD3uV7F X-Google-Smtp-Source: AJdET5cRvmAW7V3dHYknM8lhY271RDoSJGk3vnD1S5ZmQ6f5CQMon+zcL4AsTuOEQGl5tV/9M0Q43NFfwwfuHSJeT0Q= X-Received: by 2002:a24:2190:: with SMTP id e138-v6mr745282ita.71.1541522342797; Tue, 06 Nov 2018 08:39:02 -0800 (PST) MIME-Version: 1.0 Received: by 2002:a6b:4f16:0:0:0:0:0 with HTTP; Tue, 6 Nov 2018 08:39:02 -0800 (PST) In-Reply-To: <7ab7d41e-ec48-3fb2-28a7-83c7471d7d0e@redhat.com> References: <20181106012403.84760-1-siyuan.fu@intel.com> <20181106012403.84760-2-siyuan.fu@intel.com> <7ab7d41e-ec48-3fb2-28a7-83c7471d7d0e@redhat.com> From: Ard Biesheuvel Date: Tue, 6 Nov 2018 17:39:02 +0100 Message-ID: To: Laszlo Ersek Cc: Fu Siyuan , "edk2-devel@lists.01.org" , Julien Grall Subject: Re: [PATCH v3 1/1] ArmVirtPkg: Replace obsoleted network drivers from platform DSC/FDF. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Nov 2018 16:39:04 -0000 Content-Type: text/plain; charset="UTF-8" On 6 November 2018 at 16:24, Laszlo Ersek wrote: > On 11/06/18 13:32, Ard Biesheuvel wrote: >> On 6 November 2018 at 02:24, Fu Siyuan wrote: >>> V3: >>> Remove duplicate library added in v2 patch, since ArmVirtPkg.dsc.inc >>> already have them. Just remove the if...end there is enough. >>> >>> V2: >>> Add missing library instance for NetworkPkg iSCSI driver. >>> >> >> Please don't put the patch revision history in the commit log. Put it >> below the --- >> >>> This patch replaces the MdeModulePkg TCP, PXE and iSCSI driver with those >>> ones in NetworkPkg. These 3 drivers in MdeModulePkg are not being actively >>> maintained and will be removed from edk2 master soon. >>> >>> Cc: Laszlo Ersek >>> Cc: Ard Biesheuvel >>> Cc: Julien Grall >>> Contributed-under: TianoCore Contribution Agreement 1.1 >>> Signed-off-by: Fu Siyuan >>> --- >> >> ... here ... >> >> The patch looks fine to me >> >> Reviewed-by: Ard Biesheuvel >> >> but please don't merge it until after the next stable tag has been created > > This is not a bad idea (see also your discussion with Leif); however it > does create a bit of inconsistency with how the other platform DSC/FDF > files have been handled. (The changes have been pushed for those.) > > Again, I don't disagree, and I don't mind if ArmVirt is handled > differently. It's just that we should have handled this more uniformly, > I believe. > Yes - as I replied to Leif, I am not going to obsess about this. But the point of stable tags is not to rush things in at the last minute. > > In retrospect, I would have also appreciated if the patches had > referenced , even > though they only implement "prep" work for now, on the platform DSC/FDF > level, and not the actual driver removal. > > For example, the important explanation about MdeModulePkg's iSCSI driver > implementing its own MD5 algo cannot be connected to the OVMF commit now > (d2f1f6423bd1). I have copied the most relevant passage from the cover > letter of this series into TianoCore BZ#1278, but the commit in question > doesn't reference any BZ, so the link cannot be established. > > Thanks > Laszlo