public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: Leif Lindholm <leif.lindholm@linaro.org>
Cc: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [PATCH 2/2] Embedded/EmbeddedPkg.dsc: enable NOOPT build target
Date: Mon, 18 Jun 2018 19:36:15 +0200	[thread overview]
Message-ID: <CAKv+Gu_5fhCSQq35CkKBC-ZT4UE5wYOXL_wEU8J+mP0+iH7sHw@mail.gmail.com> (raw)
In-Reply-To: <20180618173339.k4mh3hcb4lmsofoa@bivouac.eciton.net>

On 18 June 2018 at 19:33, Leif Lindholm <leif.lindholm@linaro.org> wrote:
> On Mon, Jun 18, 2018 at 06:51:44PM +0200, Ard Biesheuvel wrote:
>> Enable to NOOPT build target so we can build this package with
>> optimizations disabled.
>>
>> Contributed-under: TianoCore Contribution Agreement 1.1
>> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>
> For series:
> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
>

Thanks

Pushed as 11d0cd23dd1b..a50aa9dd8881

>
>> ---
>>  EmbeddedPkg/EmbeddedPkg.dsc | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/EmbeddedPkg/EmbeddedPkg.dsc b/EmbeddedPkg/EmbeddedPkg.dsc
>> index e6fad5e58b2d..3914eb7cfa5a 100644
>> --- a/EmbeddedPkg/EmbeddedPkg.dsc
>> +++ b/EmbeddedPkg/EmbeddedPkg.dsc
>> @@ -28,7 +28,7 @@ [Defines]
>>    DSC_SPECIFICATION              = 0x00010005
>>    OUTPUT_DIRECTORY               = Build/Embedded
>>    SUPPORTED_ARCHITECTURES        = IA32|X64|IPF|ARM|AARCH64
>> -  BUILD_TARGETS                  = DEBUG|RELEASE
>> +  BUILD_TARGETS                  = DEBUG|RELEASE|NOOPT
>>    SKUID_IDENTIFIER               = DEFAULT
>>
>>
>> --
>> 2.17.1
>>


      reply	other threads:[~2018-06-18 17:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-18 16:51 [PATCH 1/2] ArmPkg/ArmPkg.dsc: enable NOOPT build target Ard Biesheuvel
2018-06-18 16:51 ` [PATCH 2/2] Embedded/EmbeddedPkg.dsc: " Ard Biesheuvel
2018-06-18 17:33   ` Leif Lindholm
2018-06-18 17:36     ` Ard Biesheuvel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAKv+Gu_5fhCSQq35CkKBC-ZT4UE5wYOXL_wEU8J+mP0+iH7sHw@mail.gmail.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox