From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c0b::235; helo=mail-it0-x235.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it0-x235.google.com (mail-it0-x235.google.com [IPv6:2607:f8b0:4001:c0b::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 8E0472274F3C4 for ; Fri, 13 Apr 2018 00:19:54 -0700 (PDT) Received: by mail-it0-x235.google.com with SMTP id b5-v6so2069875itj.1 for ; Fri, 13 Apr 2018 00:19:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=aCBPbgd2UUrIAZ5MZUl0babdsiR7aYonpKJh9DYfQJ8=; b=YeQpB8FyQLgGh3Q/mZYXbe6E9/ZaRgidnIFyDMVM++Cd8RyHNQnolULsOkEpgVLehb USZUo5L2nRcD3P41prXWChyW8f54OfxBvAdJmwU63jnhzeghSoK9UOJSJestEeULhuLF kgqaqoMg8fRDGT1tD8wq8VCma5seIeqCMbml0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=aCBPbgd2UUrIAZ5MZUl0babdsiR7aYonpKJh9DYfQJ8=; b=qVn38TQvTLIC8jTEqDNC620ltapIgV/NkEJSqV1vFf6dzG4iFKBz3b+8AS0OCF6lnA SMwsnBc8EIqGistybMdGRuJNG6fESWiK8Ulr4QHlKROZvfl11Fml7rbmCqYA/57ZJPVZ G8vmIxLZsyNtpguNJw+GnbYjCqR6qGlL0bPeOmjcyXIHi143Ij56c7nexv/+rNou4ZoP L2Xd5mE9zJks8aqS8fx+EuIRvh2P31cGfasnGiIeKXl7an6VCCm9nb1jNTFm9pErG67w gK+1L3zREty0aX5BJ9tLh0c0Cn6NqDVOokrVghiVztvaTnwbIAYnWrPLKhVcVbKMuhRT 9xsA== X-Gm-Message-State: ALQs6tCKeGeDxUqO7yZJrJvTwlC9mgWfZn3YxMvNGgsbctecq4CXPI+S 5FYfetpEGM4KrQAD3iwQR3TI+Meq9qhuxukzRkMkwQ== X-Google-Smtp-Source: AIpwx48/u+Bu1sSloKAfz2Z9P0FOAyWQmNKgWL5QJExcd2jVwh66frn42G8H5JZudbn5nhAOL4UOWva8R1+EOLZv0Q8= X-Received: by 2002:a24:30c:: with SMTP id e12-v6mr4124539ite.50.1523603993527; Fri, 13 Apr 2018 00:19:53 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.187.67 with HTTP; Fri, 13 Apr 2018 00:19:53 -0700 (PDT) In-Reply-To: <20180413020553.GB119834@SZX1000114654> References: <1521594198-52523-1-git-send-email-heyi.guo@linaro.org> <20180328010531.GA69547@SZX1000114654> <20180329002050.GB97590@SZX1000114654> <20180331013747.GA106704@SZX1000114654> <20180413020553.GB119834@SZX1000114654> From: Ard Biesheuvel Date: Fri, 13 Apr 2018 09:19:53 +0200 Message-ID: To: Guo Heyi Cc: Leif Lindholm , "edk2-devel@lists.01.org" , Michael D Kinney , Haojian Zhuang Subject: Re: [PATCH edk2-platforms 00/12] Hisilicon/D0x: Switch to generic PciHostBridge X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Apr 2018 07:19:54 -0000 Content-Type: text/plain; charset="UTF-8" On 13 April 2018 at 04:05, Guo Heyi wrote: > Hi Ard, > > Any comments? > Apologies for the delay. I have been travelling and am behind on email. > Anyway we can modify the code if you insist on using an intermediate CPU IO > address space. > I have not made up my mind yet, to be honest. I agree there is a certain elegance to merging both translations, but I am concerned that existing EDK2 code may deal poorly with I/O addresses that require more than 32 bits to express. Did you try the mm command in the shell for instance? As you know, I recently removed an artificial address range limit there, but I wonder if it uses 64-bit variables for I/O ports.