* [[edk2-platform][PATCH 1/1] Platform/RaspberryPi/RPi4: Enable HTTP Boot
@ 2020-03-24 21:53 Samer El-Haj-Mahmoud
2020-03-24 21:55 ` Ard Biesheuvel
0 siblings, 1 reply; 5+ messages in thread
From: Samer El-Haj-Mahmoud @ 2020-03-24 21:53 UTC (permalink / raw)
To: devel; +Cc: Leif Lindholm, Ard Biesheuvel
Enable HTTP Boot (with and without TLS) on RPi4
Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Signed-off-by: Samer El-Haj-Mahmoud <samer@elhajmahmoud.com>
---
Platform/RaspberryPi/RPi4/RPi4.dsc | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/Platform/RaspberryPi/RPi4/RPi4.dsc b/Platform/RaspberryPi/RPi4/RPi4.dsc
index 2e98c3e16b91..f6b627af279c 100644
--- a/Platform/RaspberryPi/RPi4/RPi4.dsc
+++ b/Platform/RaspberryPi/RPi4/RPi4.dsc
@@ -25,12 +25,6 @@ [Defines]
SKUID_IDENTIFIER = DEFAULT
FLASH_DEFINITION = Platform/RaspberryPi/$(PLATFORM_NAME)/$(PLATFORM_NAME).fdf
- #
- # Network definition
- #
- DEFINE NETWORK_TLS_ENABLE = FALSE
- DEFINE NETWORK_HTTP_BOOT_ENABLE = FALSE
-
#
# Defines for default states. These can be changed on the command line.
# -D FLAG=VALUE
@@ -139,6 +133,7 @@ [LibraryClasses.common]
IntrinsicLib|CryptoPkg/Library/IntrinsicLib/IntrinsicLib.inf
BaseCryptLib|CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf
OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLib.inf
+ TlsLib|CryptoPkg/Library/TlsLib/TlsLib.inf
#
# Uncomment (and comment out the next line) For RealView Debugger. The Standard IO window
@@ -358,6 +353,8 @@ [PcdsFixedAtBuild.common]
gEfiSecurityPkgTokenSpaceGuid.PcdRemovableMediaImageVerificationPolicy|0x04
!endif
+ gEfiNetworkPkgTokenSpaceGuid.PcdAllowHttpConnections|TRUE
+
[LibraryClasses.common]
ArmLib|ArmPkg/Library/ArmLib/ArmBaseLib.inf
ArmMmuLib|ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [[edk2-platform][PATCH 1/1] Platform/RaspberryPi/RPi4: Enable HTTP Boot
2020-03-24 21:53 [[edk2-platform][PATCH 1/1] Platform/RaspberryPi/RPi4: Enable HTTP Boot Samer El-Haj-Mahmoud
@ 2020-03-24 21:55 ` Ard Biesheuvel
2020-03-24 22:02 ` [edk2-devel] " Samer El-Haj-Mahmoud
0 siblings, 1 reply; 5+ messages in thread
From: Ard Biesheuvel @ 2020-03-24 21:55 UTC (permalink / raw)
To: Samer El-Haj-Mahmoud; +Cc: edk2-devel-groups-io, Leif Lindholm
On Tue, 24 Mar 2020 at 22:53, Samer El-Haj-Mahmoud
<samer@elhajmahmoud.com> wrote:
>
> Enable HTTP Boot (with and without TLS) on RPi4
>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>
> Signed-off-by: Samer El-Haj-Mahmoud <samer@elhajmahmoud.com>
Which NIC are you HTTP booting from?
> ---
> Platform/RaspberryPi/RPi4/RPi4.dsc | 9 +++------
> 1 file changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/Platform/RaspberryPi/RPi4/RPi4.dsc b/Platform/RaspberryPi/RPi4/RPi4.dsc
> index 2e98c3e16b91..f6b627af279c 100644
> --- a/Platform/RaspberryPi/RPi4/RPi4.dsc
> +++ b/Platform/RaspberryPi/RPi4/RPi4.dsc
> @@ -25,12 +25,6 @@ [Defines]
> SKUID_IDENTIFIER = DEFAULT
> FLASH_DEFINITION = Platform/RaspberryPi/$(PLATFORM_NAME)/$(PLATFORM_NAME).fdf
>
> - #
> - # Network definition
> - #
> - DEFINE NETWORK_TLS_ENABLE = FALSE
> - DEFINE NETWORK_HTTP_BOOT_ENABLE = FALSE
> -
> #
> # Defines for default states. These can be changed on the command line.
> # -D FLAG=VALUE
> @@ -139,6 +133,7 @@ [LibraryClasses.common]
> IntrinsicLib|CryptoPkg/Library/IntrinsicLib/IntrinsicLib.inf
> BaseCryptLib|CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf
> OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLib.inf
> + TlsLib|CryptoPkg/Library/TlsLib/TlsLib.inf
>
> #
> # Uncomment (and comment out the next line) For RealView Debugger. The Standard IO window
> @@ -358,6 +353,8 @@ [PcdsFixedAtBuild.common]
> gEfiSecurityPkgTokenSpaceGuid.PcdRemovableMediaImageVerificationPolicy|0x04
> !endif
>
> + gEfiNetworkPkgTokenSpaceGuid.PcdAllowHttpConnections|TRUE
> +
> [LibraryClasses.common]
> ArmLib|ArmPkg/Library/ArmLib/ArmBaseLib.inf
> ArmMmuLib|ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [edk2-devel] [[edk2-platform][PATCH 1/1] Platform/RaspberryPi/RPi4: Enable HTTP Boot
2020-03-24 21:55 ` Ard Biesheuvel
@ 2020-03-24 22:02 ` Samer El-Haj-Mahmoud
2020-03-25 9:20 ` Ard Biesheuvel
0 siblings, 1 reply; 5+ messages in thread
From: Samer El-Haj-Mahmoud @ 2020-03-24 22:02 UTC (permalink / raw)
To: devel@edk2.groups.io, ard.biesheuvel@linaro.org,
Samer El-Haj-Mahmoud
Cc: Leif Lindholm
Tested with USB NICs (both ASIX AX88772C and Realtek gigabit ethernet). Both work pretty well (tested IPv4 and IPv6).
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Ard Biesheuvel via Groups.Io
Sent: Tuesday, March 24, 2020 5:55 PM
To: Samer El-Haj-Mahmoud <samer@elhajmahmoud.com>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>; Leif Lindholm <leif@nuviainc.com>
Subject: Re: [edk2-devel] [[edk2-platform][PATCH 1/1] Platform/RaspberryPi/RPi4: Enable HTTP Boot
On Tue, 24 Mar 2020 at 22:53, Samer El-Haj-Mahmoud <samer@elhajmahmoud.com> wrote:
>
> Enable HTTP Boot (with and without TLS) on RPi4
>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>
> Signed-off-by: Samer El-Haj-Mahmoud <samer@elhajmahmoud.com>
Which NIC are you HTTP booting from?
> ---
> Platform/RaspberryPi/RPi4/RPi4.dsc | 9 +++------
> 1 file changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/Platform/RaspberryPi/RPi4/RPi4.dsc
> b/Platform/RaspberryPi/RPi4/RPi4.dsc
> index 2e98c3e16b91..f6b627af279c 100644
> --- a/Platform/RaspberryPi/RPi4/RPi4.dsc
> +++ b/Platform/RaspberryPi/RPi4/RPi4.dsc
> @@ -25,12 +25,6 @@ [Defines]
> SKUID_IDENTIFIER = DEFAULT
> FLASH_DEFINITION = Platform/RaspberryPi/$(PLATFORM_NAME)/$(PLATFORM_NAME).fdf
>
> - #
> - # Network definition
> - #
> - DEFINE NETWORK_TLS_ENABLE = FALSE
> - DEFINE NETWORK_HTTP_BOOT_ENABLE = FALSE
> -
> #
> # Defines for default states. These can be changed on the command line.
> # -D FLAG=VALUE
> @@ -139,6 +133,7 @@ [LibraryClasses.common]
> IntrinsicLib|CryptoPkg/Library/IntrinsicLib/IntrinsicLib.inf
> BaseCryptLib|CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf
> OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLib.inf
> + TlsLib|CryptoPkg/Library/TlsLib/TlsLib.inf
>
> #
> # Uncomment (and comment out the next line) For RealView Debugger.
> The Standard IO window @@ -358,6 +353,8 @@ [PcdsFixedAtBuild.common]
>
> gEfiSecurityPkgTokenSpaceGuid.PcdRemovableMediaImageVerificationPolicy
> |0x04
> !endif
>
> + gEfiNetworkPkgTokenSpaceGuid.PcdAllowHttpConnections|TRUE
> +
> [LibraryClasses.common]
> ArmLib|ArmPkg/Library/ArmLib/ArmBaseLib.inf
> ArmMmuLib|ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf
> --
> 2.17.1
>
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [edk2-devel] [[edk2-platform][PATCH 1/1] Platform/RaspberryPi/RPi4: Enable HTTP Boot
2020-03-24 22:02 ` [edk2-devel] " Samer El-Haj-Mahmoud
@ 2020-03-25 9:20 ` Ard Biesheuvel
2020-03-25 12:48 ` Samer El-Haj-Mahmoud
0 siblings, 1 reply; 5+ messages in thread
From: Ard Biesheuvel @ 2020-03-25 9:20 UTC (permalink / raw)
To: Samer El-Haj-Mahmoud
Cc: devel@edk2.groups.io, Samer El-Haj-Mahmoud, Leif Lindholm
(+ Pete)
Could you please keep Pete on cc for RPi patches?
On Tue, 24 Mar 2020 at 23:02, Samer El-Haj-Mahmoud
<Samer.El-Haj-Mahmoud@arm.com> wrote:
>
> Tested with USB NICs (both ASIX AX88772C and Realtek gigabit ethernet). Both work pretty well (tested IPv4 and IPv6).
>
Excellent, thanks.
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Pushed as 8b38aefc07bc..3daa70143953
Should we do the same for RPi3?
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Ard Biesheuvel via Groups.Io
> Sent: Tuesday, March 24, 2020 5:55 PM
> To: Samer El-Haj-Mahmoud <samer@elhajmahmoud.com>
> Cc: edk2-devel-groups-io <devel@edk2.groups.io>; Leif Lindholm <leif@nuviainc.com>
> Subject: Re: [edk2-devel] [[edk2-platform][PATCH 1/1] Platform/RaspberryPi/RPi4: Enable HTTP Boot
>
> On Tue, 24 Mar 2020 at 22:53, Samer El-Haj-Mahmoud <samer@elhajmahmoud.com> wrote:
> >
> > Enable HTTP Boot (with and without TLS) on RPi4
> >
> > Cc: Leif Lindholm <leif@nuviainc.com>
> > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> >
> > Signed-off-by: Samer El-Haj-Mahmoud <samer@elhajmahmoud.com>
>
> Which NIC are you HTTP booting from?
>
> > ---
> > Platform/RaspberryPi/RPi4/RPi4.dsc | 9 +++------
> > 1 file changed, 3 insertions(+), 6 deletions(-)
> >
> > diff --git a/Platform/RaspberryPi/RPi4/RPi4.dsc
> > b/Platform/RaspberryPi/RPi4/RPi4.dsc
> > index 2e98c3e16b91..f6b627af279c 100644
> > --- a/Platform/RaspberryPi/RPi4/RPi4.dsc
> > +++ b/Platform/RaspberryPi/RPi4/RPi4.dsc
> > @@ -25,12 +25,6 @@ [Defines]
> > SKUID_IDENTIFIER = DEFAULT
> > FLASH_DEFINITION = Platform/RaspberryPi/$(PLATFORM_NAME)/$(PLATFORM_NAME).fdf
> >
> > - #
> > - # Network definition
> > - #
> > - DEFINE NETWORK_TLS_ENABLE = FALSE
> > - DEFINE NETWORK_HTTP_BOOT_ENABLE = FALSE
> > -
> > #
> > # Defines for default states. These can be changed on the command line.
> > # -D FLAG=VALUE
> > @@ -139,6 +133,7 @@ [LibraryClasses.common]
> > IntrinsicLib|CryptoPkg/Library/IntrinsicLib/IntrinsicLib.inf
> > BaseCryptLib|CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf
> > OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLib.inf
> > + TlsLib|CryptoPkg/Library/TlsLib/TlsLib.inf
> >
> > #
> > # Uncomment (and comment out the next line) For RealView Debugger.
> > The Standard IO window @@ -358,6 +353,8 @@ [PcdsFixedAtBuild.common]
> >
> > gEfiSecurityPkgTokenSpaceGuid.PcdRemovableMediaImageVerificationPolicy
> > |0x04
> > !endif
> >
> > + gEfiNetworkPkgTokenSpaceGuid.PcdAllowHttpConnections|TRUE
> > +
> > [LibraryClasses.common]
> > ArmLib|ArmPkg/Library/ArmLib/ArmBaseLib.inf
> > ArmMmuLib|ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf
> > --
> > 2.17.1
> >
>
>
>
> IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [edk2-devel] [[edk2-platform][PATCH 1/1] Platform/RaspberryPi/RPi4: Enable HTTP Boot
2020-03-25 9:20 ` Ard Biesheuvel
@ 2020-03-25 12:48 ` Samer El-Haj-Mahmoud
0 siblings, 0 replies; 5+ messages in thread
From: Samer El-Haj-Mahmoud @ 2020-03-25 12:48 UTC (permalink / raw)
To: Ard Biesheuvel; +Cc: devel@edk2.groups.io, Samer El-Haj-Mahmoud, Leif Lindholm
> -----Original Message-----
> From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Sent: Wednesday, March 25, 2020 5:20 AM
> To: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>
> Cc: devel@edk2.groups.io; Samer El-Haj-Mahmoud
> <samer@elhajmahmoud.com>; Leif Lindholm <leif@nuviainc.com>
> Subject: Re: [edk2-devel] [[edk2-platform][PATCH 1/1]
> Platform/RaspberryPi/RPi4: Enable HTTP Boot
>
> (+ Pete)
>
> Could you please keep Pete on cc for RPi patches?
>
Yes will do
>
> On Tue, 24 Mar 2020 at 23:02, Samer El-Haj-Mahmoud <Samer.El-Haj-
> Mahmoud@arm.com> wrote:
> >
> > Tested with USB NICs (both ASIX AX88772C and Realtek gigabit ethernet).
> Both work pretty well (tested IPv4 and IPv6).
> >
>
> Excellent, thanks.
>
> Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>
> Pushed as 8b38aefc07bc..3daa70143953
>
> Should we do the same for RPi3?
>
Yes, sending another patch for RPi3
>
> > -----Original Message-----
> > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Ard
> > Biesheuvel via Groups.Io
> > Sent: Tuesday, March 24, 2020 5:55 PM
> > To: Samer El-Haj-Mahmoud <samer@elhajmahmoud.com>
> > Cc: edk2-devel-groups-io <devel@edk2.groups.io>; Leif Lindholm
> > <leif@nuviainc.com>
> > Subject: Re: [edk2-devel] [[edk2-platform][PATCH 1/1]
> > Platform/RaspberryPi/RPi4: Enable HTTP Boot
> >
> > On Tue, 24 Mar 2020 at 22:53, Samer El-Haj-Mahmoud
> <samer@elhajmahmoud.com> wrote:
> > >
> > > Enable HTTP Boot (with and without TLS) on RPi4
> > >
> > > Cc: Leif Lindholm <leif@nuviainc.com>
> > > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> > >
> > > Signed-off-by: Samer El-Haj-Mahmoud <samer@elhajmahmoud.com>
> >
> > Which NIC are you HTTP booting from?
> >
> > > ---
> > > Platform/RaspberryPi/RPi4/RPi4.dsc | 9 +++------
> > > 1 file changed, 3 insertions(+), 6 deletions(-)
> > >
> > > diff --git a/Platform/RaspberryPi/RPi4/RPi4.dsc
> > > b/Platform/RaspberryPi/RPi4/RPi4.dsc
> > > index 2e98c3e16b91..f6b627af279c 100644
> > > --- a/Platform/RaspberryPi/RPi4/RPi4.dsc
> > > +++ b/Platform/RaspberryPi/RPi4/RPi4.dsc
> > > @@ -25,12 +25,6 @@ [Defines]
> > > SKUID_IDENTIFIER = DEFAULT
> > > FLASH_DEFINITION =
> Platform/RaspberryPi/$(PLATFORM_NAME)/$(PLATFORM_NAME).fdf
> > >
> > > - #
> > > - # Network definition
> > > - #
> > > - DEFINE NETWORK_TLS_ENABLE = FALSE
> > > - DEFINE NETWORK_HTTP_BOOT_ENABLE = FALSE
> > > -
> > > #
> > > # Defines for default states. These can be changed on the command line.
> > > # -D FLAG=VALUE
> > > @@ -139,6 +133,7 @@ [LibraryClasses.common]
> > > IntrinsicLib|CryptoPkg/Library/IntrinsicLib/IntrinsicLib.inf
> > > BaseCryptLib|CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf
> > > OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLib.inf
> > > + TlsLib|CryptoPkg/Library/TlsLib/TlsLib.inf
> > >
> > > #
> > > # Uncomment (and comment out the next line) For RealView Debugger.
> > > The Standard IO window @@ -358,6 +353,8 @@
> [PcdsFixedAtBuild.common]
> > >
> > > gEfiSecurityPkgTokenSpaceGuid.PcdRemovableMediaImageVerificationPoli
> > > cy
> > > |0x04
> > > !endif
> > >
> > > + gEfiNetworkPkgTokenSpaceGuid.PcdAllowHttpConnections|TRUE
> > > +
> > > [LibraryClasses.common]
> > > ArmLib|ArmPkg/Library/ArmLib/ArmBaseLib.inf
> > > ArmMmuLib|ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf
> > > --
> > > 2.17.1
> > >
> >
> >
> >
> > IMPORTANT NOTICE: The contents of this email and any attachments are
> confidential and may also be privileged. If you are not the intended recipient,
> please notify the sender immediately and do not disclose the contents to any
> other person, use it for any purpose, or store or copy the information in any
> medium. Thank you.
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-03-25 12:49 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-03-24 21:53 [[edk2-platform][PATCH 1/1] Platform/RaspberryPi/RPi4: Enable HTTP Boot Samer El-Haj-Mahmoud
2020-03-24 21:55 ` Ard Biesheuvel
2020-03-24 22:02 ` [edk2-devel] " Samer El-Haj-Mahmoud
2020-03-25 9:20 ` Ard Biesheuvel
2020-03-25 12:48 ` Samer El-Haj-Mahmoud
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox