From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) by mx.groups.io with SMTP id smtpd.web10.7690.1585128038199558611 for ; Wed, 25 Mar 2020 02:20:38 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=lQi4b1FV; spf=pass (domain: linaro.org, ip: 209.85.128.54, mailfrom: ard.biesheuvel@linaro.org) Received: by mail-wm1-f54.google.com with SMTP id b12so1495135wmj.3 for ; Wed, 25 Mar 2020 02:20:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=xq502gA+wbhkZprK1VD6rJxupT8Zr08/v+mbhEgaJRU=; b=lQi4b1FVwKIXx9OCpjeUIcKr6J/i1EfYWDCnEu5vUFzYZLdxpbgpY7y8oHdwAQD7xJ lWvlrWh2gX+3t4Y2ZHCxFtXcLYZQ4+SJgRXrulC/VFTdeFT4xzcKFbcUV12AAvBBo8gP K8lyxgCAeRNGHLJQKjdz0OAaPOw2H3n8l7vzaflyKPmlpudRqj6dUJ6wJMRgOO2ksNHw YUrtI8xxMmdqpRTD2psJvdW+yWwEYQqNYB7wacTwmgO9mmflBCw038hhiwD+HvNx8vhD gPh6rfPPDlpNNygB+EGevtLkBUTHJXrEHzMQGpvxRMEcABieWSxz547bPV7QVuy4vkA7 l3Ew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=xq502gA+wbhkZprK1VD6rJxupT8Zr08/v+mbhEgaJRU=; b=c2jHJnIiiCeUNdHb5elfKkFyszc80TrWeylPSKxJlONyTnitLsiFOKDdfTisbhlMFz 2tSYZbbgETYeUdFSKScfD/+Ng48UGR7eRoLzOWRS4+p3yRw2mmZ5dJVPouFHs1dzrXyy 6NTQYWwLS7AfbigWCIAkhQNeL9MxdATJsSg+jbHns5Sdpo39Ug9ZLkzMJGAB34kHBzym IcsaGhH0XjOOWdXz50jv8rkmxjpmeWvqvcbFieLIVbi1ICo0V/y00bRmtLL1POOZyqJU IFnEjYXIAkbpJpvOB1QdpGVKvJF58+SplY3PlxPcRxJGBDrconQSchefrDRWLXJ3tBAG LI+g== X-Gm-Message-State: ANhLgQ0J1Z+2q8QyPev6XEtS6O2yz0Cwg3po6GEEmnhhWe6khxgc35wd t8oBtkojCTOJVBX6exqLaEMArbbFzwbNzioxdzlEaw== X-Google-Smtp-Source: ADFU+vuZf9GHrJglvVWwKudVl02HealgitaeWL3LqpIAe/kwEMUh2FW/xoccPXStO9VfKzbeXgywGi5senZ1OToMYyk= X-Received: by 2002:a1c:de87:: with SMTP id v129mr2411156wmg.40.1585128036745; Wed, 25 Mar 2020 02:20:36 -0700 (PDT) MIME-Version: 1.0 References: <20200324215342.666-1-samer@elhajmahmoud.com> In-Reply-To: From: "Ard Biesheuvel" Date: Wed, 25 Mar 2020 10:20:25 +0100 Message-ID: Subject: Re: [edk2-devel] [[edk2-platform][PATCH 1/1] Platform/RaspberryPi/RPi4: Enable HTTP Boot To: Samer El-Haj-Mahmoud Cc: "devel@edk2.groups.io" , Samer El-Haj-Mahmoud , Leif Lindholm Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable (+ Pete) Could you please keep Pete on cc for RPi patches? On Tue, 24 Mar 2020 at 23:02, Samer El-Haj-Mahmoud wrote: > > Tested with USB NICs (both ASIX AX88772C and Realtek gigabit ethernet). = Both work pretty well (tested IPv4 and IPv6). > Excellent, thanks. Reviewed-by: Ard Biesheuvel Pushed as 8b38aefc07bc..3daa70143953 Should we do the same for RPi3? > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Ard Biesh= euvel via Groups.Io > Sent: Tuesday, March 24, 2020 5:55 PM > To: Samer El-Haj-Mahmoud > Cc: edk2-devel-groups-io ; Leif Lindholm > Subject: Re: [edk2-devel] [[edk2-platform][PATCH 1/1] Platform/Raspberry= Pi/RPi4: Enable HTTP Boot > > On Tue, 24 Mar 2020 at 22:53, Samer El-Haj-Mahmoud wrote: > > > > Enable HTTP Boot (with and without TLS) on RPi4 > > > > Cc: Leif Lindholm > > Cc: Ard Biesheuvel > > > > Signed-off-by: Samer El-Haj-Mahmoud > > Which NIC are you HTTP booting from? > > > --- > > Platform/RaspberryPi/RPi4/RPi4.dsc | 9 +++------ > > 1 file changed, 3 insertions(+), 6 deletions(-) > > > > diff --git a/Platform/RaspberryPi/RPi4/RPi4.dsc > > b/Platform/RaspberryPi/RPi4/RPi4.dsc > > index 2e98c3e16b91..f6b627af279c 100644 > > --- a/Platform/RaspberryPi/RPi4/RPi4.dsc > > +++ b/Platform/RaspberryPi/RPi4/RPi4.dsc > > @@ -25,12 +25,6 @@ [Defines] > > SKUID_IDENTIFIER =3D DEFAULT > > FLASH_DEFINITION =3D Platform/RaspberryPi/$(PLATFORM_= NAME)/$(PLATFORM_NAME).fdf > > > > - # > > - # Network definition > > - # > > - DEFINE NETWORK_TLS_ENABLE =3D FALSE > > - DEFINE NETWORK_HTTP_BOOT_ENABLE =3D FALSE > > - > > # > > # Defines for default states. These can be changed on the command = line. > > # -D FLAG=3DVALUE > > @@ -139,6 +133,7 @@ [LibraryClasses.common] > > IntrinsicLib|CryptoPkg/Library/IntrinsicLib/IntrinsicLib.inf > > BaseCryptLib|CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf > > OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLib.inf > > + TlsLib|CryptoPkg/Library/TlsLib/TlsLib.inf > > > > # > > # Uncomment (and comment out the next line) For RealView Debugger. > > The Standard IO window @@ -358,6 +353,8 @@ [PcdsFixedAtBuild.common] > > > > gEfiSecurityPkgTokenSpaceGuid.PcdRemovableMediaImageVerificationPolicy > > |0x04 > > !endif > > > > + gEfiNetworkPkgTokenSpaceGuid.PcdAllowHttpConnections|TRUE > > + > > [LibraryClasses.common] > > ArmLib|ArmPkg/Library/ArmLib/ArmBaseLib.inf > > ArmMmuLib|ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf > > -- > > 2.17.1 > > > >=20 > > IMPORTANT NOTICE: The contents of this email and any attachments are con= fidential and may also be privileged. If you are not the intended recipient= , please notify the sender immediately and do not disclose the contents to = any other person, use it for any purpose, or store or copy the information = in any medium. Thank you.