From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c0b::242; helo=mail-it0-x242.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it0-x242.google.com (mail-it0-x242.google.com [IPv6:2607:f8b0:4001:c0b::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 3D5102215238F for ; Mon, 4 Dec 2017 08:10:44 -0800 (PST) Received: by mail-it0-x242.google.com with SMTP id x28so14038875ita.0 for ; Mon, 04 Dec 2017 08:15:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=wAr9hsVj1QLYYHz4unWg3VqqeRyvy5K1zj1wtbkQV5w=; b=IMfoFRt6IOww8pjiLalgX7BlbzsNGkyFF8ObPLC0/fkk98p5XGgCWEszF7kVUWtaKI NKO+SYsOi88g84n/WcT5JItcs32tETPj2wNSwTnwVISW7CDeIXnlzvjlY9TIvZlJNkdu cMkcPyZET+8rKWo3CnR1y2vtuxWYD5wezSBA0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=wAr9hsVj1QLYYHz4unWg3VqqeRyvy5K1zj1wtbkQV5w=; b=Wn3oJSQWg4onhwiONExGHy2IJzi7bAaqxAuuo9FXcCUZL5qOKL0u0MRal9qYPqIsye MnTDMPqJ0+ZktRDVbLsLONr2aJp/dbHeuowIxK/pBcJURrLV9T4yzM7Df3jGK4TVfThc 01SX1yCrCGcrT3sS3cJ4TfBADbac130NuMioiZ3VweRPRmP7mWR/VqPgdXu3x95SRFhn Jz/PIe6Xg6Y6JKbECdeWDwyOhD27JFPkbByi2TbWVdSUUqL6F4iDVeIX2AefKYQWaODO a1gDqm68vfF5wcYyuR3LlAKlDrPM0ZZrQpVdvnfSSZpLKNv40s85T3T4g5I8qTb7jccj snag== X-Gm-Message-State: AJaThX6Lt+3qOQc5j/Kbi+cl9g9H+zRs+XCAj9cAKSSUaB17RXYbCrV8 D0dItdo0h7Bbu/7NPvn8j6lGHPNCfGn33MBMk4ZYoUZl1ms= X-Google-Smtp-Source: AGs4zMZ4Pc5Ipy/ArgGXUjqKTPg9YTEAJzrR2oLRRDg3Z83Rw9INlBAgs8P4b4mC9bsBdU/XjVu+i+9TzV3EV2vwr0M= X-Received: by 10.107.151.142 with SMTP id z136mr25103609iod.248.1512404114256; Mon, 04 Dec 2017 08:15:14 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.104.16 with HTTP; Mon, 4 Dec 2017 08:15:13 -0800 (PST) In-Reply-To: <5a2cd371-35e3-2b1d-39d5-129ef71158b4@redhat.com> References: <20171130203114.19464-1-ard.biesheuvel@linaro.org> <5a2cd371-35e3-2b1d-39d5-129ef71158b4@redhat.com> From: Ard Biesheuvel Date: Mon, 4 Dec 2017 16:15:13 +0000 Message-ID: To: Laszlo Ersek Cc: "edk2-devel@lists.01.org" , Julien Grall Subject: Re: [PATCH RFT] ArmVirtPkg/ArmVirtXen: move from Intel to generic BDS X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Dec 2017 16:10:45 -0000 Content-Type: text/plain; charset="UTF-8" On 1 December 2017 at 10:08, Laszlo Ersek wrote: > On 11/30/17 21:31, Ard Biesheuvel wrote: >> ArmVirtXen is the only remaining consumer of ArmPlatformPkg's >> PlatformIntelBdsLib implementation, which is tightly coupled to the >> deprecated Intel BDS. So move ArmVirtXen to the generic BDS as well, >> allowing us to get rid of PlatformIntelBdsLib entirely. >> >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Ard Biesheuvel >> --- >> ArmVirtPkg/ArmVirtXen.dsc | 14 +++++++++++--- >> ArmVirtPkg/ArmVirtXen.fdf | 3 ++- >> 2 files changed, 13 insertions(+), 4 deletions(-) >> >> diff --git a/ArmVirtPkg/ArmVirtXen.dsc b/ArmVirtPkg/ArmVirtXen.dsc >> index 11e073287a84..ae43d5990110 100644 >> --- a/ArmVirtPkg/ArmVirtXen.dsc >> +++ b/ArmVirtPkg/ArmVirtXen.dsc >> @@ -48,8 +48,9 @@ [LibraryClasses] >> TimerLib|ArmPkg/Library/ArmArchTimerLib/ArmArchTimerLib.inf >> >> CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf >> - GenericBdsLib|IntelFrameworkModulePkg/Library/GenericBdsLib/GenericBdsLib.inf >> - PlatformBdsLib|ArmPlatformPkg/Library/PlatformIntelBdsLib/PlatformIntelBdsLib.inf >> + UefiBootManagerLib|MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf >> + BootLogoLib|MdeModulePkg/Library/BootLogoLib/BootLogoLib.inf >> + PlatformBootManagerLib|ArmPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf >> CustomizedDisplayLib|MdeModulePkg/Library/CustomizedDisplayLib/CustomizedDisplayLib.inf >> >> [LibraryClasses.common.UEFI_DRIVER] >> @@ -86,6 +87,7 @@ [PcdsFixedAtBuild.common] >> gArmTokenSpaceGuid.PcdArmArchTimerFreqInHz|0 >> >> gEfiMdeModulePkgTokenSpaceGuid.PcdResetOnMemoryTypeInformationChange|FALSE >> + gEfiMdeModulePkgTokenSpaceGuid.PcdBootManagerMenuFile|{ 0x21, 0xaa, 0x2c, 0x46, 0x14, 0x76, 0x03, 0x45, 0x83, 0x6e, 0x8a, 0xb6, 0xf4, 0x66, 0x23, 0x31 } >> gEfiIntelFrameworkModulePkgTokenSpaceGuid.PcdShellFile|{ 0x83, 0xA5, 0x04, 0x7C, 0x3E, 0x9E, 0x1C, 0x4F, 0xAD, 0x65, 0xE0, 0x52, 0x68, 0xD0, 0xB4, 0xD1 } >> >> [PcdsPatchableInModule.common] >> @@ -199,7 +201,13 @@ [Components.common] >> MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf >> MdeModulePkg/Universal/DisplayEngineDxe/DisplayEngineDxe.inf >> MdeModulePkg/Universal/SetupBrowserDxe/SetupBrowserDxe.inf >> - IntelFrameworkModulePkg/Universal/BdsDxe/BdsDxe.inf >> + MdeModulePkg/Universal/BdsDxe/BdsDxe.inf >> + MdeModulePkg/Application/UiApp/UiApp.inf { >> + >> + NULL|MdeModulePkg/Library/DeviceManagerUiLib/DeviceManagerUiLib.inf >> + NULL|MdeModulePkg/Library/BootManagerUiLib/BootManagerUiLib.inf >> + NULL|MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootMaintenanceManagerUiLib.inf >> + } >> >> OvmfPkg/XenBusDxe/XenBusDxe.inf >> OvmfPkg/XenPvBlkDxe/XenPvBlkDxe.inf >> diff --git a/ArmVirtPkg/ArmVirtXen.fdf b/ArmVirtPkg/ArmVirtXen.fdf >> index 6586ce6be505..50e670254d52 100644 >> --- a/ArmVirtPkg/ArmVirtXen.fdf >> +++ b/ArmVirtPkg/ArmVirtXen.fdf >> @@ -177,7 +177,8 @@ [FV.FvMain] >> INF MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf >> INF MdeModulePkg/Universal/DisplayEngineDxe/DisplayEngineDxe.inf >> INF MdeModulePkg/Universal/SetupBrowserDxe/SetupBrowserDxe.inf >> - INF IntelFrameworkModulePkg/Universal/BdsDxe/BdsDxe.inf >> + INF MdeModulePkg/Universal/BdsDxe/BdsDxe.inf >> + INF MdeModulePkg/Application/UiApp/UiApp.inf >> >> INF OvmfPkg/XenBusDxe/XenBusDxe.inf >> INF OvmfPkg/XenPvBlkDxe/XenPvBlkDxe.inf >> > > The patch looks fine, and I agree that the main thing that should decide > about it is testing by Julien. > > Acked-by: Laszlo Ersek > Pushed as 75e2d0e02f1c40a2e4971bd67399028e0b1681c8, after folding in the changes that Julien tested. Thanks all.