From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: Leif Lindholm <leif.lindholm@linaro.org>
Cc: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
"Laszlo Ersek" <lersek@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: Re: [PATCH 0/2] Clear frame pointer in startup code on AARCH64 systems
Date: Mon, 19 Nov 2018 11:28:42 -0800 [thread overview]
Message-ID: <CAKv+Gu_6F+VwwtvdgYTHz+y7PeBphznv5awarNX10qKugX0DDQ@mail.gmail.com> (raw)
In-Reply-To: <20181119185629.lhpqadyzfrffnc5p@bivouac.eciton.net>
On Mon, 19 Nov 2018 at 10:56, Leif Lindholm <leif.lindholm@linaro.org> wrote:
>
> On Fri, Nov 16, 2018 at 02:55:56PM -0800, Ard Biesheuvel wrote:
> > The backtrace code on AARCH64 does not sanitize the frame pointer values
> > it pulls of the stack when attempting to do a backtrace, and so junk left
> > in the frame pointer register may result in a recursive exception and a
> > truncated backtrace.
>
> If I was bikeshedding, I'd ask for a (NULL) in the comments next to
> the 0x0. But other than that, for the series:
> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
> (be it green or black)
>
Thanks all.
Series pushed as 316b3a719fd2..81c6f1dfbac1 (after s/0x0/NULL/ in the comments)
prev parent reply other threads:[~2018-11-19 19:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-16 22:55 [PATCH 0/2] Clear frame pointer in startup code on AARCH64 systems Ard Biesheuvel
2018-11-16 22:55 ` [PATCH 1/2] ArmPlatformPkg: clear frame pointer in startup code Ard Biesheuvel
2018-11-16 22:55 ` [PATCH 2/2] ArmVirtPkg/PrePi: " Ard Biesheuvel
2018-11-19 18:53 ` [PATCH 0/2] Clear frame pointer in startup code on AARCH64 systems Laszlo Ersek
2018-11-19 18:56 ` Leif Lindholm
2018-11-19 19:28 ` Ard Biesheuvel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKv+Gu_6F+VwwtvdgYTHz+y7PeBphznv5awarNX10qKugX0DDQ@mail.gmail.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox