From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::144; helo=mail-it1-x144.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it1-x144.google.com (mail-it1-x144.google.com [IPv6:2607:f8b0:4864:20::144]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 54DB82119306F for ; Mon, 19 Nov 2018 11:28:53 -0800 (PST) Received: by mail-it1-x144.google.com with SMTP id x19so10082481itl.1 for ; Mon, 19 Nov 2018 11:28:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=f7ScbhmaVTpxVvhBD9Z2Z+qWn4CgG1x6AaOaZMKlebY=; b=UQgXNRiRMYePymlfGZBHhYOcNaRPr27Pkla1IlTPkgWTgCSQlRdfJISnR74UkzY/gI l5BE0XrCbaQ4ZlSg3ZMSrWrDMabhxDtIOE4R8pxN0OkaAQY1pqC9V7ctOauS+E8OYKYl U4bg3XPTEaI6JrYSepy9qyJ8oxrQhQP0yE18M= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=f7ScbhmaVTpxVvhBD9Z2Z+qWn4CgG1x6AaOaZMKlebY=; b=oTR3CamV1Pb2+cdl932qEbT6Gxm2hEg1ECn5D2S6uXBAyKx4iFWqyqp23wK2JhRijm bms1EDyWhkE+W+6tu6SYGXXxkSpQ3+rnHjyHfGwBplVPKNDqSk92WA0O83Cvb2WpQyui uq8nYi8U2ups60mLZKDv0ZDAYO8cxdveKhm9ieie5+v9lsNCAQ8EMd9xu0xcrRSPLFu+ wuli8VqqdgvR9hInPDRefbyTmPfza43jOQ0RPiE126tRpyjOqRhiDkbOEMZ2QUsK5CTc AXGEvWa+mY9b/1tSrpfM43ju56opedJmt2bYEoZoztkAEqk397CL2vV5P2wAGGQRl3p7 CoTw== X-Gm-Message-State: AGRZ1gLLg4IVpGov4JbahGYzdkhoTC3bo1Xkvuly40fpeOIvHS64aWJU tlwb6H9dCmR6pvsTjF5M4CjZQab/Stn4TTsdvjz0cQ== X-Google-Smtp-Source: AFSGD/Vt2QUKBoarI4kXX6RF0ZBE7qUkmWVk1nqeGQXJBwwmtqteuw9WsPu7CUMO6Lfn6srbGdrCp2G31NmLFw1e+LU= X-Received: by 2002:a05:660c:4b:: with SMTP id p11mr2442173itk.71.1542655733140; Mon, 19 Nov 2018 11:28:53 -0800 (PST) MIME-Version: 1.0 References: <20181116225558.27720-1-ard.biesheuvel@linaro.org> <20181119185629.lhpqadyzfrffnc5p@bivouac.eciton.net> In-Reply-To: <20181119185629.lhpqadyzfrffnc5p@bivouac.eciton.net> From: Ard Biesheuvel Date: Mon, 19 Nov 2018 11:28:42 -0800 Message-ID: To: Leif Lindholm Cc: "edk2-devel@lists.01.org" , Laszlo Ersek , =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= Subject: Re: [PATCH 0/2] Clear frame pointer in startup code on AARCH64 systems X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Nov 2018 19:28:54 -0000 Content-Type: text/plain; charset="UTF-8" On Mon, 19 Nov 2018 at 10:56, Leif Lindholm wrote: > > On Fri, Nov 16, 2018 at 02:55:56PM -0800, Ard Biesheuvel wrote: > > The backtrace code on AARCH64 does not sanitize the frame pointer values > > it pulls of the stack when attempting to do a backtrace, and so junk left > > in the frame pointer register may result in a recursive exception and a > > truncated backtrace. > > If I was bikeshedding, I'd ask for a (NULL) in the comments next to > the 0x0. But other than that, for the series: > Reviewed-by: Leif Lindholm > (be it green or black) > Thanks all. Series pushed as 316b3a719fd2..81c6f1dfbac1 (after s/0x0/NULL/ in the comments)