From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=JY5xEVgZ; spf=pass (domain: linaro.org, ip: 209.85.166.66, mailfrom: ard.biesheuvel@linaro.org) Received: from mail-io1-f66.google.com (mail-io1-f66.google.com [209.85.166.66]) by groups.io with SMTP; Wed, 10 Apr 2019 09:27:12 -0700 Received: by mail-io1-f66.google.com with SMTP id c4so2668446ioh.9 for ; Wed, 10 Apr 2019 09:27:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=qWmg/3LCnbwFwJsKOwOcqdhI2LZeB6nH0oe80xU4WNU=; b=JY5xEVgZUkmeMuYZo6oxBOKS6+e1RJfoKJJysV4bzbLWOjkVOT07ZfMek6QyZJOVYf ACYEKQ7I3XrWyEiZ2qMB8xbwaiWpxayEV30V/FV6cspRwKWJ+7iuXzsihGv9i99bjCKJ ckQhaqp1kNpHjZLEEcH8dpG84V4EDQUOVyTm06tihKj+hfkm933aNoRH//92BRrH67P1 UNpQDHmHL3lx3PV+L2sPpZTABfrPZfjqSS0ILNGx89PWu3lv8O/Eync8iF1DuTHQzffy ZJR1PiilU9YhmEdvT30TlzwNY8lgAxRtxAwEeQJ5BDu/hGQtKLKET6j7xc0V9HXx6SzE QjFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qWmg/3LCnbwFwJsKOwOcqdhI2LZeB6nH0oe80xU4WNU=; b=oMdW+4VOO0HBU18ian4ufCvOHhhQa4pZIcMrY+Q4BCSmh30pEtsntlI6JoFsJOS2Jl gUFwUyQD9DWS8kasunO0AKyUowVGn13kiLbtaaTwHZsu3kKhByPBeWS3xNpKrK20RdxX 4MmeXf5lw5gA5DLTWXKHb2Dm2XZVaHROMmO61xCYH+1ldCAajaS4Ylff4ymY4z6p1ODM x2C9yM/Dp2YOvEFwln10QASGtPImru/OiLIqhhKnp9OdYKKP0creXHTd4r8HJw00WwIC LQaTe1/83W1gb5CYDTB98T/J2u6pc2yNa6MADaaO5z5YkrNvAAeQEe3Gwq0tYqXkiryH o9Tg== X-Gm-Message-State: APjAAAVl/WScR/56VWZgGvz3z1fVc5LRbCu7Wn602AXuNkpYF7UYt9Av +/p2UA1kTKbQfqstjVXFCAiAUAXDaOJXiIMIqZDwHGKt8ynvTw== X-Google-Smtp-Source: APXvYqxSFjuppHHHtohkcJoYDHryseturFvYtjvY8AGXgWv517e8+Fzrz4cVRovG37ZxFhU70x7GdW72pCpZ+ZYcqbs= X-Received: by 2002:a5d:840d:: with SMTP id i13mr22030031ion.186.1554913631686; Wed, 10 Apr 2019 09:27:11 -0700 (PDT) MIME-Version: 1.0 References: <20190409110844.14746-1-anthony.perard@citrix.com> <20190409110844.14746-3-anthony.perard@citrix.com> <155488970861.20447.12525571872411959890@jljusten-skl> In-Reply-To: From: "Ard Biesheuvel" Date: Wed, 10 Apr 2019 09:27:02 -0700 Message-ID: Subject: Re: [edk2-devel] [PATCH v2 02/31] OvmfPkg: Create platform XenOvmf To: edk2-devel-groups-io , Laszlo Ersek Cc: Jordan Justen , Anthony PERARD , Ard Biesheuvel , Julien Grall , xen-devel Content-Type: text/plain; charset="UTF-8" On Wed, 10 Apr 2019 at 07:27, Laszlo Ersek wrote: > > On 04/10/19 11:48, Jordan Justen wrote: > > On 2019-04-09 04:08:15, Anthony PERARD wrote: > >> This is a copy of OvmfX64, removing VirtIO and some SMM. > >> > >> This new platform will be changed to make it works on two types of Xen > >> guest: HVM and PVH. > >> > >> Compare to OvmfX64, this patch: > >> > >> - changed: PLATFORM_GUID, OUTPUT_DIRECTORY, FLASH_DEFINITION > >> - removed: VirtioLib class resolution > >> - removed: all UEFI_DRIVER modules for virtio devices > >> - removed: DXE_SMM_DRIVER and SMM_CORE lib class resolutions > >> - removed: DXE_SMM_DRIVER and SMM_CORE FDF rules > >> - removed: Everything related to SMM_REQUIRE==true > >> - removed: Everything related to SECURE_BOOT_ENABLE==true > >> - removed: Everything related to TPM2_ENABLE==true > >> - changed: PcdPciDisableBusEnumeration dynamic default flipped to TRUE > >> - changed: default FD_SIZE_IN_KB to 2M. > >> > >> Contributed-under: TianoCore Contribution Agreement 1.1 > >> Signed-off-by: Anthony PERARD > >> --- > >> OvmfPkg/{OvmfPkgX64.dsc => XenOvmf.dsc} | 202 +------------------- > > > > I guess we all want our name to be first :), but OvmfXen seems more > > like the pattern that edk2 uses when making sub-platforms. > > > > Also, in some cases we've used !ifdef type things to keep dsc and fdf > > files common. Would that not be workable here? Maybe it would get too > > ugly. :\ > > I've been happy with a similar Xen<->QEMU split under ArmVirtPkg. > Duplications in updates are usually not a huge burden, and keeping the > files separate has proved very helpful for determining > maintainer/reviewer/tester responsibility. > > > It could help to prevent having to sync dsc changes across, and > > prevent changes from being omitted for Xen on accident. > > True, but in my experience that's been the smaller problem. The larger > problem has been modifying Xen stuff in unintended ways (= regressing > Xen), because we can't test (or don't even notice) the Xen-side > implications of changes made to common source. > > Personally I prefer another (DSC + FDF) pair under OvmfPkg (beyond the > three we already have) to another layer of (conditional?) includes. The > !if's that are being eliminated in this Xen-customized copy (i.e., in > this patch) are complex enough already :) > > ... It's not that I *generally* prefer duplication; as you say, we do > have a number of !includes already. I do prefer duplication specifically > for Xen vs. QEMU however. > +1