From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::142; helo=mail-it1-x142.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it1-x142.google.com (mail-it1-x142.google.com [IPv6:2607:f8b0:4864:20::142]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 269282194EB70 for ; Tue, 5 Mar 2019 09:29:50 -0800 (PST) Received: by mail-it1-x142.google.com with SMTP id v83so5771184itf.1 for ; Tue, 05 Mar 2019 09:29:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=RUqaQ5QX3fTQs6CWjCcFNCeHu5SLh9AzXAgh1LU4UdY=; b=e3bK5VOAdf/B6HuzYPGJoNIq+hB+hvsuOzlck32Zu+WDtndzlixa5ZKCqEI3VbTd0K Sis4ku+6tUIMAbNMb6SWnh/fO4u9+pBH4gE7Oe+TSlb7FAZaOIuxd0LXvV6fUadjmLzM dArRKlVi380izNzoOZG4ENkiaICFGk7OS8c9O6iNHhgbnEU0om9HSBq0uisdxEecmRny Dw5biccnGj7UqbsIjk3Y5wVU26au3IzyvG09pmZuRcDzafrXc+Q96M+fWcZ7BlcrIfLr OxZuZYi04TtsBTxkD1BqEiqGUcRlP9CEwOfmn+/gxerZVQE7D0GaQbgueLgZJq/pJlb+ Iqew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=RUqaQ5QX3fTQs6CWjCcFNCeHu5SLh9AzXAgh1LU4UdY=; b=U5RM0v4sv5/P6KNG5FTX3dRAItz7UIOU9/kdwHNIlmQkHKq/mV274b1ovgqH0ThGnR scPDYYC+itr1QlxY+LIcp0/EJGoPqBqiMzpceFV4EKRke1E/FkVhvijwJnrA2h6cSMgw 15tZwDQnk9FcbSoUYAFh5sY0WfEmWcZeaYl0mMzNGksNSU7n+eRJgzQLl7Kq3RzSwDfj m8qdhKcXyojYJ/mDwzdxO3Dg+jMY4hL0QVW4G2IPWdV50MPykAjewt9rVvaWh2tFu/8+ QSuZmNyBUc5cOwwjNCANQRrQ0jpQw/8SROU8K6kWP8eVyYpDy/yTt9BU21e677U1EydK aVTw== X-Gm-Message-State: APjAAAW4NUZfzghiydAcZX3tni7BUKiK70gh5a7Lp26PLZkn5SxPcwHl QMel2+NBvK0rN4Jd6pm/T2V1jR7ekH11m9rWYrgBbYVBXL0= X-Google-Smtp-Source: APXvYqynXAJo3s03kMvsMPT6ScNmbQVYoH1ZMSB+Vm7KHmUDppbaf2Ghp20XBs2eH5qilZJjT72W2WHm8gnMTrKTO2U= X-Received: by 2002:a02:568a:: with SMTP id u10mr1835649jad.130.1551806990088; Tue, 05 Mar 2019 09:29:50 -0800 (PST) MIME-Version: 1.0 References: <20190305133248.4828-1-ard.biesheuvel@linaro.org> <20190305133248.4828-11-ard.biesheuvel@linaro.org> <74D8A39837DF1E4DA445A8C0B3885C503F54D1FD@shsmsx102.ccr.corp.intel.com> <74D8A39837DF1E4DA445A8C0B3885C503F54F0BB@shsmsx102.ccr.corp.intel.com> <74D8A39837DF1E4DA445A8C0B3885C503F54FAE7@shsmsx102.ccr.corp.intel.com> <9333E191E0D52B4999CE63A99BA663A00302C6A7AB@atlms1.us.megatrends.com> In-Reply-To: <9333E191E0D52B4999CE63A99BA663A00302C6A7AB@atlms1.us.megatrends.com> From: Ard Biesheuvel Date: Tue, 5 Mar 2019 18:29:38 +0100 Message-ID: To: Felix Polyudov Cc: "Yao, Jiewen" , "edk2-devel@lists.01.org" Subject: Re: [PATCH 10/10] ArmPkg/MmCommunicationDxe: signal architected PI events into MM context X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Mar 2019 17:29:51 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, 5 Mar 2019 at 17:53, Felix Polyudov wrote: > > There is an architectural difference between EndOfDxe and SmmReadyToLock = events. > It's important to have both of them. > Here is what PI specification says: > =3D=3D > Transition from the environment where all of the components are under the= authority of the platform manufacturer to the environment where third part= y modules are executed is a two-step process: > 1.End of DXE Event is signaled. This event presents the last opportunity = to use resources or interfaces that are going to be locked or disabled in a= nticipation of the invocation of 3rd party extensible modules. > 2.DXE SMM Ready to Lock Protocol is installed. PI modules that need to lo= ck or protect their resources in anticipation of the invocation of 3rd part= y extensible modules should register for notification on installation of th= is protocol and effect the appropriate protections in their notification ha= ndlers Thanks for pointing that out, Felix. I will add SmmReadyToLock as well. > =3D=3D > > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Ya= o, Jiewen > Sent: Tuesday, March 05, 2019 11:19 AM > To: Ard Biesheuvel > Cc: edk2-devel@lists.01.org > Subject: Re: [edk2] [PATCH 10/10] ArmPkg/MmCommunicationDxe: signal archi= tected PI events into MM context > > For current X86 world, we do use both SmmReadyToLock and EndOfDxe, for al= most all X86 platform. > > So, let me clarify: > If we try to align with PI spec, we can add EndOfDxe/ReadyToBoot/ExitBoot= Service. > If we try to align with security, we can add EndOfDxe/SmmReadyToLock. > > It depends upon the what goal we want to achieve. That is why I ask if we= have specific use case. > > Anyway, I think we can add when it is really needed later. > So I am OK with current patch. > > Thank you > Yao Jiewen > > > -----Original Message----- > > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > > Ard Biesheuvel > > Sent: Tuesday, March 5, 2019 8:07 AM > > To: Yao, Jiewen > > Cc: edk2-devel@lists.01.org > > Subject: Re: [edk2] [PATCH 10/10] ArmPkg/MmCommunicationDxe: signal > > architected PI events into MM context > > > > On Tue, 5 Mar 2019 at 17:04, Yao, Jiewen wrote: > > > > > > OK. To keep the compatibility of existing MM driver. That makes sense= . > > > > > > If it is for security, I think EndOfDxe is the only point. > > > ReadyToBoot and ExitBootService cannot be used for security purpose. > > > > > > > OK, good to know. I will keep them for the time being - MM drivers may > > be able to release resources or do other useful things when the > > non-secure side enters runtime mode. > > > > > Then do we need SmmReadyToLock ? :-) > > > > > > > Good point. It looked fairly x86 specific to me. Do you think it is > > likely to be used in OEM code running in MM mode? > > > > > > > > > > > > -----Original Message----- > > > > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf > > Of > > > > Ard Biesheuvel > > > > Sent: Tuesday, March 5, 2019 7:58 AM > > > > To: Yao, Jiewen > > > > Cc: edk2-devel@lists.01.org > > > > Subject: Re: [edk2] [PATCH 10/10] ArmPkg/MmCommunicationDxe: > > signal > > > > architected PI events into MM context > > > > > > > > On Tue, 5 Mar 2019 at 16:56, Yao, Jiewen > > wrote: > > > > > > > > > > Hi > > > > > In original SMM infrastructure, there are lots of interaction tha= t SMM > > has > > > > to know the DXE status. > > > > > > > > > > In StandaloneMm, I don't expect we have many interaction. Is ther= e > > any > > > > specific example? > > > > > > > > > > I am totally OK to add those. And I just want to know more usage. > > > > > > > > > > Reviewed-by: Jiewen.yao@intel.com > > > > > > > > > > > > > Jiewen, > > > > > > > > Thanks for the review. > > > > > > > > It is not 100% clear at the moment, but since existing third party > > > > software designed to run in MM context may make assumptions about > > > > security of the platform (e.g., before vs after end of dxe) based o= n > > > > these events, we should at least signal the common ones added in th= is > > > > patch. > > > > > > > > > > > > > > > > > > > > > > -----Original Message----- > > > > > > From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org] > > > > > > Sent: Tuesday, March 5, 2019 5:33 AM > > > > > > To: edk2-devel@lists.01.org > > > > > > Cc: Ard Biesheuvel ; Achin Gupta > > > > > > ; Supreeth Venkatesh > > > > > > ; Yao, Jiewen > > ; > > > > > > Leif Lindholm ; Jagadeesh Ujja > > > > > > > > > > > > Subject: [PATCH 10/10] ArmPkg/MmCommunicationDxe: signal > > > > architected > > > > > > PI events into MM context > > > > > > > > > > > > PI defines a few architected events that have significance in t= he MM > > > > > > context as well as in the non-secure DXE context. So register n= otify > > > > > > handlers for these events, and relay them into the standalone M= M > > world. > > > > > > > > > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > > > > > Signed-off-by: Ard Biesheuvel > > > > > > --- > > > > > > ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.inf | > > 5 > > > > +++ > > > > > > ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.c | > > 47 > > > > > > +++++++++++++++++++- > > > > > > 2 files changed, 50 insertions(+), 2 deletions(-) > > > > > > > > > > > > diff --git > > > > a/ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.inf > > > > > > b/ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.inf > > > > > > index 88beafa39c05..8bf269270f9d 100644 > > > > > > --- a/ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.inf > > > > > > +++ > > b/ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.inf > > > > > > @@ -48,6 +48,11 @@ [LibraryClasses] > > > > > > [Protocols] > > > > > > gEfiMmCommunicationProtocolGuid ## > > PRODUCES > > > > > > > > > > > > +[Guids] > > > > > > + gEfiEndOfDxeEventGroupGuid > > > > > > + gEfiEventExitBootServicesGuid > > > > > > + gEfiEventReadyToBootGuid > > > > > > + > > > > > > [Pcd.common] > > > > > > gArmTokenSpaceGuid.PcdMmBufferBase > > > > > > gArmTokenSpaceGuid.PcdMmBufferSize > > > > > > diff --git > > > > a/ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.c > > > > > > b/ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.c > > > > > > index feb9fa9f4ead..3203cf801a19 100644 > > > > > > --- a/ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.c > > > > > > +++ b/ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.c > > > > > > @@ -265,6 +265,43 @@ GetMmCompatibility () > > > > > > return Status; > > > > > > } > > > > > > > > > > > > +STATIC EFI_GUID* CONST mGuidedEventGuid[] =3D { > > > > > > + &gEfiEndOfDxeEventGroupGuid, > > > > > > + &gEfiEventExitBootServicesGuid, > > > > > > + &gEfiEventReadyToBootGuid, > > > > > > +}; > > > > > > + > > > > > > +STATIC EFI_EVENT mGuidedEvent[ARRAY_SIZE > > (mGuidedEventGuid)]; > > > > > > + > > > > > > +/** > > > > > > + Event notification that is fired when GUIDed Event Group is > > signaled. > > > > > > + > > > > > > + @param Event The Event that is being > > > > processed, > > > > > > not used. > > > > > > + @param Context Event Context, not used. > > > > > > + > > > > > > +**/ > > > > > > +STATIC > > > > > > +VOID > > > > > > +EFIAPI > > > > > > +MmGuidedEventNotify ( > > > > > > + IN EFI_EVENT Event, > > > > > > + IN VOID *Context > > > > > > + ) > > > > > > +{ > > > > > > + EFI_MM_COMMUNICATE_HEADER Header; > > > > > > + UINTN Size; > > > > > > + > > > > > > + // > > > > > > + // Use Guid to initialize EFI_SMM_COMMUNICATE_HEADER > > structure > > > > > > + // > > > > > > + CopyGuid (&Header.HeaderGuid, Context); > > > > > > + Header.MessageLength =3D 1; > > > > > > + Header.Data[0] =3D 0; > > > > > > + > > > > > > + Size =3D sizeof (Header); > > > > > > + MmCommunicationCommunicate (&mMmCommunication, > > &Header, > > > > > > &Size); > > > > > > +} > > > > > > + > > > > > > /** > > > > > > The Entry Point for MM Communication > > > > > > > > > > > > @@ -287,6 +324,7 @@ MmCommunicationInitialize ( > > > > > > ) > > > > > > { > > > > > > EFI_STATUS Status; > > > > > > + UINTN Index; > > > > > > > > > > > > // Check if we can make the MM call > > > > > > Status =3D GetMmCompatibility (); > > > > > > @@ -351,8 +389,13 @@ MmCommunicationInitialize ( > > > > > > NULL, > > > > > > &mSetVirtualAddressMapEvent > > > > > > ); > > > > > > - if (Status =3D=3D EFI_SUCCESS) { > > > > > > - return Status; > > > > > > + ASSERT_EFI_ERROR (Status); > > > > > > + > > > > > > + for (Index =3D 0; Index < ARRAY_SIZE (mGuidedEventGuid); Ind= ex++) > > { > > > > > > + Status =3D gBS->CreateEventEx (EVT_NOTIFY_SIGNAL, > > > > TPL_CALLBACK, > > > > > > + MmGuidedEventNotify, > > > > mGuidedEventGuid[Index], > > > > > > + mGuidedEventGuid[Index], > > > > > > &mGuidedEvent[Index]); > > > > > > + ASSERT_EFI_ERROR (Status); > > > > > > } > > > > > > > > > > > > gBS->UninstallProtocolInterface ( > > > > > > -- > > > > > > 2.20.1 > > > > > > > > > _______________________________________________ > > > > edk2-devel mailing list > > > > edk2-devel@lists.01.org > > > > https://lists.01.org/mailman/listinfo/edk2-devel > > _______________________________________________ > > edk2-devel mailing list > > edk2-devel@lists.01.org > > https://lists.01.org/mailman/listinfo/edk2-devel > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel > > Please consider the environment before printing this email. > > The information contained in this message may be confidential and proprie= tary to American Megatrends, Inc. This communication is intended to be rea= d only by the individual or entity to whom it is addressed or by their desi= gnee. If the reader of this message is not the intended recipient, you are = on notice that any distribution of this message, in any form, is strictly p= rohibited. Please promptly notify the sender by reply e-mail or by telepho= ne at 770-246-8600, and then delete or destroy all copies of the transmissi= on.