From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65])
 by mx.groups.io with SMTP id smtpd.web09.1890.1576060832766252506
 for <devel@edk2.groups.io>;
 Wed, 11 Dec 2019 02:40:33 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@linaro.org header.s=google header.b=A2Pb653Q;
 spf=pass (domain: linaro.org, ip: 209.85.221.65, mailfrom: ard.biesheuvel@linaro.org)
Received: by mail-wr1-f65.google.com with SMTP id z7so23356860wrl.13
        for <devel@edk2.groups.io>; Wed, 11 Dec 2019 02:40:32 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=3EGAbMl+sdMXo76dI8jwjTN5iQ35Y1bbPfsBhXUBy08=;
        b=A2Pb653QSHSoE1KmW34GP4KqWcZiE2s7caBd/6EvI/76PGj6lmjdW/qoZtNEQMrwnE
         nKt2+Q22kVcDhvA2+CyCKhflNvVOFGcf1BLy4G0mRz8vil5EZLOz9hyJFU0Hqjk0S2Dk
         nhYzqSEWZibDApymNB3i2/4H8nsIn9DxKvxA82tiQA9A74GsDgDM6oiFHPUFXoYI2mJJ
         kXn4JBZFwWiOBsFVWKgwzWhS1JU5oh1aP2j9SrGQgtChL8Kuq4JQgycyriNDo0gcixkJ
         yg8I1eC1y1Je7mjmeO/bNdZgAwSe16cHbe5EurvwJqzjeHyHDvLPkiUxGd9TsRz0+Umt
         Qikw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=3EGAbMl+sdMXo76dI8jwjTN5iQ35Y1bbPfsBhXUBy08=;
        b=UmrzbkNx1D7P2bpy6LUYWN77UQ7kB5YBRlsCmypIXGIGHfL+3lfsbbXukZCSN8mjFP
         G+l1AFwM4Coy5DXZ7IhSupVVAB51kQRqi1tEp8/gphOMlC8DsYnxqjJLmqgmWPhXnDuH
         iH37WdqMyxASwAQXmXPXJbcVKEwDBE5eadbvvUFENB0VXf8M1I6t4uGySr24hKLa+FfS
         Mqoe//67IQMnOT4YyJKh6iaIVkTDojmilIhxUgVeVI3DWMw96i+cQuhaMMiLwpZG+bgV
         4C+H6H/WQJLqv3vZN2QmepDchdXBp0vqB66TsE7OULHpY0XPam7FHvVkVitJ+Zqy4Lde
         nwfQ==
X-Gm-Message-State: APjAAAWYF7Z5MCmP09de6I8WylT4s5a5TkdfDRfPUEpLA6crqNdhU+Ty
	mOW/O/UzDruH2b4JsBrghLN7Vy0kuuVn8J3k+YeYmg==
X-Google-Smtp-Source: APXvYqxtrmjtwjdIxZEPMYSN9a/+d7DSXiFLunh8NWrze+c6U1ljOTQTRW0AXDtAE4zFG6gRzzHQBk+jWA7UyKfmCeE=
X-Received: by 2002:adf:cf0a:: with SMTP id o10mr2856577wrj.325.1576060831353;
 Wed, 11 Dec 2019 02:40:31 -0800 (PST)
MIME-Version: 1.0
References: <20191206143128.19371-1-ard.biesheuvel@linaro.org>
 <20191206143128.19371-3-ard.biesheuvel@linaro.org> <8d49cca6-b1b9-cddc-0590-4e4a84643e4f@redhat.com>
 <CAKv+Gu_vbyLf_Ykdeg7w275OP7ZHXK-yDKzxa3iOD=ocT0JpYA@mail.gmail.com>
 <734D49CCEBEEF84792F5B80ED585239D5C39604F@SHSMSX104.ccr.corp.intel.com> <CAKv+Gu9DfdzT2vHFQvi4UibXHYN0ZoGnU5dJdnw-R-KpZO9MzQ@mail.gmail.com>
In-Reply-To: <CAKv+Gu9DfdzT2vHFQvi4UibXHYN0ZoGnU5dJdnw-R-KpZO9MzQ@mail.gmail.com>
From: "Ard Biesheuvel" <ard.biesheuvel@linaro.org>
Date: Wed, 11 Dec 2019 10:40:29 +0000
Message-ID: <CAKv+Gu_6vsPmtzrDGH0aBDMhH1tExvjJbjoFVx_HFxsa1B=Yhg@mail.gmail.com>
Subject: Re: [RFC PATCH 2/2] MdeModulePkg/BdsDxe: allow consoles on drivers loaded via Driver####
To: "Ni, Ray" <ray.ni@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>, edk2-devel-groups-io <devel@edk2.groups.io>, 
	Leif Lindholm <leif.lindholm@linaro.org>, "Gao, Zhichao" <zhichao.gao@intel.com>, 
	"Ma, Maurice" <maurice.ma@intel.com>, "Dong, Guo" <guo.dong@intel.com>, 
	"You, Benjamin" <benjamin.you@intel.com>
Content-Type: text/plain; charset="UTF-8"

On Mon, 9 Dec 2019 at 09:42, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote:
>
> On Mon, 9 Dec 2019 at 03:12, Ni, Ray <ray.ni@intel.com> wrote:
> >
> > > Exactly. This flow is identical to how option ROMs are processed if
> > > they are discovered before EndOfDxe signalling completes (which is why
> > > the Juno platform was broken without the call to
> > > EfiBootManagerDispatchDeferredImages() in
> > > PlatformBootManagerBeforeConsole())
> > >
> >
> > Ard,
> > I checked ArmPkg's PlatformBootManagerLib and found it doesn't
> > call *DispatchDeferredImages() after signaling EndOfDxe.
> >
>
> It does. We just added this in 0f9395d7c5cc6ae2beaa2d87008fe158d04a8069
>
> > The deferred image dispatch mechanism assumes the platform
> > needs to call the *DispatchDeferredImages() after signaling EndOfDxe.
> >
>
> Indeed.
>
> > I don't understand why the deferred image can be loaded with your patch.
> > They are still deferred because the loading time is before EndOfDxe.
> >
>
> Yes, but because PlatformBootManagerBeforeConsole () does all of this,
> the only way to get Driver#### to work for consoles on GOP drivers, we
> need to move it before that call.

Any further comments on this patch?