From: "Ard Biesheuvel" <ard.biesheuvel@linaro.org>
To: edk2-devel-groups-io <devel@edk2.groups.io>
Cc: Maurice Ma <maurice.ma@intel.com>,
"Dong, Guo" <guo.dong@intel.com>,
Benjamin You <benjamin.you@intel.com>,
"Ni, Ray" <ray.ni@intel.com>,
"Gao, Liming" <liming.gao@intel.com>,
"Wu, Hao A" <hao.a.wu@intel.com>,
Laszlo Ersek <lersek@redhat.com>
Subject: Re: [PATCH 1/5] MdeModulePkg: remove EnterS3WithImmediateWake () from ResetSystemLib
Date: Wed, 8 Jan 2020 19:51:02 +0100 [thread overview]
Message-ID: <CAKv+Gu_79P7UAu-PKLd2SePeoaVU_dB-w2g6HZOeG4syg+DoMQ@mail.gmail.com> (raw)
In-Reply-To: <20200106151310.12322-2-ard.biesheuvel@linaro.org>
On Mon, 6 Jan 2020 at 16:13, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote:
>
> EnterS3WithImmediateWake () no longer has any callers, so remove it
> from ResetSystemLib.
>
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Ping?
> ---
> MdeModulePkg/Include/Library/ResetSystemLib.h | 11 -----------
> MdeModulePkg/Library/BaseResetSystemLibNull/BaseResetSystemLibNull.c | 14 --------------
> MdeModulePkg/Library/DxeResetSystemLib/DxeResetSystemLib.c | 13 -------------
> MdeModulePkg/Library/PeiResetSystemLib/PeiResetSystemLib.c | 13 -------------
> MdeModulePkg/Library/RuntimeResetSystemLib/RuntimeResetSystemLib.c | 13 -------------
> 5 files changed, 64 deletions(-)
>
> diff --git a/MdeModulePkg/Include/Library/ResetSystemLib.h b/MdeModulePkg/Include/Library/ResetSystemLib.h
> index 3b2a098a6082..09ee14540c44 100644
> --- a/MdeModulePkg/Include/Library/ResetSystemLib.h
> +++ b/MdeModulePkg/Include/Library/ResetSystemLib.h
> @@ -51,17 +51,6 @@ ResetShutdown (
> VOID
> );
>
> -/**
> - This function causes the system to enter S3 and then wake up immediately.
> -
> - If this function returns, it means that the system does not support S3 feature.
> -**/
> -VOID
> -EFIAPI
> -EnterS3WithImmediateWake (
> - VOID
> - );
> -
> /**
> This function causes a systemwide reset. The exact type of the reset is
> defined by the EFI_GUID that follows the Null-terminated Unicode string passed
> diff --git a/MdeModulePkg/Library/BaseResetSystemLibNull/BaseResetSystemLibNull.c b/MdeModulePkg/Library/BaseResetSystemLibNull/BaseResetSystemLibNull.c
> index 8d4c1028e603..33a896bee054 100644
> --- a/MdeModulePkg/Library/BaseResetSystemLibNull/BaseResetSystemLibNull.c
> +++ b/MdeModulePkg/Library/BaseResetSystemLibNull/BaseResetSystemLibNull.c
> @@ -58,20 +58,6 @@ ResetShutdown (
> ASSERT (FALSE);
> }
>
> -/**
> - This function causes the system to enter S3 and then wake up immediately.
> -
> - If this function returns, it means that the system does not support S3 feature.
> -**/
> -VOID
> -EFIAPI
> -EnterS3WithImmediateWake (
> - VOID
> - )
> -{
> - ASSERT (FALSE);
> -}
> -
> /**
> This function causes a systemwide reset. The exact type of the reset is
> defined by the EFI_GUID that follows the Null-terminated Unicode string passed
> diff --git a/MdeModulePkg/Library/DxeResetSystemLib/DxeResetSystemLib.c b/MdeModulePkg/Library/DxeResetSystemLib/DxeResetSystemLib.c
> index a85b6cd9a615..47b814fe8dee 100644
> --- a/MdeModulePkg/Library/DxeResetSystemLib/DxeResetSystemLib.c
> +++ b/MdeModulePkg/Library/DxeResetSystemLib/DxeResetSystemLib.c
> @@ -57,19 +57,6 @@ ResetShutdown (
> gRT->ResetSystem (EfiResetShutdown, EFI_SUCCESS, 0, NULL);
> }
>
> -/**
> - This function causes the system to enter S3 and then wake up immediately.
> -
> - If this function returns, it means that the system does not support S3 feature.
> -**/
> -VOID
> -EFIAPI
> -EnterS3WithImmediateWake (
> - VOID
> - )
> -{
> -}
> -
> /**
> This function causes a systemwide reset. The exact type of the reset is
> defined by the EFI_GUID that follows the Null-terminated Unicode string passed
> diff --git a/MdeModulePkg/Library/PeiResetSystemLib/PeiResetSystemLib.c b/MdeModulePkg/Library/PeiResetSystemLib/PeiResetSystemLib.c
> index 50297129b7c8..6c8c770ca375 100644
> --- a/MdeModulePkg/Library/PeiResetSystemLib/PeiResetSystemLib.c
> +++ b/MdeModulePkg/Library/PeiResetSystemLib/PeiResetSystemLib.c
> @@ -57,19 +57,6 @@ ResetShutdown (
> PeiServicesResetSystem2 (EfiResetShutdown, EFI_SUCCESS, 0, NULL);
> }
>
> -/**
> - This function causes the system to enter S3 and then wake up immediately.
> -
> - If this function returns, it means that the system does not support S3 feature.
> -**/
> -VOID
> -EFIAPI
> -EnterS3WithImmediateWake (
> - VOID
> - )
> -{
> -}
> -
> /**
> This function causes a systemwide reset. The exact type of the reset is
> defined by the EFI_GUID that follows the Null-terminated Unicode string passed
> diff --git a/MdeModulePkg/Library/RuntimeResetSystemLib/RuntimeResetSystemLib.c b/MdeModulePkg/Library/RuntimeResetSystemLib/RuntimeResetSystemLib.c
> index 29b3f7ebd871..f4490180ccf9 100644
> --- a/MdeModulePkg/Library/RuntimeResetSystemLib/RuntimeResetSystemLib.c
> +++ b/MdeModulePkg/Library/RuntimeResetSystemLib/RuntimeResetSystemLib.c
> @@ -62,19 +62,6 @@ ResetShutdown (
> mInternalRT->ResetSystem (EfiResetShutdown, EFI_SUCCESS, 0, NULL);
> }
>
> -/**
> - This function causes the system to enter S3 and then wake up immediately.
> -
> - If this function returns, it means that the system does not support S3 feature.
> -**/
> -VOID
> -EFIAPI
> -EnterS3WithImmediateWake (
> - VOID
> - )
> -{
> -}
> -
> /**
> This function causes a systemwide reset. The exact type of the reset is
> defined by the EFI_GUID that follows the Null-terminated Unicode string passed
> --
> 2.20.1
>
next prev parent reply other threads:[~2020-01-08 18:51 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-06 15:13 [PATCH 0/5] remove EnterS3WithImmediateWake () from ResetSystemLib Ard Biesheuvel
2020-01-06 15:13 ` [PATCH 1/5] MdeModulePkg: " Ard Biesheuvel
2020-01-08 18:51 ` Ard Biesheuvel [this message]
2020-01-09 12:56 ` Laszlo Ersek
2020-01-10 1:21 ` Ni, Ray
2020-01-10 6:46 ` Ard Biesheuvel
2020-01-06 15:13 ` [PATCH 2/5] PcAtChipsetPkg: " Ard Biesheuvel
2020-01-06 15:13 ` [PATCH 3/5] UefiPayloadPkg: " Ard Biesheuvel
2020-01-07 16:32 ` Guo Dong
2020-01-06 15:13 ` [PATCH 4/5] OvmfPkg: " Ard Biesheuvel
2020-01-06 16:29 ` Laszlo Ersek
2020-01-06 15:13 ` [PATCH 5/5] ArmVirtPkg: " Ard Biesheuvel
2020-01-06 16:29 ` Laszlo Ersek
2020-01-07 2:05 ` [PATCH 0/5] " Ni, Ray
2020-01-10 7:56 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKv+Gu_79P7UAu-PKLd2SePeoaVU_dB-w2g6HZOeG4syg+DoMQ@mail.gmail.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox