From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by mx.groups.io with SMTP id smtpd.web12.559.1578509475440858877 for ; Wed, 08 Jan 2020 10:51:15 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=TTGCfTaV; spf=pass (domain: linaro.org, ip: 209.85.128.68, mailfrom: ard.biesheuvel@linaro.org) Received: by mail-wm1-f68.google.com with SMTP id f129so20945wmf.2 for ; Wed, 08 Jan 2020 10:51:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=v9M8YIBKPjuFaDV5UQ8TB2dFQ4iXt/mNWIp+Vmcp3ew=; b=TTGCfTaVQV6GFXPYCDanu8miVx8Su5f4Q7SEM4e6JVA4dNY8+D7/fhxtIN9ITnwkQ1 ZwNo1Gnejb+A79AQzGeIRZYZT+Lfn26sjm6iXiVtVcoDOtVSlhdDSw/XurnnwCTTDrDB crSvmpE3gVZPO5KeTKu62NsVoK0/ry6Mm9CATIFPy9r3Z5fhaejRAZlQywDn8kRyR8Lu 9x1qXbgkqEWVX1EC9VDom+WCOI1ehO4i0UvSrSdpZm5PJfFinY4K5DKU6By4Y65cangz 2JTNCk8j6kOU+WhhIzWPs29944dnsEoi5brUEiX0oP2Z9pncXFfoir3qFRiwZgBu0zZY Ws9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=v9M8YIBKPjuFaDV5UQ8TB2dFQ4iXt/mNWIp+Vmcp3ew=; b=Q+B/gE/O653c9M84gZUygCnXPhs584IbwiWKTraehS4sfioOAzRMW+2MDcw9DTGyHp Nd1Ou5mZRie0WHmmcCWD84JBzya3X2b5tB4cECxdSgbnvGN+AfDgWnTW5zNZS5FNqf1+ uR//8ML4JDdbY2ib6Ohr6kmQE3G/FO/6p83w3q8jBDE0N8qLOz4WWWqYWL16Laoylo1K MzWM0+728NYAHFVw960ej9x4gnkM9GoiLUh57h/CJxe9o4HV+bd1SMzdClHt4R987gfI pzo6tdByHx4wXc3Oru/iLLmH/RAPdNloMRyBSubATv3DA3EHt/J9dubVs3+hiAJGkTdJ goVw== X-Gm-Message-State: APjAAAXZ7z3di6TmbslVKT3/RZPtSkmjz6Psdff2irRP/lBcZclccgRK Pin9VRKSZD+PlRqs1X0r7ll92gJKDJ4YhkZnk9ZneTQZBDI= X-Google-Smtp-Source: APXvYqw4W0r0w8wi9RVgZ8LATBeKCspXRlOo+jfcBjAHIpA+w18XdZsC6pjwssvyUXFUaNRSMd9L2cFDf9nuHmdDW8s= X-Received: by 2002:a1c:7901:: with SMTP id l1mr10552wme.67.1578509473579; Wed, 08 Jan 2020 10:51:13 -0800 (PST) MIME-Version: 1.0 References: <20200106151310.12322-1-ard.biesheuvel@linaro.org> <20200106151310.12322-2-ard.biesheuvel@linaro.org> In-Reply-To: <20200106151310.12322-2-ard.biesheuvel@linaro.org> From: "Ard Biesheuvel" Date: Wed, 8 Jan 2020 19:51:02 +0100 Message-ID: Subject: Re: [PATCH 1/5] MdeModulePkg: remove EnterS3WithImmediateWake () from ResetSystemLib To: edk2-devel-groups-io Cc: Maurice Ma , "Dong, Guo" , Benjamin You , "Ni, Ray" , "Gao, Liming" , "Wu, Hao A" , Laszlo Ersek Content-Type: text/plain; charset="UTF-8" On Mon, 6 Jan 2020 at 16:13, Ard Biesheuvel wrote: > > EnterS3WithImmediateWake () no longer has any callers, so remove it > from ResetSystemLib. > > Signed-off-by: Ard Biesheuvel Ping? > --- > MdeModulePkg/Include/Library/ResetSystemLib.h | 11 ----------- > MdeModulePkg/Library/BaseResetSystemLibNull/BaseResetSystemLibNull.c | 14 -------------- > MdeModulePkg/Library/DxeResetSystemLib/DxeResetSystemLib.c | 13 ------------- > MdeModulePkg/Library/PeiResetSystemLib/PeiResetSystemLib.c | 13 ------------- > MdeModulePkg/Library/RuntimeResetSystemLib/RuntimeResetSystemLib.c | 13 ------------- > 5 files changed, 64 deletions(-) > > diff --git a/MdeModulePkg/Include/Library/ResetSystemLib.h b/MdeModulePkg/Include/Library/ResetSystemLib.h > index 3b2a098a6082..09ee14540c44 100644 > --- a/MdeModulePkg/Include/Library/ResetSystemLib.h > +++ b/MdeModulePkg/Include/Library/ResetSystemLib.h > @@ -51,17 +51,6 @@ ResetShutdown ( > VOID > ); > > -/** > - This function causes the system to enter S3 and then wake up immediately. > - > - If this function returns, it means that the system does not support S3 feature. > -**/ > -VOID > -EFIAPI > -EnterS3WithImmediateWake ( > - VOID > - ); > - > /** > This function causes a systemwide reset. The exact type of the reset is > defined by the EFI_GUID that follows the Null-terminated Unicode string passed > diff --git a/MdeModulePkg/Library/BaseResetSystemLibNull/BaseResetSystemLibNull.c b/MdeModulePkg/Library/BaseResetSystemLibNull/BaseResetSystemLibNull.c > index 8d4c1028e603..33a896bee054 100644 > --- a/MdeModulePkg/Library/BaseResetSystemLibNull/BaseResetSystemLibNull.c > +++ b/MdeModulePkg/Library/BaseResetSystemLibNull/BaseResetSystemLibNull.c > @@ -58,20 +58,6 @@ ResetShutdown ( > ASSERT (FALSE); > } > > -/** > - This function causes the system to enter S3 and then wake up immediately. > - > - If this function returns, it means that the system does not support S3 feature. > -**/ > -VOID > -EFIAPI > -EnterS3WithImmediateWake ( > - VOID > - ) > -{ > - ASSERT (FALSE); > -} > - > /** > This function causes a systemwide reset. The exact type of the reset is > defined by the EFI_GUID that follows the Null-terminated Unicode string passed > diff --git a/MdeModulePkg/Library/DxeResetSystemLib/DxeResetSystemLib.c b/MdeModulePkg/Library/DxeResetSystemLib/DxeResetSystemLib.c > index a85b6cd9a615..47b814fe8dee 100644 > --- a/MdeModulePkg/Library/DxeResetSystemLib/DxeResetSystemLib.c > +++ b/MdeModulePkg/Library/DxeResetSystemLib/DxeResetSystemLib.c > @@ -57,19 +57,6 @@ ResetShutdown ( > gRT->ResetSystem (EfiResetShutdown, EFI_SUCCESS, 0, NULL); > } > > -/** > - This function causes the system to enter S3 and then wake up immediately. > - > - If this function returns, it means that the system does not support S3 feature. > -**/ > -VOID > -EFIAPI > -EnterS3WithImmediateWake ( > - VOID > - ) > -{ > -} > - > /** > This function causes a systemwide reset. The exact type of the reset is > defined by the EFI_GUID that follows the Null-terminated Unicode string passed > diff --git a/MdeModulePkg/Library/PeiResetSystemLib/PeiResetSystemLib.c b/MdeModulePkg/Library/PeiResetSystemLib/PeiResetSystemLib.c > index 50297129b7c8..6c8c770ca375 100644 > --- a/MdeModulePkg/Library/PeiResetSystemLib/PeiResetSystemLib.c > +++ b/MdeModulePkg/Library/PeiResetSystemLib/PeiResetSystemLib.c > @@ -57,19 +57,6 @@ ResetShutdown ( > PeiServicesResetSystem2 (EfiResetShutdown, EFI_SUCCESS, 0, NULL); > } > > -/** > - This function causes the system to enter S3 and then wake up immediately. > - > - If this function returns, it means that the system does not support S3 feature. > -**/ > -VOID > -EFIAPI > -EnterS3WithImmediateWake ( > - VOID > - ) > -{ > -} > - > /** > This function causes a systemwide reset. The exact type of the reset is > defined by the EFI_GUID that follows the Null-terminated Unicode string passed > diff --git a/MdeModulePkg/Library/RuntimeResetSystemLib/RuntimeResetSystemLib.c b/MdeModulePkg/Library/RuntimeResetSystemLib/RuntimeResetSystemLib.c > index 29b3f7ebd871..f4490180ccf9 100644 > --- a/MdeModulePkg/Library/RuntimeResetSystemLib/RuntimeResetSystemLib.c > +++ b/MdeModulePkg/Library/RuntimeResetSystemLib/RuntimeResetSystemLib.c > @@ -62,19 +62,6 @@ ResetShutdown ( > mInternalRT->ResetSystem (EfiResetShutdown, EFI_SUCCESS, 0, NULL); > } > > -/** > - This function causes the system to enter S3 and then wake up immediately. > - > - If this function returns, it means that the system does not support S3 feature. > -**/ > -VOID > -EFIAPI > -EnterS3WithImmediateWake ( > - VOID > - ) > -{ > -} > - > /** > This function causes a systemwide reset. The exact type of the reset is > defined by the EFI_GUID that follows the Null-terminated Unicode string passed > -- > 2.20.1 >