From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) by mx.groups.io with SMTP id smtpd.web10.5892.1587111333728012277 for ; Fri, 17 Apr 2020 01:15:34 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=VFhHvnNm; spf=pass (domain: linaro.org, ip: 209.85.128.44, mailfrom: ard.biesheuvel@linaro.org) Received: by mail-wm1-f44.google.com with SMTP id x25so2008078wmc.0 for ; Fri, 17 Apr 2020 01:15:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=RIJXkUnxkW/iiYgzbn74hLAs3A1UcDLxqlrwhXq/6fk=; b=VFhHvnNmqYAcUSgUr8RZJDvG7wpVGFep7wt4eDQktkgnnukyyy0u7bEn35p8/Ve+m4 S1nLdtvkREyuNAmNwzpowYeuO6H1Eai1RIHY6IhqKdS58ZeTHGuIC3HHrb3xs/PJqSUS WhSDzh8i9GLd62rAsWvW1CiVK9zNlLK4NVYshi2vBuDLK/hCSCmUbyR76odCz2I3TnAd aO8C3CwWwiEVbNSb/Z38FBkmWbh0r6Tgq0PgKh532SlXlN2NHy7JEzRj+QLC2ozC9Rl8 ngM4BllgSzR2Lu5ZGAkECdAwaKdU44Lp3ZNpX8ICF5Cc8aVh2R+okseqyRuSBoNsujjm Ct+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=RIJXkUnxkW/iiYgzbn74hLAs3A1UcDLxqlrwhXq/6fk=; b=rEbLx2wVyiNtlVhJ3lhTDHcKru8DtEr0zwDILLOAEoIUC1QRQgOzf9NQye4R85hoBN rtzfLkk3CoASOMdU3ZkQHCkRdNHsEtrsB1bf3es6klTiKHHdNYtdguYYJb7ierzNZkgk +L5WhR+6/4g8+28lB1E2TMC+Ku7k3lU4lhCo0Y6I99cLye1uw3dwcMFoTJMs2xd024Sf 5kGCmWvjz5iGsi+0Co+S9jJ6j2Dn+2tV6mp0UtmEEKnn3H2zyK0z0iDpE6DHP/VS6OTk F9Ktpgng5n2icqV8y6Z0kjrUtVjfEh1xc4LDO1V3oOhUuupw7V2RtEoWUQH4vDn3Fyy5 4+3w== X-Gm-Message-State: AGi0PuY+qqOO3l1R9vEq4i0yCISPpJAuEjh2ISl0RMhA9D6bfidAdQFA 0U13jM382Xi08MeS1HEThvELMw3AnBvjQffFBsEKfg== X-Google-Smtp-Source: APiQypJwl0gsPxL2VdMxovVbMCTdjYtazRVXNjFyCXBHurjU4P9AlGjmIghnZuqb8MfXvRfBW87/Iqhg6U5OsKUuNI4= X-Received: by 2002:a1c:e906:: with SMTP id q6mr2054642wmc.62.1587111332278; Fri, 17 Apr 2020 01:15:32 -0700 (PDT) MIME-Version: 1.0 References: <03f18a49-6bd6-e753-e1bf-7e061d13f200@redhat.com> <14537.1585603662366515487@groups.io> <276d435b-4d94-0899-9710-1584d7baeb3c@redhat.com> <734D49CCEBEEF84792F5B80ED585239D5C4FC746@SHSMSX104.ccr.corp.intel.com> In-Reply-To: From: "Ard Biesheuvel" Date: Fri, 17 Apr 2020 10:15:21 +0200 Message-ID: Subject: Re: [edk2-devel] [PATCH] CryptoPkg/FltUsedLib: Add FltUsedLib for float. To: "Jiang, Guomin" , Ard Biesheuvel Cc: "devel@edk2.groups.io" , "Ni, Ray" , "Kinney, Michael D" , "lersek@redhat.com" , "macarl@microsoft.com" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, 14 Apr 2020 at 09:01, Jiang, Guomin wrote: > > Summarize current status: > > Problem Statement: > Openssl require _fltused to be defined as a constant anywhere floating po= int is used. > It may use float out of edk2 tree and need _fltused, for example, Microso= ft=E2=80=99s OnScreenKeyboard and UiToolKit. > > Current Proposal as below: > > Proposal 1: Add FltUsed.c into exist library > Detail: Add FltUsed.c into EntryPointLib(PEIM, DXE). > Recommend: Ard Biesheuvel > Approve: Laszlo Ersek lersek@redhat.com > Netual: Michael D Kinney > Benefit: Doesn=E2=80=99t need modify every .dsc description file. > Defection: I test that it will fail because of /GL option, the error show= fatal error LNK1237: during code generation, compiler introduced reference= to symbol '_fltused' defined in module 'UefiApplicationEntryPoint.lib(FltU= sed.obj)' compiled with /GL > Can you elaborate on this issue? What does /GL do, and why is it throwing this error?