From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-it0-x233.google.com (mail-it0-x233.google.com [IPv6:2607:f8b0:4001:c0b::233]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 2B1F1803ED for ; Wed, 22 Mar 2017 08:05:28 -0700 (PDT) Received: by mail-it0-x233.google.com with SMTP id y18so25898603itc.1 for ; Wed, 22 Mar 2017 08:05:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=0vxoTg95MetEqnyMHimCixwQbDRayNy7bkHkq7BVyn8=; b=CJm51FEFU/xxuIUzlG6NbGM3NsHfdwSjUb1Hs1UaDKd8Z5XBNhzjaipb8ERPm5ZYJU 17XjGmEkDj+LH7pzTOXqX/hl6iLocpGrAyqRbgOw4uJUQnbbNdtmRfR7y5i09kL0cOtD QVRwp2ervRs8epIMa1xznAG0NcGA6hdFQ+3wE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=0vxoTg95MetEqnyMHimCixwQbDRayNy7bkHkq7BVyn8=; b=TPVJJD6OeV9zn4c1z3Fg0HGE5WyMG6UjhMBzyrdWE6C7xWJu2q+ubfWfVbmghtuNMU 3JLqz1IOfeOqi0o5FAvzEXrYQK2iZZQp9T0GLQy/Yi3MzV035BDjpr6yZDaus2Au1F1X 8heu5HdWqLfzVCU4vNF+lAtnRj48sivc50R7tURuLzcraQsydulyYnkmHhoyN5trfAtt uJ5knNEQg8mVMpeN4raFOcptpe2MXCKWumwZGA7arsmNIEPRM7Khi8ZWZLcAOb0h8zMz y4aahPtBd0htsrRm30qoV3pLuHCNCab+fNdS6nChxAFouzvZY007xzEwCZD0sVQd/8T0 Ub9w== X-Gm-Message-State: AFeK/H1vHo8UhDG+WzUYTMSusLMq0/j3lnCjXiR8634eWeWPA0zIVBd6zH+TW730BVVK4oozyFot2TY8k9b7ZXSp X-Received: by 10.36.77.10 with SMTP id l10mr8186919itb.59.1490195127400; Wed, 22 Mar 2017 08:05:27 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.149.5 with HTTP; Wed, 22 Mar 2017 08:05:27 -0700 (PDT) In-Reply-To: <3bc52170-68cd-2049-b1ed-276661555cf3@redhat.com> References: <20170317204731.31488-1-lersek@redhat.com> <20170317204731.31488-10-lersek@redhat.com> <3bc52170-68cd-2049-b1ed-276661555cf3@redhat.com> From: Ard Biesheuvel Date: Wed, 22 Mar 2017 15:05:27 +0000 Message-ID: To: Laszlo Ersek Cc: edk2-devel-01 , Leif Lindholm Subject: Re: [PATCH v2 09/12] ArmVirtPkg: enable AcpiTableDxe and EFI_ACPI_TABLE_PROTOCOL dynamically X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Mar 2017 15:05:28 -0000 Content-Type: text/plain; charset=UTF-8 On 22 March 2017 at 14:54, Laszlo Ersek wrote: > On 03/22/17 15:16, Ard Biesheuvel wrote: >> On 17 March 2017 at 20:47, Laszlo Ersek wrote: >>> In this patch, AcpiTableDxe, and the dependent (platform-matching) ACPI >>> table producing DXE drivers are built for 32-bit as well, >> >> Why is this? > > Purely for uniformity's sake. I wanted to avoid a situation where part > of the restrictions is coded up in the DSC/FDF files, and another part > in the dynamic decision code. I moved all of the thinking into the > dynamic code, and that one will never enable ACPI for 32-bit (dynamically). > If it never enables ACPI for 32-bit, I really don't see the point of adding those drivers to the build. > If you disagree, I can rework it, but I maintain that it's going to be > more confusing that way. >