From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::143; helo=mail-it1-x143.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it1-x143.google.com (mail-it1-x143.google.com [IPv6:2607:f8b0:4864:20::143]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 4DA46211ADA3F for ; Wed, 9 Jan 2019 13:57:11 -0800 (PST) Received: by mail-it1-x143.google.com with SMTP id c9so13373062itj.1 for ; Wed, 09 Jan 2019 13:57:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=n9oCubrrvIdMSQPK/8aaHOaTw/qcgWj2lwGI3WBT5dQ=; b=T7/b3t3uvntc1fCYH2auMBLK+nRzPmHRyUsiCv9oOfNqDrdBd5uHiOhE052rmqsFhM OeKS187k/bt0NrC2GFMQYL+LMfjJvKydYie+Ax9TXzN5ZIFrkQiJidsgpPbT+59KjzB1 SfkBoG1KJ/onvxUXViOcLGdX5/RvvMhDdKIgA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=n9oCubrrvIdMSQPK/8aaHOaTw/qcgWj2lwGI3WBT5dQ=; b=JU2IwUZ55eCyA3dDd44YpgbkXS5BAfrFNV8xCJAHJX6W3zNQXPiHHepdzINDAP/WE7 AJigtQ3rrQxs6urY6nUAKJoYn/ZAGsTcxnbhxbsx17O2+hTED7EWm994Vak5KlZFKFfM uzeW4EahojfTbVHY75hk/UD3Mltr2plxxFSJVNyY8QS7AViAYhKbnfkgbQC+j7rkyrvz T94YFc7mslRcHwkalypEBPFwuYqyaE3C5So4HUMwohy3xgDRxLsWcrxrjil4I+QfLWMu IQDZAcSyI3YaVC6AIaa8lKBMRq9U4EmePz3N8yfkeJ8X1lKhYYeKDQDPq6PK2QJRmNrX UEGA== X-Gm-Message-State: AJcUuken92brmXk44vqDfyyVKEnfURI51nlXDtaCgFlzjjZRsGkKPFee JDAhSjCciSyiWWTEBgh2jXz4esDg/8EW5eoXrajFIQ== X-Google-Smtp-Source: ALg8bN4vO8s5ephQH7DCbGq6x+gtERnmBUiqUSmEQOPMkHBxFobMbJ15m44V4oGnWFiqStVr3o3uR6IYR7l74rskeM8= X-Received: by 2002:a24:710:: with SMTP id f16mr4752104itf.121.1547071029724; Wed, 09 Jan 2019 13:57:09 -0800 (PST) MIME-Version: 1.0 References: <20190103182825.32231-1-ard.biesheuvel@linaro.org> <1ece7e1e-26de-bf6b-55ea-b1e12bce3788@redhat.com> <0d229de3-623a-1062-1daf-cce5dec14824@redhat.com> In-Reply-To: <0d229de3-623a-1062-1daf-cce5dec14824@redhat.com> From: Ard Biesheuvel Date: Wed, 9 Jan 2019 22:56:58 +0100 Message-ID: To: Laszlo Ersek Cc: "edk2-devel@lists.01.org" , Leif Lindholm , Michael D Kinney , Liming Gao , Jian J Wang , Hao Wu , Jagadeesh Ujja , Achin Gupta , Thomas Panakamattam Abraham , Sami Mujawar Subject: Re: [PATCH 0/6] implement standalone MM versions of the variable runtime drivers X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jan 2019 21:57:11 -0000 Content-Type: text/plain; charset="UTF-8" On Wed, 9 Jan 2019 at 22:46, Laszlo Ersek wrote: > > On 01/09/19 16:04, Laszlo Ersek wrote: > > On 01/09/19 11:28, Ard Biesheuvel wrote: > >> In the mean time, the hunk below should suffice to complete your > >> regression testing. > > I used: > > > diff --git a/OvmfPkg/OvmfPkgIa32.dsc b/OvmfPkg/OvmfPkgIa32.dsc > > index 3f3533e5c163..908450eda174 100644 > > --- a/OvmfPkg/OvmfPkgIa32.dsc > > +++ b/OvmfPkg/OvmfPkgIa32.dsc > > @@ -386,6 +386,7 @@ [LibraryClasses.common.DXE_SMM_DRIVER] > > HobLib|MdePkg/Library/DxeHobLib/DxeHobLib.inf > > SmmMemLib|MdePkg/Library/SmmMemLib/SmmMemLib.inf > > SmmServicesTableLib|MdePkg/Library/SmmServicesTableLib/SmmServicesTableLib.inf > > + MmServicesTableLib|MdePkg/Library/MmServicesTableLib/MmServicesTableLib.inf > > !ifdef $(DEBUG_ON_SERIAL_PORT) > > DebugLib|MdePkg/Library/BaseDebugLibSerialPort/BaseDebugLibSerialPort.inf > > !else > > diff --git a/OvmfPkg/OvmfPkgIa32X64.dsc b/OvmfPkg/OvmfPkgIa32X64.dsc > > index 6c08b2728d63..14166e946a93 100644 > > --- a/OvmfPkg/OvmfPkgIa32X64.dsc > > +++ b/OvmfPkg/OvmfPkgIa32X64.dsc > > @@ -391,6 +391,7 @@ [LibraryClasses.common.DXE_SMM_DRIVER] > > HobLib|MdePkg/Library/DxeHobLib/DxeHobLib.inf > > SmmMemLib|MdePkg/Library/SmmMemLib/SmmMemLib.inf > > SmmServicesTableLib|MdePkg/Library/SmmServicesTableLib/SmmServicesTableLib.inf > > + MmServicesTableLib|MdePkg/Library/MmServicesTableLib/MmServicesTableLib.inf > > !ifdef $(DEBUG_ON_SERIAL_PORT) > > DebugLib|MdePkg/Library/BaseDebugLibSerialPort/BaseDebugLibSerialPort.inf > > !else > > diff --git a/OvmfPkg/OvmfPkgX64.dsc b/OvmfPkg/OvmfPkgX64.dsc > > index 4072c839d73f..0cd5f76cccd9 100644 > > --- a/OvmfPkg/OvmfPkgX64.dsc > > +++ b/OvmfPkg/OvmfPkgX64.dsc > > @@ -391,6 +391,7 @@ [LibraryClasses.common.DXE_SMM_DRIVER] > > HobLib|MdePkg/Library/DxeHobLib/DxeHobLib.inf > > SmmMemLib|MdePkg/Library/SmmMemLib/SmmMemLib.inf > > SmmServicesTableLib|MdePkg/Library/SmmServicesTableLib/SmmServicesTableLib.inf > > + MmServicesTableLib|MdePkg/Library/MmServicesTableLib/MmServicesTableLib.inf > > !ifdef $(DEBUG_ON_SERIAL_PORT) > > DebugLib|MdePkg/Library/BaseDebugLibSerialPort/BaseDebugLibSerialPort.inf > > !else > > On 01/09/19 16:04, Laszlo Ersek wrote: > > I'll be back with test results later. > > Regression-tested-by: Laszlo Ersek > Wonderful! Thanks a lot Laszlo