From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::142; helo=mail-it1-x142.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it1-x142.google.com (mail-it1-x142.google.com [IPv6:2607:f8b0:4864:20::142]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1378021A00AE6 for ; Tue, 27 Nov 2018 04:08:45 -0800 (PST) Received: by mail-it1-x142.google.com with SMTP id g85so33787347ita.3 for ; Tue, 27 Nov 2018 04:08:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=R9H/LuwggT+7eWl8IbqWi+bpioXVaocrHKHHF6CXIcs=; b=ERJN9V8F66DIyMUZBiDNMm+60AU8yJCLmt4A7l5215y9se+a2BmhGjowSgNwLXrAiJ qiNsHVGA8knbeaN/0UZJGZutKRU38DjYNpMl1Pz4Jg9vqHXXxRLQAvZB/v95/mqHYwse lzqmqwv02IFyDeIhGmoBv+w6cTQz/fxFy9uzg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=R9H/LuwggT+7eWl8IbqWi+bpioXVaocrHKHHF6CXIcs=; b=J13Xb+aoHmIiK1GtobYJFulXiK6n6gdr8k5dGLBGVXtKBRt1RzdpJqmmz5DqgQguVB 2gjR1OK8aXuMv1EDWkmhy5m2KRx3Z23pJNkQ9LgGhQEJ1+NB1b9KRSBXcWQvY05vsu6H 2XqmnICCVQuQWZwYuxWXkXsF2JONB7qkxmJvLQzRVZMR2o/9Wi+DWSElGWcoBmthwETa utvRFkzClJMeAM7XV0YJ/ob82AULWSBHSc3ZVY2JqHD4xSLgOHNyJZzV8oxkOhD8pu8W mZTx9Lafb3neEh+2B+xWobczULv0pYN66uHsP3jVNnNKnc/SYwfEgl2B4BsetxIS3f7D KQbw== X-Gm-Message-State: AGRZ1gL82SYwJKlD7Q2n0nN+wCN64ghY87fD04G98VYxo51QHY6DL0tR uIvMf+FtxqJFs5HgrfnkB3xTNBJlwgC5/9yycUFNkA== X-Google-Smtp-Source: AJdET5fH75MOqbEkjWysRweXjELwaLn9jxOxvIyGKg56GO3Ut7L8Cvx4Cq2o2dpVcL5gfium6PKhOzDPS4ffTW0IELs= X-Received: by 2002:a02:8449:: with SMTP id l9-v6mr28555694jah.130.1543320524860; Tue, 27 Nov 2018 04:08:44 -0800 (PST) MIME-Version: 1.0 References: <1543315437-17774-1-git-send-email-sughosh.ganu@arm.com> In-Reply-To: <1543315437-17774-1-git-send-email-sughosh.ganu@arm.com> From: Ard Biesheuvel Date: Tue, 27 Nov 2018 13:08:33 +0100 Message-ID: To: Sughosh Ganu Cc: "edk2-devel@lists.01.org" , Leif Lindholm , Achin Gupta Subject: Re: [PATCH v5 0/5] ArmPkg related changes for StandaloneMM package X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Nov 2018 12:08:46 -0000 Content-Type: text/plain; charset="UTF-8" On Tue, 27 Nov 2018 at 11:44, Sughosh Ganu wrote: > > > Changes since v4: > Based on comments from Ard > - Removed now superfluous call to FreePages from MmCommunication.c > - Removed Chipset/AArch64.h header file from ArmMmuStandaloneMmLib.c > > Changes since v3: > Based on review comments from Ard, moved the MMU attribute changing > functions for StandaloneMM image into a new library class. > > Moved the addition of memory space used as a MM_COMMUNICATE buffer to > memory type 'EfiGcdMemoryTypeReserved' and removed the call to > AllocatgePages. > > Changes since v2: > Based on review comments from Ard, moved the memory attribute updation > changes out of DebugPeCoffExtraActionLib into an extra action library > added in StandaloneMM package. The patch for setting the memory > attributes, now under StandaloneMmPkg directory, will be submitted > separately from this series. > > Changes since v1: Handled review comments from Leif > > > Achin Gupta (4): > ArmPkg: Add PCDs needed for MM communication driver. > ArmPkg/Drivers: Add EFI_MM_COMMUNICATION_PROTOCOL DXE driver. > ArmPkg/Include: Add MM interface SVC return codes. > ArmPkg/ArmMmuLib: Add MMU Library suitable for use in S-EL0. > > Sughosh Ganu (1): > ArmPkg/Include: Fix the SPM version SVC ID > Reviewed-by: Ard Biesheuvel Pushed as 13d5d0a56e48..eed947be0b05 Thanks! I'm very happy we will finally have the pieces in place to implement UEFI secure boot on ARM in a sane way. > ArmPkg/ArmPkg.dec | 4 + > ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.inf | 56 +++ > ArmVirtPkg/Library/XenArmGenericTimerVirtCounterLib/XenArmGenericTimerVirtCounterLib.inf => ArmPkg/Library/StandaloneMmMmuLib/ArmMmuStandaloneMmLib.inf | 23 +- > ArmPkg/Drivers/MmCommunicationDxe/MmCommunicate.h | 28 ++ > ArmPkg/Include/IndustryStandard/ArmMmSvc.h | 9 +- > ArmPkg/Include/Library/{ArmMmuLib.h => StandaloneMmMmuLib.h} | 38 +- > ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.c | 372 ++++++++++++++++++++ > ArmPkg/Library/StandaloneMmMmuLib/Aarch64/ArmMmuStandaloneMmLib.c | 184 ++++++++++ > 8 files changed, 669 insertions(+), 45 deletions(-) > create mode 100644 ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.inf > copy ArmVirtPkg/Library/XenArmGenericTimerVirtCounterLib/XenArmGenericTimerVirtCounterLib.inf => ArmPkg/Library/StandaloneMmMmuLib/ArmMmuStandaloneMmLib.inf (56%) > create mode 100644 ArmPkg/Drivers/MmCommunicationDxe/MmCommunicate.h > copy ArmPkg/Include/Library/{ArmMmuLib.h => StandaloneMmMmuLib.h} (55%) > create mode 100644 ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.c > create mode 100644 ArmPkg/Library/StandaloneMmMmuLib/Aarch64/ArmMmuStandaloneMmLib.c > > -- > 2.7.4 > >