From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c06::235; helo=mail-io0-x235.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-io0-x235.google.com (mail-io0-x235.google.com [IPv6:2607:f8b0:4001:c06::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id DE8872063E318 for ; Thu, 3 May 2018 04:42:59 -0700 (PDT) Received: by mail-io0-x235.google.com with SMTP id z4-v6so21255515iof.5 for ; Thu, 03 May 2018 04:42:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=0mP5oV2qNQZs2r1tQGV0vkD09wolyWAoaN5yYURFDJY=; b=gWkBg8xey2htGdI1fYvV5JcpqeLiMc33oPTHDMszLNZvrn0oBDS011acdrnqGMSGni Zl5YrYqVyUOdGJHkbDJBLb3YONJELMqr5M3f8HBg7mLwYUuA+gHAzU1bLNby3370ggfy pBfNrX0cwzTzmjLd/0/iI4RUxJvsWUXfj1aqY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=0mP5oV2qNQZs2r1tQGV0vkD09wolyWAoaN5yYURFDJY=; b=JsboLAn7aXSOx29rUCjk/uCip/0suKn422aesHFxt+zDc6bfvm5GY8F9u9I91mEty6 6chzk83hR1JJfx2eS8GAo32val2GLTh18VDvFqE9ECj2vTzPXotNYgP6uvDmK31Wdff4 qxt+1Ah2E0nSJ36xCVuA6mIFQes6SoLNqBbi0/5nq9d5klIzJ3YboVkCd6bJRfmwOO0m qWh1///L6U+bbn+nVlnC5XjivluZA2mjvozY0QjAmNLITzJ1EcP24JlqMd6jgxmrU5CM SWuFwV89shJgLml31GDhag59HlOGQ8oICtSsoLVpuC04uMYxaztLAoaQ+99PJXiYJlxl 6NfA== X-Gm-Message-State: ALQs6tCnouFEPrL+3nQgUuI/wo70LE08b6lDwJFrzVCJYr5QhOSI7W1W vffbzh8B7F91MrkJ/G0XhcMP9um2cXi7mlJeB8nnWA== X-Google-Smtp-Source: AB8JxZpASxxv3KUTs1EHeYJDs2UjdNqHtHMuDbxbjob/QBwLVX3X8+ZT0C2Hi+c+sZMuSVJYdWIRqhGBHqRJyavvVV8= X-Received: by 2002:a6b:545:: with SMTP id 66-v6mr24512113iof.173.1525347778139; Thu, 03 May 2018 04:42:58 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.187.134 with HTTP; Thu, 3 May 2018 04:42:57 -0700 (PDT) In-Reply-To: <1525278402-43588-1-git-send-email-alexei.fedorov@arm.com> References: <1525278402-43588-1-git-send-email-alexei.fedorov@arm.com> From: Ard Biesheuvel Date: Thu, 3 May 2018 13:42:57 +0200 Message-ID: To: Alexei Fedorov Cc: "edk2-devel@lists.01.org" , Arvind Chauhan , Daniil Egranov , Thomas Panakamattam Abraham , Leif Lindholm , Matteo Carlini , Stephanie Hughes-Fitt , nd , Evan Lloyd Subject: Re: [PATCH edk2-platforms v1] Platform/ARM: Correct GIC naming X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 May 2018 11:43:00 -0000 Content-Type: text/plain; charset="UTF-8" On 2 May 2018 at 18:26, Alexei Fedorov wrote: > From: Alexei Fedorov > > ARM Generic Interrupt Controller is incorrectly named as > "ARM General Interrupt Controller" in ArmJuno.dsc, > ArmVExpress-CTA15-A7.dsc and ArmVExpress-FVP-AArch64.dsc. > > This patch corrects the comment by changing "General" to "Generic". > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Alexei Fedorov > Reviewed-by: Evan Lloyd > --- > All the changes can be reviewed at: > https://github.com/AlexeiFedorov/edk2-platforms/tree/261_correct_gic_naming_v1 > > Notes: > v1: > - Change ARM "General" Interrupt Controller to "Generic" [Alexei] > Hello Alexei, > Platform/ARM/JunoPkg/ArmJuno.dsc | 2 +- > Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.dsc | 4 ++-- Care to update the second instance in this file as well? And while you're at it, care to update the other platforms too? $ git grep -i 'arm general interrupt' Platform/AMD/OverdriveBoard/OverdriveBoard.dsc: # ARM General Interrupt Controller Platform/ARM/JunoPkg/ArmJuno.dsc: # ARM General Interrupt Controller Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.dsc: # ARM General Interrupt Driver in Secure and Non-secure Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.dsc: # ARM General Interrupt Controller Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc: # ARM General Interrupt Controller Platform/Comcast/RDKQemu/RDKQemu.dsc: # ARM General Interrupt Controller Platform/Hisilicon/HiKey/HiKey.dsc: # ARM General Interrupt Controller Platform/Hisilicon/HiKey960/HiKey960.dsc: # ARM General Interrupt Controller Platform/LeMaker/CelloBoard/CelloBoard.dsc: # ARM General Interrupt Controller Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc: # ARM General Interrupt Controller Thanks, Ard. > Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc | 2 +- > 3 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/Platform/ARM/JunoPkg/ArmJuno.dsc b/Platform/ARM/JunoPkg/ArmJuno.dsc > index 5ec563cefbcd9d97614dc9944bfaeb3822c4634d..8d6dd0207db5f16d7fcc0c5fd59fea38498f3034 100644 > --- a/Platform/ARM/JunoPkg/ArmJuno.dsc > +++ b/Platform/ARM/JunoPkg/ArmJuno.dsc > @@ -150,7 +150,7 @@ [PcdsFixedAtBuild.common] > gEmbeddedTokenSpaceGuid.PcdLan9118DefaultNegotiationTimeout|40000 > > # > - # ARM General Interrupt Controller > + # ARM Generic Interrupt Controller > # > gArmTokenSpaceGuid.PcdGicDistributorBase|0x2C010000 > gArmTokenSpaceGuid.PcdGicInterruptInterfaceBase|0x2C02F000 > diff --git a/Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.dsc b/Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.dsc > index ef737670126db980abcc0e0ac9b84321bfa97584..6405d955f15a87c8d7b379f8c05b43f3e0830c54 100644 > --- a/Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.dsc > +++ b/Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.dsc > @@ -1,5 +1,5 @@ > # > -# Copyright (c) 2012-2017, ARM Limited. All rights reserved. > +# Copyright (c) 2012-2018, ARM Limited. All rights reserved. > # Copyright (c) 2015, Intel Corporation. All rights reserved.
> # > # This program and the accompanying materials > @@ -156,7 +156,7 @@ [PcdsFixedAtBuild.common] > > > # > - # ARM General Interrupt Controller > + # ARM Generic Interrupt Controller > # > gArmTokenSpaceGuid.PcdGicDistributorBase|0x2C001000 > gArmTokenSpaceGuid.PcdGicInterruptInterfaceBase|0x2C002000 > diff --git a/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc b/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc > index 600bffb66703305f4a6baec930cd044998744c24..ca19fd65265a531e8c0869460aa9b6358b70bf91 100644 > --- a/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc > +++ b/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc > @@ -147,7 +147,7 @@ [PcdsFixedAtBuild.common] > gArmPlatformTokenSpaceGuid.PcdPL180MciBaseAddress|0x1C050000 > > # > - # ARM General Interrupt Controller > + # ARM Generic Interrupt Controller > # > gArmTokenSpaceGuid.PcdGicDistributorBase|0x2f000000 > gArmTokenSpaceGuid.PcdGicRedistributorsBase|0x2f100000 > -- > 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' > >