From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67])
 by mx.groups.io with SMTP id smtpd.web11.14978.1586363010649764176
 for <devel@edk2.groups.io>;
 Wed, 08 Apr 2020 09:23:31 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@linaro.org header.s=google header.b=GJiWBMXp;
 spf=pass (domain: linaro.org, ip: 209.85.221.67, mailfrom: ard.biesheuvel@linaro.org)
Received: by mail-wr1-f67.google.com with SMTP id c15so8497085wro.11
        for <devel@edk2.groups.io>; Wed, 08 Apr 2020 09:23:30 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=Nu50py1l1EbpyPbgDEbrEGOZcsHPAY/s/AF4Yaf5Wis=;
        b=GJiWBMXpgy67NbwpkzpqWYfzArwqmJd7nnNiKhiy184SC9LCQwGIFNuwSp+Yka9nNr
         Z/DZCEVhFDwMuMF+1g3oS6iEW8Q7m0iffCnH/PbeRhrsdqpeCqF0hTeQsaFC84wdjhEh
         rCiSxKoUlZQRTdtmuGUS90BsGvaxznZ7cFs/VeRdkfCeT4VlJWk/Ylvw3mDNXgJE4T7Y
         2R/QBssecTdjFIJvjU/Oe71J/zDWJolQPp8MOi7INpQsN88HLSBBFWqL9Plu+HDzDD2q
         XLp9IuTrbsSPkdp7T6ayQWyUgm0BFM4XjEbt8tPkwHGIfxmLvqlbLnyLID2cjbUZPI4J
         4qEQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=Nu50py1l1EbpyPbgDEbrEGOZcsHPAY/s/AF4Yaf5Wis=;
        b=fKlZzp0tZGHVrLyPuiwgcZpS9bKlRhq3pAfYifAgfgsmTUHgfSdPh3CG3Gcs1Madg8
         JJZ7w2azIis/YMrUc3inFArEdBlQYSMkjnGBG36zI2AVmjWjL0QCv40GsKaeZTDa2lsZ
         ulGn9BsPGT+ZUgjxkM79cUqduO3gFlGO+XsAXE+HmflgFFpOBsTHgiO1MLq29eC4m4Mf
         04gRH7IQ+YQUMErodREfC21XwOdMP5NCnNHky+Wpv+DGupuHLtsqGTYe4cP36yjHnBFJ
         bR++2zdmVutAhVP7jCLMeJ28FJHHTyKZYglCCnEBNBnPo6ZLqgV+hyyEeh1YE3lo1O1x
         pYRg==
X-Gm-Message-State: AGi0PubSUmCSXGgLu50oFIcrMl5PERpBYpF1Jegm5kzbFpd5eJcLlAmd
	0yJ+/PhQm7wp8PhZ8kX/2hm9KebBluMhsL/rM5FMlA==
X-Google-Smtp-Source: APiQypJ/Z17Vv+KGyEytbLWbPx8OrgnCki7EmCDt4dzkMCGZOvUPSKbzz4BjM+LVKVQD13JJ4cyunESTvJt9VrkZIcY=
X-Received: by 2002:a5d:604a:: with SMTP id j10mr9179149wrt.126.1586363009158;
 Wed, 08 Apr 2020 09:23:29 -0700 (PDT)
MIME-Version: 1.0
References: <20200325150236.13150-1-samer@elhajmahmoud.com> <a9c9f82f-ab52-2b1e-4980-b1d8279b0abb@akeo.ie>
In-Reply-To: <a9c9f82f-ab52-2b1e-4980-b1d8279b0abb@akeo.ie>
From: "Ard Biesheuvel" <ard.biesheuvel@linaro.org>
Date: Wed, 8 Apr 2020 18:23:18 +0200
Message-ID: <CAKv+Gu_B7GuQc4RyGH+Y4MM=JUhNcxSBhCruoAhx9P2GkAN5XQ@mail.gmail.com>
Subject: Re: [[edk2-platform][PATCH 1/1] Platform/RaspberryPi/RPi3: Enable HTTP Boot
To: Pete Batard <pete@akeo.ie>
Cc: Samer El-Haj-Mahmoud <samer@elhajmahmoud.com>, edk2-devel-groups-io <devel@edk2.groups.io>, 
	Leif Lindholm <leif@nuviainc.com>
Content-Type: text/plain; charset="UTF-8"

On Wed, 8 Apr 2020 at 12:04, Pete Batard <pete@akeo.ie> wrote:
>
> On 2020.03.25 15:02, Samer El-Haj-Mahmoud wrote:
> > Enable HTTP Boot (with and without TLS) on RPi3
> >
> > Cc: Leif Lindholm <leif@nuviainc.com>
> > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> > Cc: Pete Batard <pete@akeo.ie>
> > Signed-off-by: Samer El-Haj-Mahmoud <samer@elhajmahmoud.com>
> > ---
> >   Platform/RaspberryPi/RPi3/RPi3.dsc | 9 +++------
> >   1 file changed, 3 insertions(+), 6 deletions(-)
> >
> > diff --git a/Platform/RaspberryPi/RPi3/RPi3.dsc b/Platform/RaspberryPi/RPi3/RPi3.dsc
> > index 91d5738afbc6..960b1ac57ad3 100644
> > --- a/Platform/RaspberryPi/RPi3/RPi3.dsc
> > +++ b/Platform/RaspberryPi/RPi3/RPi3.dsc
> > @@ -25,12 +25,6 @@ [Defines]
> >     SKUID_IDENTIFIER               = DEFAULT
> >     FLASH_DEFINITION               = Platform/RaspberryPi/$(PLATFORM_NAME)/$(PLATFORM_NAME).fdf
> >
> > -  #
> > -  # Network definition
> > -  #
> > -  DEFINE NETWORK_TLS_ENABLE       = FALSE
> > -  DEFINE NETWORK_HTTP_BOOT_ENABLE = FALSE
> > -
> >     #
> >     # Defines for default states.  These can be changed on the command line.
> >     # -D FLAG=VALUE
> > @@ -123,6 +117,7 @@ [LibraryClasses.common]
> >     IntrinsicLib|CryptoPkg/Library/IntrinsicLib/IntrinsicLib.inf
> >     BaseCryptLib|CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf
> >     OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLib.inf
> > +  TlsLib|CryptoPkg/Library/TlsLib/TlsLib.inf
> >
> >     #
> >     # Uncomment (and comment out the next line) For RealView Debugger. The Standard IO window
> > @@ -329,6 +324,8 @@ [PcdsFixedAtBuild.common]
> >     gEfiSecurityPkgTokenSpaceGuid.PcdRemovableMediaImageVerificationPolicy|0x04
> >   !endif
> >
> > +  gEfiNetworkPkgTokenSpaceGuid.PcdAllowHttpConnections|TRUE
> > +
> >     gEmbeddedTokenSpaceGuid.PcdInterruptBaseAddress|0x40000000
> >     gArmTokenSpaceGuid.PcdArmArchTimerSecIntrNum|0x0
> >     gArmTokenSpaceGuid.PcdArmArchTimerIntrNum|0x1
> >
>
> Reviewed-by: Pete Batard <pete@akeo.ie>
>

Thanks

Pushed as b93aa851aab6..4a73a96931a5