From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-it0-x229.google.com (mail-it0-x229.google.com [IPv6:2607:f8b0:4001:c0b::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 4740D1A1F1E for ; Thu, 8 Sep 2016 02:40:00 -0700 (PDT) Received: by mail-it0-x229.google.com with SMTP id e124so245450735ith.0 for ; Thu, 08 Sep 2016 02:40:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=G7ZZqQ5l+iedqZjBS95FF0OMC3tVtAgpR0to+OuKKsQ=; b=cZTinublI5h+r3CNdw0bHvqfkH4I7szAkZFN+NnUiSHRcjbQd5rkCwuyFcjj7AQ8I8 lc6M9guXa9+iAqIeLvCqEDzCHJVj4Kh2Z/7+Iik3qx3AnqWIONgZ3UueE+6t4F6phYfx bZ0b9q0la+uL5tIoH504aoY7Zfhz4la4QxI7s= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=G7ZZqQ5l+iedqZjBS95FF0OMC3tVtAgpR0to+OuKKsQ=; b=bFMGAx44aWO5FdGNR0BomUM0zDsEAKJzI2FD6b08JO6he+e1sgEFjcuCokv9bKJLhW 0pDH7cDSv9jOOuDlcHJAFeYnYZFdfdpDka7se1JBqSVBnJMELn8yUb0Dw+dl8L02MCLh yRXJbazT2Noe7pNs6j0LY/h9trIECrEYLO9RJAg0yZqPAoZEZSBaboyLqmoYphZ5nfQk 8rd9v8WVi9DiKvWKcxCZjvnMRWyIE06AF1HnwoG3AwiXiwiUJwDg6rtxbYihGgEt0w9Y 6vzS1mJckXEc33AvG1bJueP/1f0zRen7yQf7Ezh3vpqROcuRjR0SBlQQineeJ10v3rMn leNg== X-Gm-Message-State: AE9vXwNTabQ6alj6pKs6lXQdOBgDD6lF30bGadCiZXJHEW+KuEDhWi4E4BaWU22KHEWgf1w4pHC5b2A825swQayy X-Received: by 10.36.57.215 with SMTP id l206mr14722763ita.5.1473327599590; Thu, 08 Sep 2016 02:39:59 -0700 (PDT) MIME-Version: 1.0 Received: by 10.36.204.195 with HTTP; Thu, 8 Sep 2016 02:39:59 -0700 (PDT) In-Reply-To: <1473231890-23205-1-git-send-email-ard.biesheuvel@linaro.org> References: <1473231890-23205-1-git-send-email-ard.biesheuvel@linaro.org> From: Ard Biesheuvel Date: Thu, 8 Sep 2016 10:39:59 +0100 Message-ID: To: edk2-devel-01 , Leif Lindholm Cc: "Oliyil Kunnil, Vishal" , Ard Biesheuvel Subject: Re: [PATCH] ArmPkg/ArmGicLib: use correct loop variable X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Sep 2016 09:40:00 -0000 Content-Type: text/plain; charset=UTF-8 On 7 September 2016 at 08:04, Ard Biesheuvel wrote: > The ArmGicLib API function GicGetCpuRedistributorBase () declares > GicCpuRedistributorBase to iterate over the redistributors of all > CPUs, but then inadvertently advances GicRedistributorBase instead. > > Reported-by: "Oliyil Kunnil, Vishal" > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ard Biesheuvel > --- > ArmPkg/Drivers/ArmGic/ArmGicLib.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/ArmPkg/Drivers/ArmGic/ArmGicLib.c b/ArmPkg/Drivers/ArmGic/ArmGicLib.c > index 73795ed4e56c..e658e9bff5d8 100644 > --- a/ArmPkg/Drivers/ArmGic/ArmGicLib.c > +++ b/ArmPkg/Drivers/ArmGic/ArmGicLib.c > @@ -76,7 +76,7 @@ GicGetCpuRedistributorBase ( > } > > // Move to the next GIC Redistributor frame > - GicRedistributorBase += GicRedistributorGranularity; > + GicCpuRedistributorBase += GicRedistributorGranularity; > } > > // The Redistributor has not been found for the current CPU > -- > 2.7.4 > Leif?