From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: "Gao, Liming" <liming.gao@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [Patch] BaseTools: Enable --whole-archive in GCC tool chain as the default option
Date: Mon, 28 Aug 2017 17:59:10 +0100 [thread overview]
Message-ID: <CAKv+Gu_BqsLebVUm539axgoqgmYYB+uOTPMjWB-m_Ox_ozsh9Q@mail.gmail.com> (raw)
In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14D78139F@shsmsx102.ccr.corp.intel.com>
On 28 August 2017 at 04:27, Gao, Liming <liming.gao@intel.com> wrote:
> Laszlo:
> I will update the patch with your comments.
>
> Ard:
> We collect the size impact in Ovmf platform. Its impact is small. So, my patch enable this option for all targets. Below is the data collected on OvmfIa32X64.dsc with GCC5 tool chain. Raw image is a little bigger. But, the compressed size is a little smaller.
>
> PEIFV 178472 --> 179176 +704 (Bytes)
> DXEFV 4062512 --> 4075056 +12544 (Bytes)
> FVMAIN_COMPACT 1190896 --> 1184920 -5976 (Bytes)
>
I don't care deeply, but given that --whole-archive is used as a debug
feature (we don't actually need the whole archive, but we want to
force a linker error if duplicate symbols exist), I don't think it
belongs in the RELEASE configuration.
next prev parent reply other threads:[~2017-08-28 16:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-24 6:28 [Patch] BaseTools: Enable --whole-archive in GCC tool chain as the default option Liming Gao
2017-08-25 10:28 ` Laszlo Ersek
2017-08-25 10:30 ` Ard Biesheuvel
2017-08-25 11:48 ` Laszlo Ersek
2017-08-28 3:27 ` Gao, Liming
2017-08-28 16:59 ` Ard Biesheuvel [this message]
2017-08-29 7:41 ` Gao, Liming
2017-08-29 13:33 ` Ard Biesheuvel
2017-08-29 15:47 ` Kinney, Michael D
2017-08-29 16:37 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKv+Gu_BqsLebVUm539axgoqgmYYB+uOTPMjWB-m_Ox_ozsh9Q@mail.gmail.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox