From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-x232.google.com (mail-io0-x232.google.com [IPv6:2607:f8b0:4001:c06::232]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id CE9A12095DCA4 for ; Mon, 28 Aug 2017 09:56:31 -0700 (PDT) Received: by mail-io0-x232.google.com with SMTP id k22so3777505iod.2 for ; Mon, 28 Aug 2017 09:59:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=F0+PuGziqVEqsQKnMlf9rBpkFJ0EdCXNwALu5+/RpsA=; b=VzEf7WBV3A6J9f5obKo1/4Q6+d292s3TIuIqRFykpwSmAOuu2eb+Dx6gIJDC7wh9eG JvYHVuSZ2clbcPUF833KAtZnupzKWXB57vW+RFUDG3/Q3EMoBCg/Nmos6GsiXNgmWq51 z0QMjVf6QKVsSoPXlMw3GUiB0qXRdclcHzdpo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=F0+PuGziqVEqsQKnMlf9rBpkFJ0EdCXNwALu5+/RpsA=; b=hGMSi6C0UL9r7ylH1rKz4iWaofb2BxKRX+SKKEzID5knYcuumOWsml84w74d0zxxhh lk54P45jg+jJqIUFufETL9TPcvZIMGOkdDa9HnALySAQ7NXeG6rHT1rCgEQ1PHUkyw95 I9iBd+t3akYq3w1WTip1o8uGETJQqzV9A5SgE3U6NEHtsan0RK0vEd+HBKYFHQtg9Bqz 7K9t+kMAGiT8/jLk6M+3VWQEzrf9kQCKuepo9WyqzZ81YIyvHLOBa54SZTymoVtbi+Tu v7Bo03M1OHRxtRZ+JD4rlCsQrYZQEpSPUva9jb85en//Uaw5YfdDbzbWZfC9dLGNVJZa eO8A== X-Gm-Message-State: AHYfb5jCs6n8SdkIKaB46GJ5Dr4zyQJnQ074lblMkFreI6hpnHpu1ypj N7OZbuzMxIq0WUyd+z1MzWowemtt1kiW X-Received: by 10.36.178.87 with SMTP id h23mr1301722iti.128.1503939550710; Mon, 28 Aug 2017 09:59:10 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.162.1 with HTTP; Mon, 28 Aug 2017 09:59:10 -0700 (PDT) In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14D78139F@shsmsx102.ccr.corp.intel.com> References: <1503556125-7024-1-git-send-email-liming.gao@intel.com> <2cf820ad-4a6d-648e-560b-d223bef9b45d@redhat.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14D78139F@shsmsx102.ccr.corp.intel.com> From: Ard Biesheuvel Date: Mon, 28 Aug 2017 17:59:10 +0100 Message-ID: To: "Gao, Liming" Cc: Laszlo Ersek , "edk2-devel@lists.01.org" Subject: Re: [Patch] BaseTools: Enable --whole-archive in GCC tool chain as the default option X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Aug 2017 16:56:32 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On 28 August 2017 at 04:27, Gao, Liming wrote: > Laszlo: > I will update the patch with your comments. > > Ard: > We collect the size impact in Ovmf platform. Its impact is small. So, m= y patch enable this option for all targets. Below is the data collected on = OvmfIa32X64.dsc with GCC5 tool chain. Raw image is a little bigger. But, th= e compressed size is a little smaller. > > PEIFV 178472 --> 179176 +704 (Bytes) > DXEFV 4062512 --> 4075056 +12544 (Bytes) > FVMAIN_COMPACT 1190896 --> 1184920 -5976 (Bytes) > I don't care deeply, but given that --whole-archive is used as a debug feature (we don't actually need the whole archive, but we want to force a linker error if duplicate symbols exist), I don't think it belongs in the RELEASE configuration.