From: "Ard Biesheuvel" <ard.biesheuvel@linaro.org>
To: edk2-devel-groups-io <devel@edk2.groups.io>, leif@nuviainc.com
Subject: Re: [PATCH 0/2] some ARM fixes
Date: Tue, 14 Jan 2020 17:43:16 +0100 [thread overview]
Message-ID: <CAKv+Gu_C1th+4jMkxNAqrij0+tW6u9iAFgJ3pexi+2twN0zbqg@mail.gmail.com> (raw)
In-Reply-To: <20200107092215.3271-1-ard.biesheuvel@linaro.org>
On Tue, 7 Jan 2020 at 10:22, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote:
>
> Some preparatory fixes for TPM measured boot on ARM systems.
>
> Patch #1 removes EnterS3WithImmediateWake() with the associated support
> code from ArmSmcPsciResetSystemLib. EnterS3WithImmediateWake () is no
> longer being called anywhere, and will be removed from ResetSystemLib,
> and the support code dependencies on DXE facilities are preventing this
> library from being used in the PEI phase, which is needed for TPM support.
>
> Patch #2 adds the missing call to enable VFP on PrePeiCore based platforms.
> This is causing TPM crypto code to blow up.
>
> Ard Biesheuvel (2):
> ArmPkg/ArmSmcPsciResetSystemLib: remove EnterS3WithImmediateWake ()
> ArmPlatformPkg/PrePeiCore: enable VFP at startup
>
Ping?
> ArmPkg/ArmPkg.dec | 4 --
> ArmPkg/Library/ArmSmcPsciResetSystemLib/ArmSmcPsciResetSystemLib.inf | 17 -----
> ArmPlatformPkg/PrePeiCore/PrePeiCoreMPCore.inf | 1 +
> ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf | 1 +
> ArmPkg/Library/ArmSmcPsciResetSystemLib/ArmSmcPsciResetSystemLib.c | 66 +-------------------
> ArmPlatformPkg/PrePeiCore/PrePeiCore.c | 5 ++
> ArmPkg/Library/ArmSmcPsciResetSystemLib/AArch64/Reset.S | 24 -------
> ArmPkg/Library/ArmSmcPsciResetSystemLib/AArch64/Reset.asm | 29 ---------
> ArmPkg/Library/ArmSmcPsciResetSystemLib/Arm/Reset.S | 23 -------
> ArmPkg/Library/ArmSmcPsciResetSystemLib/Arm/Reset.asm | 28 ---------
> 10 files changed, 9 insertions(+), 189 deletions(-)
> delete mode 100644 ArmPkg/Library/ArmSmcPsciResetSystemLib/AArch64/Reset.S
> delete mode 100644 ArmPkg/Library/ArmSmcPsciResetSystemLib/AArch64/Reset.asm
> delete mode 100644 ArmPkg/Library/ArmSmcPsciResetSystemLib/Arm/Reset.S
> delete mode 100644 ArmPkg/Library/ArmSmcPsciResetSystemLib/Arm/Reset.asm
>
> --
> 2.20.1
>
next prev parent reply other threads:[~2020-01-14 16:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-07 9:22 [PATCH 0/2] some ARM fixes Ard Biesheuvel
2020-01-07 9:22 ` [PATCH 1/2] ArmPkg/ArmSmcPsciResetSystemLib: remove EnterS3WithImmediateWake () Ard Biesheuvel
2020-01-14 17:18 ` Leif Lindholm
2020-01-14 17:42 ` Ard Biesheuvel
2020-01-07 9:22 ` [PATCH 2/2] ArmPlatformPkg/PrePeiCore: enable VFP at startup Ard Biesheuvel
2020-01-14 17:33 ` Leif Lindholm
2020-01-14 16:43 ` Ard Biesheuvel [this message]
2020-01-14 22:15 ` [PATCH 0/2] some ARM fixes Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKv+Gu_C1th+4jMkxNAqrij0+tW6u9iAFgJ3pexi+2twN0zbqg@mail.gmail.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox