From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by mx.groups.io with SMTP id smtpd.web11.984.1579020210139536850 for ; Tue, 14 Jan 2020 08:43:30 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=flMQYZ2+; spf=pass (domain: linaro.org, ip: 209.85.221.65, mailfrom: ard.biesheuvel@linaro.org) Received: by mail-wr1-f65.google.com with SMTP id g17so12857199wro.2 for ; Tue, 14 Jan 2020 08:43:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=sRT160qD97YTLx7aj73vzO0LNnWbae5BaqOKzeAkWiU=; b=flMQYZ2+EqeBOs+MYEp7n6ZuX/nB1lRcUj78KaoWkDc+6cGcKl8KCj0sQrdw8vPxdM z+QZOvc0HmCGkQ7kerOg8QlB/op+grqWfZXoNn3Ux19Lperrc2CTVa17+xW4qqXVlhXw NCKKF8S0ZKuFi0gbOOCpzK13dHUk9vApaO3t604cDfZne1t6OAgMpu35CYOaqG0UoysM n2UApCBYmaMsP+E4TsXxvIwolOK64j/94e11EzMhaJHbNtsVqdlNTeMs/PaCIHq+qnyf +QeSQLxMn73pduUsjbtYMr8CWADVLt5iQ9zy262JQ+dI5s3JBhY5XoSDvefbipABuQzq 0qTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=sRT160qD97YTLx7aj73vzO0LNnWbae5BaqOKzeAkWiU=; b=Kd4xmYizhCDD5otwejoNXfJsOgfSA0m4hp/yCgPEhxo6xNdBYZ8c3d36TgDBx/9+4G iVbarxmEaKHiaVEv5x1xS5sEdykTdAlglC+YM75xtc8j0e+pf6wIawcDg28814qBhhQM cUDJQ22dDqzB2oy/CpWU25IlSTmUI6OjqLfYj+UUJrDwiHMpWCBRC1QrKVqzW7bu9zQp Y/IG6GKRGIYS8182sfELkkl50XchEnc6+icV0r/P+gJDOMUj+sr/9y98hHfkEXbwsbW2 UnIvF3cqMBhlp/PTIxsxRozFZAJYOGzAEwHd2/U6CO01V99++vwA3GlsTAOHq3eJb2Kf PiVg== X-Gm-Message-State: APjAAAUDVKhxkdxKT4lMqDm9L2y+sTnV8qBNek4Z83OH5xMwAGtuH5nY 1sLgLVG2fDSvDxWOhwC+h2zI+kKybTKOiCAG9ALZAVL83yo= X-Google-Smtp-Source: APXvYqzYI6sVm1V+xGNcSl0di0Ch1yngil+kIyDvr0cN9uxjk/3Nk/nnEJlc733QHnLdioHSiLmJpK85WKjcFDitXus= X-Received: by 2002:a5d:6652:: with SMTP id f18mr9224480wrw.246.1579020208333; Tue, 14 Jan 2020 08:43:28 -0800 (PST) MIME-Version: 1.0 References: <20200107092215.3271-1-ard.biesheuvel@linaro.org> In-Reply-To: <20200107092215.3271-1-ard.biesheuvel@linaro.org> From: "Ard Biesheuvel" Date: Tue, 14 Jan 2020 17:43:16 +0100 Message-ID: Subject: Re: [PATCH 0/2] some ARM fixes To: edk2-devel-groups-io , leif@nuviainc.com Content-Type: text/plain; charset="UTF-8" On Tue, 7 Jan 2020 at 10:22, Ard Biesheuvel wrote: > > Some preparatory fixes for TPM measured boot on ARM systems. > > Patch #1 removes EnterS3WithImmediateWake() with the associated support > code from ArmSmcPsciResetSystemLib. EnterS3WithImmediateWake () is no > longer being called anywhere, and will be removed from ResetSystemLib, > and the support code dependencies on DXE facilities are preventing this > library from being used in the PEI phase, which is needed for TPM support. > > Patch #2 adds the missing call to enable VFP on PrePeiCore based platforms. > This is causing TPM crypto code to blow up. > > Ard Biesheuvel (2): > ArmPkg/ArmSmcPsciResetSystemLib: remove EnterS3WithImmediateWake () > ArmPlatformPkg/PrePeiCore: enable VFP at startup > Ping? > ArmPkg/ArmPkg.dec | 4 -- > ArmPkg/Library/ArmSmcPsciResetSystemLib/ArmSmcPsciResetSystemLib.inf | 17 ----- > ArmPlatformPkg/PrePeiCore/PrePeiCoreMPCore.inf | 1 + > ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf | 1 + > ArmPkg/Library/ArmSmcPsciResetSystemLib/ArmSmcPsciResetSystemLib.c | 66 +------------------- > ArmPlatformPkg/PrePeiCore/PrePeiCore.c | 5 ++ > ArmPkg/Library/ArmSmcPsciResetSystemLib/AArch64/Reset.S | 24 ------- > ArmPkg/Library/ArmSmcPsciResetSystemLib/AArch64/Reset.asm | 29 --------- > ArmPkg/Library/ArmSmcPsciResetSystemLib/Arm/Reset.S | 23 ------- > ArmPkg/Library/ArmSmcPsciResetSystemLib/Arm/Reset.asm | 28 --------- > 10 files changed, 9 insertions(+), 189 deletions(-) > delete mode 100644 ArmPkg/Library/ArmSmcPsciResetSystemLib/AArch64/Reset.S > delete mode 100644 ArmPkg/Library/ArmSmcPsciResetSystemLib/AArch64/Reset.asm > delete mode 100644 ArmPkg/Library/ArmSmcPsciResetSystemLib/Arm/Reset.S > delete mode 100644 ArmPkg/Library/ArmSmcPsciResetSystemLib/Arm/Reset.asm > > -- > 2.20.1 >