Re: [edk2-devel][PATCH v2 0/6] Platform/RPi: User config improvements

["Ard Biesheuvel" <ard.biesheuvel@linaro.org>]

On Tue, 3 Mar 2020 at 14:08, Pete Batard <pete@akeo.ie> wrote:
>
> Changes from v1:
> * Split first commit into 2 patches.
> * Clarify commit message for 3/6 and remove extra line-removal hunk.
> * Improve and clarify computation of 3G+ segment size in
>   ConfigDxe.c/ApplyVariables ().
> * Minor whitespace fixes (e.g. "3GB" -> "3 GB" in strings).
>
> Andrei Warkentin (4):
>   Platform/RPi: Add firmware call to read installed memory size
>   Platform/RPi: Use GetModelInstalledMB () to read RAM size
>   Platform/RPi: Separate RAM descriptors between 0-3 GB and 3+ GB
>   Platform/RPi: Make 3GB/4GB a runtime (BIOS setup) choice
>
> Pete Batard (2):
>   Platform/RPi: Make Device Tree provision a runtime (BIOS setup) choice
>   Platform/RPi/ConfigDxe: Improve RPi configuration form

Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

Pushed as d5f7c68948a3..dac18ca51781

Thanks!

>
>  Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c                 | 80 ++++++++++++++++---
>  Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.inf               |  9 ++-
>  Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxeHii.uni            | 38 ++++++---
>  Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxeHii.vfr            | 84 +++++++++++++++++---
>  Platform/RaspberryPi/Drivers/FdtDxe/FdtDxe.c                       |  5 ++
>  Platform/RaspberryPi/Drivers/FdtDxe/FdtDxe.inf                     |  3 +
>  Platform/RaspberryPi/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.c | 10 +--
>  Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c       | 29 ++++++-
>  Platform/RaspberryPi/Include/Protocol/RpiFirmware.h                | 47 ++++++-----
>  Platform/RaspberryPi/Library/PlatformLib/PlatformLib.inf           |  3 -
>  Platform/RaspberryPi/Library/PlatformLib/RaspberryPiMem.c          | 32 +++++---
>  Platform/RaspberryPi/RPi3/RPi3.dsc                                 | 11 +++
>  Platform/RaspberryPi/RPi4/RPi4.dsc                                 | 16 ++--
>  Platform/RaspberryPi/RPi4/RPi4.fdf                                 |  2 -
>  Platform/RaspberryPi/RPi4/Readme.md                                | 15 ++--
>  Platform/RaspberryPi/RaspberryPi.dec                               |  6 +-
>  16 files changed, 297 insertions(+), 93 deletions(-)
>
> --
> 2.21.0.windows.1
>