From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68])
 by mx.groups.io with SMTP id smtpd.web10.4227.1583244468761244365
 for <devel@edk2.groups.io>;
 Tue, 03 Mar 2020 06:07:49 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@linaro.org header.s=google header.b=wioX8Xjs;
 spf=pass (domain: linaro.org, ip: 209.85.128.68, mailfrom: ard.biesheuvel@linaro.org)
Received: by mail-wm1-f68.google.com with SMTP id e26so2964007wme.5
        for <devel@edk2.groups.io>; Tue, 03 Mar 2020 06:07:48 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=Y5iGe7ps/L1VHuAiuhso7hX0AdssW+/78ujyfxpYs14=;
        b=wioX8XjsC9X24ofVL/jr33ZOrEXoT3c6M+gaxYIi7+YXgR9rZRaDqwTTxeJeU09sCt
         GFuKytihojbNBLu5BxbpbIdZxE1CYQHo7u1fidpmgjEtv2G/bgwoIwnRxhn/w6IvswpN
         6bkUE2HVibU37uFLMTtJQMUbzBpc653P/PHxusQIvzJK7lT23/l0YZYg5ZRysJka3NMg
         9izRDuSCqjdjwnuKRb6i2lsE6DRwkD7lA5fwW4/w1nK+eyWsVfx/97v32JD9q6X2mRS0
         KTGGA+jvxMPTPV4a+5Apzk1U04ReMyNNnUKcPKqicag6lNatxtqLpnAVWGO084yPW3jY
         Pkvw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=Y5iGe7ps/L1VHuAiuhso7hX0AdssW+/78ujyfxpYs14=;
        b=gL3H07J4ra+sHPH/g5i44w901Uis7P00Vb3zeOd9GJXy+hoUTUOvJsu/WOHNCyWmzw
         KK1Fp6CJhCS4VODrDJOOgn9LR1ZfTxMCe8GAMEwX8CV/d4bi0aJVKGwLhfqgidXxmRzH
         +oe/q1PN8BUxopsXAT1lid/fdhXK7zhFO3htrxxH7494mEB95f3o/kiQf4Oh5VgLa4qL
         VA2Oj+8X54q0CULrslEjXqW6XUtphzgog8ULkW/1BBIUBSKxvYX5R23mCy+k8Mn/5PvO
         GzkvfcYT/DO5PzvFGRKUyYhvvd41tN8QjMA56iPvawfqWC5kOqYoIC16Aa5ZSJL+OOfU
         d4HA==
X-Gm-Message-State: ANhLgQ21cfB4vCsfg/ANMrcQUzGk4WZjBsUN4X2t3yjZjENWP+2RW/xV
	61W/HskR5XZi0hEUhSm5hnKsuObkI2nQfcvN8V69pg==
X-Google-Smtp-Source: ADFU+vsX2bypvFYW0ueTrdLg9TZj4UdxKkOAHvVUjTDJ0PhP2uxrhR5T5v6qy5c8fZ1P7aLq8JHSzKbQLY0FQP4FNmk=
X-Received: by 2002:a1c:2d88:: with SMTP id t130mr4827923wmt.68.1583244467200;
 Tue, 03 Mar 2020 06:07:47 -0800 (PST)
MIME-Version: 1.0
References: <20200303130814.3092-1-pete@akeo.ie>
In-Reply-To: <20200303130814.3092-1-pete@akeo.ie>
From: "Ard Biesheuvel" <ard.biesheuvel@linaro.org>
Date: Tue, 3 Mar 2020 15:07:36 +0100
Message-ID: <CAKv+Gu_CNgTY+3j1oP9eUfwHDrk44wfYK+36ssMPuRsT5pW__Q@mail.gmail.com>
Subject: Re: [edk2-devel][PATCH v2 0/6] Platform/RPi: User config improvements
To: Pete Batard <pete@akeo.ie>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>, Leif Lindholm <leif@nuviainc.com>, 
	=?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= <philmd@redhat.com>, 
	Andrei Warkentin <awarkentin@vmware.com>
Content-Type: text/plain; charset="UTF-8"

On Tue, 3 Mar 2020 at 14:08, Pete Batard <pete@akeo.ie> wrote:
>
> Changes from v1:
> * Split first commit into 2 patches.
> * Clarify commit message for 3/6 and remove extra line-removal hunk.
> * Improve and clarify computation of 3G+ segment size in
>   ConfigDxe.c/ApplyVariables ().
> * Minor whitespace fixes (e.g. "3GB" -> "3 GB" in strings).
>
> Andrei Warkentin (4):
>   Platform/RPi: Add firmware call to read installed memory size
>   Platform/RPi: Use GetModelInstalledMB () to read RAM size
>   Platform/RPi: Separate RAM descriptors between 0-3 GB and 3+ GB
>   Platform/RPi: Make 3GB/4GB a runtime (BIOS setup) choice
>
> Pete Batard (2):
>   Platform/RPi: Make Device Tree provision a runtime (BIOS setup) choice
>   Platform/RPi/ConfigDxe: Improve RPi configuration form

Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

Pushed as d5f7c68948a3..dac18ca51781

Thanks!

>
>  Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c                 | 80 ++++++++++++++++---
>  Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.inf               |  9 ++-
>  Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxeHii.uni            | 38 ++++++---
>  Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxeHii.vfr            | 84 +++++++++++++++++---
>  Platform/RaspberryPi/Drivers/FdtDxe/FdtDxe.c                       |  5 ++
>  Platform/RaspberryPi/Drivers/FdtDxe/FdtDxe.inf                     |  3 +
>  Platform/RaspberryPi/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.c | 10 +--
>  Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c       | 29 ++++++-
>  Platform/RaspberryPi/Include/Protocol/RpiFirmware.h                | 47 ++++++-----
>  Platform/RaspberryPi/Library/PlatformLib/PlatformLib.inf           |  3 -
>  Platform/RaspberryPi/Library/PlatformLib/RaspberryPiMem.c          | 32 +++++---
>  Platform/RaspberryPi/RPi3/RPi3.dsc                                 | 11 +++
>  Platform/RaspberryPi/RPi4/RPi4.dsc                                 | 16 ++--
>  Platform/RaspberryPi/RPi4/RPi4.fdf                                 |  2 -
>  Platform/RaspberryPi/RPi4/Readme.md                                | 15 ++--
>  Platform/RaspberryPi/RaspberryPi.dec                               |  6 +-
>  16 files changed, 297 insertions(+), 93 deletions(-)
>
> --
> 2.21.0.windows.1
>