From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by mx.groups.io with SMTP id smtpd.web12.3271.1575577554698755299 for ; Thu, 05 Dec 2019 12:25:55 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=rGjGY1Zw; spf=pass (domain: linaro.org, ip: 209.85.221.65, mailfrom: ard.biesheuvel@linaro.org) Received: by mail-wr1-f65.google.com with SMTP id q10so5161754wrm.11 for ; Thu, 05 Dec 2019 12:25:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=jpbTzmxtQj+1pGU3d3BrrGKCBwldBVB1G/ySxbOFlyA=; b=rGjGY1ZwGfC5dqy4T99w4zh+bLBeseV9QTZMbkf/5t5x0XakMKT4JV6+NvxlfxGxwl 0FjZN94uBzRAfCxjwEs0IuPhdxSUq1S2Yy6T8ptCKxBI4ypcJ4Il6jbdJOI02qpcFmE+ MNvojNLQmwpxkcUPX5J7YxwDEkW0gHeBN67yx8SMrLSwWcamAXPBLTMhilJpwMzNKqM6 rHxQUvL+iAmz8kCvVMJEheb2ElGRW6oqtHvR/iJ57FoLat1HKNXHv17UaH9ciRbiBNrc jTQQAH9Cj0zHAoglKq+V4TjjlUFjyH7Cy+c0qz/YtzpddrfV64AzzimkZnu1o86bLXZo enhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=jpbTzmxtQj+1pGU3d3BrrGKCBwldBVB1G/ySxbOFlyA=; b=koXboi5uz/zK3YePSqnb+PGrsUKu6DE7JIUHCejR5lmTGPQXJYDXdgQT8ncgwUoCpe cd9HlDMJDSvoKEcLveA5FRvLHtG04b4paSVo9ztGCg8GYKMVKr3yrptmwXvfvi5ZjWNT afPT1ojZsFk5V5EZpKazD++XlsFV6dsot7IFasbtYNZ1YXDHqsfK1iMskQYEUI7vNQDp BVpzRmM7x3PBN39i0DmknSNjkBoCKoyceJjDTNxq1V5XvW/LEP/oEE/KCpX5Ha3Cn0g3 NGWOG4qEzVyFJ+BGRowCn7W1LA0QOk96J2ZbgvucUxPyKM7E+B26ihP8EPI7kHlgx8N5 Y8cA== X-Gm-Message-State: APjAAAV1qXvZuNX/Uj5gX0+ydYBQTRQ/dmQzHgfeZcW/ANvYnSfxhAuM KMKRXSANoLjhGx76E7gKpZA1NI10zEuW+T7FtT49gw== X-Google-Smtp-Source: APXvYqz1m3/xmx7lWRpCgB5Gd5y4im2Uj5kHEsNEObPTgSQgDPyAOv3K7eh3bFtW7UO4wfxfmyVAv8cz6V0n33DncOQ= X-Received: by 2002:a5d:6652:: with SMTP id f18mr12438857wrw.246.1575577553227; Thu, 05 Dec 2019 12:25:53 -0800 (PST) MIME-Version: 1.0 References: <20190501140146.33224-1-sami.mujawar@arm.com> In-Reply-To: <20190501140146.33224-1-sami.mujawar@arm.com> From: "Ard Biesheuvel" Date: Thu, 5 Dec 2019 20:25:49 +0000 Message-ID: Subject: Re: [PATCH v1 1/1] ArmPkg: Dispatch deferred images after EndOfDxe To: Sami Mujawar Cc: edk2-devel-groups-io , Leif Lindholm , Matteo Carlini , nd Content-Type: text/plain; charset="UTF-8" On Wed, 1 May 2019 at 15:02, Sami Mujawar wrote: > > Third party driver images loaded from Option ROM get queued > for execution after EndOfDxe. These queued images need to be > dispatched from the PlatformBootManagerLib. > > Since the queued images were not dispatched, the PCI Option > ROM drivers were not getting loaded on Juno. Therefore, > add call to EfiBootManagerDispatchDeferredImages() for > dispatching deferred images from PlatformBootManagerLib. > > Signed-off-by: Sami Mujawar > --- > > The changes can be seen at https://github.com/samimujawar/edk2/tree/527_option_rom_loading_v1 > > ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c b/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c > index 0f91692c1a5ee6104bfef8545e4f436e53042178..71b857b5ba884c27ab870f6b75fa3e34d48e6060 100644 > --- a/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c > +++ b/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c > @@ -2,7 +2,7 @@ > Implementation for PlatformBootManagerLib library class interfaces. > > Copyright (C) 2015-2016, Red Hat, Inc. > - Copyright (c) 2014, ARM Ltd. All rights reserved.
> + Copyright (c) 2014 - 2019, ARM Ltd. All rights reserved.
> Copyright (c) 2004 - 2018, Intel Corporation. All rights reserved.
> Copyright (c) 2016, Linaro Ltd. All rights reserved.
> > @@ -554,6 +554,11 @@ PlatformBootManagerBeforeConsole ( > EfiEventGroupSignal (&gEfiEndOfDxeEventGroupGuid); > > // > + // Dispatch deferred images after EndOfDxe event. > + // > + EfiBootManagerDispatchDeferredImages (); > + > + // > // Locate the PCI root bridges and make the PCI bus driver connect each, > // non-recursively. This will produce a number of child handles with PciIo on > // them. OK, given that other implementations of PlatformBootManagerLib also make this call after signalling EndOfDxe, this is obviously the correct thing to do. I'm still curious why this difference exists, but it doesn't make sense to block this patch from going in, considering that I haven't been able to investigate. So I'll merge this - I just need to figure out how to use the new CI based workflow :-)