From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: Marcin Wojtas <mw@semihalf.com>
Cc: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
"Leif Lindholm" <leif.lindholm@linaro.org>,
"Wu, Hao A" <hao.a.wu@intel.com>,
"Nadav Haklai" <nadavh@marvell.com>,
"Jan Dąbroś" <jsd@semihalf.com>,
"Grzegorz Jaszczyk" <jaz@semihalf.com>,
"Kostya Porotchkin" <kostap@marvell.com>,
"Tomasz Michalec" <tm@semihalf.com>
Subject: Re: [platforms: PATCH v4 7/7] Marvell/Drivers: XenonDxe: Switch to use generic SdMmcPciHcDxe
Date: Mon, 12 Nov 2018 11:36:23 +0100 [thread overview]
Message-ID: <CAKv+Gu_E6=32evG=PYojtm7rJbTpk53xaJNhdv+078PsZKpcEA@mail.gmail.com> (raw)
In-Reply-To: <1541804508-27499-8-git-send-email-mw@semihalf.com>
On Sat, 10 Nov 2018 at 00:02, Marcin Wojtas <mw@semihalf.com> wrote:
>
> From: Tomasz Michalec <tm@semihalf.com>
>
> XenonDxe was copy of SdMmcPciHcDxe from edk2/MdeModulePkg.
>
> Now it implements SdMmcOverride protocol which allows
> to add quirks to the generic SdMmcPciHcDxe.
>
> Platforms that were using XenonDxe/SdMmcPciHcDxe have fixed *.fdf
> and *.dsc.inc files to use new implementation of XenonDxe.
>
> In the new version of the driver apart from using SdMmcOverride
> protocol, this patch utilizes newly added controllers'
> description in MvBoardDesc protocol, as well as improved
> PHY configuration sequence.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Marcin Wojtas <mw@semihalf.com>
Could you please split this up in 2 patches: one that removes the old
files and one that adds back the new ones? I want to review the new
code, but the size of the patch makes Chrome hang in the Gmail compose
window.
next prev parent reply other threads:[~2018-11-12 10:36 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-09 23:01 [platforms: PATCH v4 0/7] Armada7k8k Xenon driver rework Marcin Wojtas
2018-11-09 23:01 ` [platforms: PATCH v4 1/7] Silicon/SynQuacer/PlatformDxe: adjust to updated SdMmcOverride Marcin Wojtas
2018-11-12 10:24 ` Ard Biesheuvel
2018-11-09 23:01 ` [platforms: PATCH v4 2/7] Marvell/Library: ArmadaBoardDescLib: Extend SDMMC information Marcin Wojtas
2018-11-12 10:24 ` Ard Biesheuvel
2018-11-09 23:01 ` [platforms: PATCH v4 3/7] SolidRun/Armada80x0McBin: Introduce board description library Marcin Wojtas
2018-11-12 10:26 ` Ard Biesheuvel
2018-11-09 23:01 ` [platforms: PATCH v4 5/7] Marvell/Armada80x0Db: " Marcin Wojtas
2018-11-12 10:28 ` Ard Biesheuvel
2018-11-09 23:01 ` [platforms: PATCH v4 6/7] Marvell/Drivers: MvBoardDesc: Extend information for SdMmc Marcin Wojtas
2018-11-12 10:29 ` Ard Biesheuvel
2018-11-09 23:01 ` [platforms: PATCH v4 7/7] Marvell/Drivers: XenonDxe: Switch to use generic SdMmcPciHcDxe Marcin Wojtas
2018-11-12 10:36 ` Ard Biesheuvel [this message]
[not found] ` <1541804508-27499-5-git-send-email-mw@semihalf.com>
2018-11-12 10:27 ` [platforms: PATCH v4 4/7] Marvell/Armada70x0Db: Introduce board description library Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKv+Gu_E6=32evG=PYojtm7rJbTpk53xaJNhdv+078PsZKpcEA@mail.gmail.com' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox