From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::143; helo=mail-it1-x143.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it1-x143.google.com (mail-it1-x143.google.com [IPv6:2607:f8b0:4864:20::143]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id C30022194D3AE for ; Mon, 12 Nov 2018 02:36:36 -0800 (PST) Received: by mail-it1-x143.google.com with SMTP id j79-v6so12470067itb.2 for ; Mon, 12 Nov 2018 02:36:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=bdVPCrVCStTXNqbY8MeBY5Xjs4HGJP7ubYDQyJFyGx8=; b=FuLhP1HYhlk9Dck0XTel1/VXzP0AdUAGgMtqwNocxgoKu0r8DO6Tpk69QqwgZ2meNl aalu43Ff/nRnE7L7xcl1ZX4QHMiU9GWWQstoNRERFoVouEzrrbrsNX/+BQAmCj70uB9O hdwsk7a5WQoZ+8fUiyRxiSpBCuhpxC2jWKf7M= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=bdVPCrVCStTXNqbY8MeBY5Xjs4HGJP7ubYDQyJFyGx8=; b=CJlYTp94BFVAAgL+jeKMbJdk/+gwfextbu3WxNkkeRD1vG0oAGcy/MZe+AbVhZSMUP o3EnB18yu295jmSWig5GUu8Pypz1zqZpWE3oXGt1jmKlBxCA139r4gVrnwg7BxaPMavP +RgK5TXBge83ThAo7i7N8GpqKy0HdUQvY2AsYgdKV4CorzLgy3HrBKMUAcXDPE5VdFeh mGIqqt6nl6ywJhXZeGgnTXFlgJTZ0vkIPWvjW4sPRT1/VvWTEspSmdN2k/Wnuvip4rlb uYGaVCEe2msj3gwmg+tTdJxrQ3bP+lGT9p9HigZtH2WVYnGQMTDfXPl0NIYVTukeq33A MstQ== X-Gm-Message-State: AGRZ1gK3IfJYwx2IUP2NCbN7AO/t5aOYfChxJIunFQAedyVkYg48PvkE ZtVU9TBfzcZgTfLEz6n2ScfEx+7/AzSar3OWHhhP0A== X-Google-Smtp-Source: AJdET5eemBMrAaKSwSuzOG0TC5y87cG14LqhH3/HZYscqvmpi6fjGxfiuaJtgkFec/PFc7WerUG1p9Sd4eldWipKQwc= X-Received: by 2002:a24:2190:: with SMTP id e138-v6mr11622612ita.71.1542018995676; Mon, 12 Nov 2018 02:36:35 -0800 (PST) MIME-Version: 1.0 References: <1541804508-27499-1-git-send-email-mw@semihalf.com> <1541804508-27499-8-git-send-email-mw@semihalf.com> In-Reply-To: <1541804508-27499-8-git-send-email-mw@semihalf.com> From: Ard Biesheuvel Date: Mon, 12 Nov 2018 11:36:23 +0100 Message-ID: To: Marcin Wojtas Cc: "edk2-devel@lists.01.org" , Leif Lindholm , "Wu, Hao A" , Nadav Haklai , =?UTF-8?B?SmFuIETEhWJyb8Wb?= , Grzegorz Jaszczyk , Kostya Porotchkin , Tomasz Michalec Subject: Re: [platforms: PATCH v4 7/7] Marvell/Drivers: XenonDxe: Switch to use generic SdMmcPciHcDxe X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Nov 2018 10:36:37 -0000 Content-Type: text/plain; charset="UTF-8" On Sat, 10 Nov 2018 at 00:02, Marcin Wojtas wrote: > > From: Tomasz Michalec > > XenonDxe was copy of SdMmcPciHcDxe from edk2/MdeModulePkg. > > Now it implements SdMmcOverride protocol which allows > to add quirks to the generic SdMmcPciHcDxe. > > Platforms that were using XenonDxe/SdMmcPciHcDxe have fixed *.fdf > and *.dsc.inc files to use new implementation of XenonDxe. > > In the new version of the driver apart from using SdMmcOverride > protocol, this patch utilizes newly added controllers' > description in MvBoardDesc protocol, as well as improved > PHY configuration sequence. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Marcin Wojtas Could you please split this up in 2 patches: one that removes the old files and one that adds back the new ones? I want to review the new code, but the size of the patch makes Chrome hang in the Gmail compose window.